diff --git a/src/xmpp/jid.c b/src/xmpp/jid.c index 96c65f1c..449e1c92 100644 --- a/src/xmpp/jid.c +++ b/src/xmpp/jid.c @@ -43,23 +43,31 @@ #include "common.h" #include "xmpp/jid.h" +#define JID_MAX_PART_LEN 1023 +#define JID_MAX_TOTAL_LEN 3071 + +static gboolean +_is_invalid_local_char(gunichar c) +{ + // RFC 6122: " & ' / : < > @ + // Also space is forbidden. + return (c == ' ' || c == '"' || c == '&' || c == '\'' || c == '/' || c == ':' || c == '<' || c == '>' || c == '@'); +} + Jid* jid_create(const gchar* const str) { - Jid* result = NULL; + if (str == NULL) { + return NULL; + } - /* if str is NULL g_strdup returns NULL */ gchar* trimmed = g_strdup(str); if (trimmed == NULL) { return NULL; } - if (strlen(trimmed) == 0) { - g_free(trimmed); - return NULL; - } - - if (g_str_has_prefix(trimmed, "/") || g_str_has_prefix(trimmed, "@")) { + size_t len = strlen(trimmed); + if (len == 0 || len > JID_MAX_TOTAL_LEN) { g_free(trimmed); return NULL; } @@ -69,39 +77,81 @@ jid_create(const gchar* const str) return NULL; } - result = g_new0(Jid, 1); + Jid* result = g_new0(Jid, 1); result->refcnt = 1; + result->str = trimmed; - gchar* atp = g_utf8_strchr(trimmed, -1, '@'); gchar* slashp = g_utf8_strchr(trimmed, -1, '/'); - gchar* domain_start = trimmed; - - if (atp) { - result->localpart = g_utf8_substring(trimmed, 0, g_utf8_pointer_to_offset(trimmed, atp)); - domain_start = atp + 1; - } + auto_gchar gchar* bare = NULL; if (slashp) { result->resourcepart = g_strdup(slashp + 1); - result->domainpart = g_utf8_substring(domain_start, 0, g_utf8_pointer_to_offset(domain_start, slashp)); - auto_gchar gchar* barejidraw = g_utf8_substring(trimmed, 0, g_utf8_pointer_to_offset(trimmed, slashp)); - result->barejid = g_utf8_strdown(barejidraw, -1); + bare = g_utf8_substring(trimmed, 0, g_utf8_pointer_to_offset(trimmed, slashp)); result->fulljid = g_strdup(trimmed); } else { - result->domainpart = g_strdup(domain_start); - result->barejid = g_utf8_strdown(trimmed, -1); + bare = g_strdup(trimmed); } - if (result->domainpart == NULL) { + // Validate resourcepart + if (result->resourcepart) { + size_t rlen = strlen(result->resourcepart); + if (rlen == 0 || rlen > JID_MAX_PART_LEN) { + jid_destroy(result); + return NULL; + } + } + + gchar* atp = g_utf8_strchr(bare, -1, '@'); + gchar* domain_start = bare; + + if (atp) { + result->localpart = g_utf8_substring(bare, 0, g_utf8_pointer_to_offset(bare, atp)); + domain_start = atp + 1; + + // Validate localpart + size_t llen = strlen(result->localpart); + if (llen == 0 || llen > JID_MAX_PART_LEN) { + jid_destroy(result); + return NULL; + } + + const gchar* p = result->localpart; + while (*p) { + gunichar c = g_utf8_get_char(p); + if (_is_invalid_local_char(c)) { + jid_destroy(result); + return NULL; + } + p = g_utf8_next_char(p); + } + } + + result->domainpart = g_strdup(domain_start); + result->barejid = g_utf8_strdown(bare, -1); + + // Validate domainpart + size_t dlen = result->domainpart ? strlen(result->domainpart) : 0; + if (dlen == 0 || dlen > JID_MAX_PART_LEN) { jid_destroy(result); return NULL; } - result->str = trimmed; + // Domainpart cannot contain @ + if (g_utf8_strchr(result->domainpart, -1, '@')) { + jid_destroy(result); + return NULL; + } return result; } +gboolean +jid_is_valid(const gchar* const str) +{ + auto_jid Jid* jid = jid_create(str); + return (jid != NULL); +} + Jid* jid_create_from_bare_and_resource(const gchar* const barejid, const gchar* const resource) { diff --git a/src/xmpp/jid.h b/src/xmpp/jid.h index ea738a63..2d1aa127 100644 --- a/src/xmpp/jid.h +++ b/src/xmpp/jid.h @@ -52,6 +52,7 @@ struct jid_t typedef struct jid_t Jid; Jid* jid_create(const gchar* const str); +gboolean jid_is_valid(const gchar* const str); Jid* jid_create_from_bare_and_resource(const gchar* const barejid, const gchar* const resource); void jid_destroy(Jid* jid); void jid_ref(Jid* jid); diff --git a/tests/unittests/unittests.c b/tests/unittests/unittests.c index 688a7742..2f1cce20 100644 --- a/tests/unittests/unittests.c +++ b/tests/unittests/unittests.c @@ -150,6 +150,14 @@ main(int argc, char* argv[]) cmocka_unit_test(jid_create__returns__correct_parts_with_trailing_slash), cmocka_unit_test(jid_fulljid_or_barejid__returns__fulljid_when_exists), cmocka_unit_test(jid_fulljid_or_barejid__returns__barejid_when_fulljid_not_exists), + cmocka_unit_test(jid_create__returns__null_from_invalid_localpart_chars), + cmocka_unit_test(jid_create__returns__null_from_empty_parts), + cmocka_unit_test(jid_create__returns__null_from_multiple_at_in_bare), + cmocka_unit_test(jid_create__returns__correct_parts_with_at_in_resource_only), + cmocka_unit_test(jid_is_valid__is__true_for_valid_jid), + cmocka_unit_test(jid_is_valid__is__false_for_invalid_jid), + cmocka_unit_test(jid_is_valid__is__false_for_null), + cmocka_unit_test(jid_is_valid__is__false_for_empty_string), cmocka_unit_test(parse_args__returns__null_from_null), cmocka_unit_test(parse_args__returns__null_from_empty), diff --git a/tests/unittests/xmpp/test_jid.c b/tests/unittests/xmpp/test_jid.c index 51f66f08..99bbd231 100644 --- a/tests/unittests/xmpp/test_jid.c +++ b/tests/unittests/xmpp/test_jid.c @@ -234,3 +234,102 @@ jid_fulljid_or_barejid__returns__barejid_when_fulljid_not_exists(void** state) jid_destroy(jid); } + +void +jid_create__returns__null_from_invalid_localpart_chars(void** state) +{ + // Space + Jid* result = jid_create("user name@domain.com"); + assert_null(result); + + // Double quote + result = jid_create("user\"name@domain.com"); + assert_null(result); + + // Ampersand + result = jid_create("user&name@domain.com"); + assert_null(result); + + // Single quote + result = jid_create("user'name@domain.com"); + assert_null(result); + + // Colon + result = jid_create("user:name@domain.com"); + assert_null(result); + + // Less than + result = jid_create("username@domain.com"); + assert_null(result); +} + +void +jid_create__returns__null_from_empty_parts(void** state) +{ + // Empty local + Jid* result = jid_create("@domain.com"); + assert_null(result); + + // Empty domain (trailing @) + result = jid_create("user@"); + assert_null(result); + + // Empty resource (trailing /) + result = jid_create("user@domain.com/"); + assert_null(result); + + // Empty domain in full jid + result = jid_create("user@/resource"); + assert_null(result); +} + +void +jid_create__returns__null_from_multiple_at_in_bare(void** state) +{ + Jid* result = jid_create("user@domain@other.com"); + assert_null(result); +} + +void +jid_create__returns__correct_parts_with_at_in_resource_only(void** state) +{ + // domain.com/user@host (no localpart) + Jid* result = jid_create("domain.com/user@host"); + assert_non_null(result); + assert_null(result->localpart); + assert_string_equal("domain.com", result->domainpart); + assert_string_equal("user@host", result->resourcepart); + jid_destroy(result); +} + +void +jid_is_valid__is__true_for_valid_jid(void** state) +{ + assert_true(jid_is_valid("myuser@mydomain/laptop")); + assert_true(jid_is_valid("myuser@mydomain")); + assert_true(jid_is_valid("mydomain/laptop")); + assert_true(jid_is_valid("mydomain")); +} + +void +jid_is_valid__is__false_for_invalid_jid(void** state) +{ + assert_false(jid_is_valid("@mydomain")); + assert_false(jid_is_valid("/laptop")); +} + +void +jid_is_valid__is__false_for_null(void** state) +{ + assert_false(jid_is_valid(NULL)); +} + +void +jid_is_valid__is__false_for_empty_string(void** state) +{ + assert_false(jid_is_valid("")); +} diff --git a/tests/unittests/xmpp/test_jid.h b/tests/unittests/xmpp/test_jid.h index 4afccf23..92828758 100644 --- a/tests/unittests/xmpp/test_jid.h +++ b/tests/unittests/xmpp/test_jid.h @@ -26,5 +26,13 @@ void jid_create__returns__correct_parts_with_at_and_slash_in_resource(void** sta void jid_create__returns__correct_parts_with_trailing_slash(void** state); void jid_fulljid_or_barejid__returns__fulljid_when_exists(void** state); void jid_fulljid_or_barejid__returns__barejid_when_fulljid_not_exists(void** state); +void jid_create__returns__null_from_invalid_localpart_chars(void** state); +void jid_create__returns__null_from_empty_parts(void** state); +void jid_create__returns__null_from_multiple_at_in_bare(void** state); +void jid_create__returns__correct_parts_with_at_in_resource_only(void** state); +void jid_is_valid__is__true_for_valid_jid(void** state); +void jid_is_valid__is__false_for_invalid_jid(void** state); +void jid_is_valid__is__false_for_null(void** state); +void jid_is_valid__is__false_for_empty_string(void** state); #endif