devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

fix: fix api_get_current_occupants() memory problems

Browse Source 
Fix a potential NULL pointer dereference. And free the list properly.
This commit is contained in:
Michael Vetter
2026-02-27 20:12:16 +01:00
parent 2406413e14
commit 1ec536d343
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/api.c
View File

@@ -253,6 +253,11 @@ api_get_current_occupants(void)
assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK); assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
GList* occupants_list = muc_roster(mucwin->roomjid); GList* occupants_list = muc_roster(mucwin->roomjid);
char** result = malloc((g_list_length(occupants_list) + 1) * sizeof(char*)); char** result = malloc((g_list_length(occupants_list) + 1) * sizeof(char*));
if (result == NULL) {
g_list_free(occupants_list);
return NULL;
}
GList* curr = occupants_list; GList* curr = occupants_list;
int i = 0; int i = 0;
while (curr) { while (curr) {
@@ -261,6 +266,9 @@ api_get_current_occupants(void)
curr = g_list_next(curr); curr = g_list_next(curr);
} }
result[i] = NULL; result[i] = NULL;
g_list_free(occupants_list);
return result; return result;
} else { } else {
return NULL; return NULL;