fix(ui,db): harden NULL handling and resource lifecycle across UI and SQLite
Some checks failed
CI Code / Linux (arch) (pull_request) Failing after 20s
CI Code / Check spelling (pull_request) Successful in 24s
CI Code / Check coding style (pull_request) Failing after 36s
CI Code / Linux (ubuntu) (pull_request) Successful in 15m27s
CI Code / Linux (debian) (pull_request) Successful in 17m51s
Some checks failed
CI Code / Linux (arch) (pull_request) Failing after 20s
CI Code / Check spelling (pull_request) Successful in 24s
CI Code / Check coding style (pull_request) Failing after 36s
CI Code / Linux (ubuntu) (pull_request) Successful in 15m27s
CI Code / Linux (debian) (pull_request) Successful in 17m51s
ui/window: fix subwindow lifecycle (safe delwin on recreate), clamp widths, add fallback timestamp when loading history to avoid NULL deref ui/buffer: add GSList bounds checks; assert non-NULL timestamps when creating entries ui/titlebar: guard newwin failures; make draw/resize/free no-ops when window is NULL ui/statusbar: guard window creation/resize/close; clamp columns; fallback display name if JID parsing fails ui/inputwin: check newpad result; guard resize/getters/close on NULL; safe delwin ui/chatwin: guard buffer_get_entry/time before ISO8601 formatting ui/window_list: validate win_create_* results; don’t insert NULL windows; fix barejid leak in wins_get_by_string db/database: ensure cleanup on sqlite init/open failures; use sqlite3_close_v2 and warn if busy; always return a ProfMessage from log_database_get_limits_info and set current UTC timestamp when is_last with no row; initialize err_msg and free consistently; improve error messages Prevents crashes from NULL dereferences (e.g., during MAM history) and closes small leaks; improves robustness under OOM and allocation failures.
This commit is contained in:
@@ -111,16 +111,23 @@ status_bar_init(void)
|
||||
|
||||
int row = screen_statusbar_row();
|
||||
int cols = getmaxx(stdscr);
|
||||
if (cols <= 0) {
|
||||
cols = 1;
|
||||
}
|
||||
statusbar_win = newwin(1, cols, row, 0);
|
||||
|
||||
status_bar_draw();
|
||||
if (statusbar_win) {
|
||||
status_bar_draw();
|
||||
}
|
||||
}
|
||||
|
||||
void
|
||||
status_bar_close(void)
|
||||
{
|
||||
delwin(statusbar_win);
|
||||
statusbar_win = NULL;
|
||||
if (statusbar_win) {
|
||||
delwin(statusbar_win);
|
||||
statusbar_win = NULL;
|
||||
}
|
||||
if (statusbar) {
|
||||
if (statusbar->time) {
|
||||
g_free(statusbar->time);
|
||||
@@ -145,7 +152,13 @@ status_bar_close(void)
|
||||
void
|
||||
status_bar_resize(void)
|
||||
{
|
||||
if (!statusbar_win) {
|
||||
return;
|
||||
}
|
||||
int cols = getmaxx(stdscr);
|
||||
if (cols <= 0) {
|
||||
cols = 1;
|
||||
}
|
||||
werase(statusbar_win);
|
||||
int row = screen_statusbar_row();
|
||||
wresize(statusbar_win, 1, cols);
|
||||
@@ -285,6 +298,9 @@ status_bar_clear_fulljid(void)
|
||||
void
|
||||
status_bar_draw(void)
|
||||
{
|
||||
if (!statusbar_win) {
|
||||
return;
|
||||
}
|
||||
werase(statusbar_win);
|
||||
wbkgd(statusbar_win, theme_attrs(THEME_STATUS_TEXT));
|
||||
|
||||
@@ -674,8 +690,13 @@ _display_name(StatusBarTab* tab)
|
||||
fullname = g_strconcat(mucwin_title, " conf", NULL);
|
||||
} else if (tab->window_type == WIN_PRIVATE) {
|
||||
auto_jid Jid* jid = jid_create(tab->identifier);
|
||||
auto_gchar gchar* mucwin_title = mucwin_generate_title(jid->barejid, PREF_STATUSBAR_ROOM_TITLE);
|
||||
fullname = g_strconcat(mucwin_title, "/", jid->resourcepart, NULL);
|
||||
if (jid) {
|
||||
auto_gchar gchar* mucwin_title = mucwin_generate_title(jid->barejid, PREF_STATUSBAR_ROOM_TITLE);
|
||||
fullname = g_strconcat(mucwin_title, "/", jid->resourcepart, NULL);
|
||||
} else {
|
||||
// Fallback: use identifier directly if JID parsing failed
|
||||
fullname = strdup(tab->identifier);
|
||||
}
|
||||
} else {
|
||||
fullname = strdup("window");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user