devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 9 Actions Packages Projects 1 Releases Wiki Activity

removed strdup in autocomplete calls

Browse Source
This commit is contained in:
Dmitry Podgorny
2013-08-26 03:29:50 +03:00
parent 982f1174a8
commit 545a23e92f
8 changed files with 112 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/xmpp/bookmark.c
View File

@@ -69,7 +69,7 @@ bookmark_add(const char *jid, const char *nick, gboolean autojoin)
/* this may be command for modifying */
autocomplete_remove(bookmark_ac, jid);
autocomplete_add(bookmark_ac, strdup(jid));
autocomplete_add(bookmark_ac, jid);
}
void
@@ -174,7 +174,7 @@ _bookmark_handle_result(xmpp_conn_t * const conn,
autojoin_val = FALSE;
}
autocomplete_add(bookmark_ac, strdup(jid));
autocomplete_add(bookmark_ac, jid);
item = malloc(sizeof(*item));
item->jid = strdup(jid);
item->nick = name;

2
src/xmpp/presence.c
View File

@@ -372,7 +372,7 @@ _subscribe_handler(xmpp_conn_t * const conn,
}
prof_handle_subscription(from_jid->barejid, PRESENCE_SUBSCRIBE);
autocomplete_add(sub_requests_ac, strdup(from_jid->barejid));
autocomplete_add(sub_requests_ac, from_jid->barejid);
jid_destroy(from_jid);

12
src/xmpp/roster.c
View File

@@ -184,12 +184,12 @@ roster_add(const char * const barejid, const char * const name, GSList *groups,
// add groups
while (groups != NULL) {
autocomplete_add(groups_ac, strdup(groups->data));
autocomplete_add(groups_ac, groups->data);
groups = g_slist_next(groups);
}
g_hash_table_insert(contacts, strdup(barejid), contact);
autocomplete_add(barejid_ac, strdup(barejid));
autocomplete_add(barejid_ac, barejid);
_add_name_and_barejid(name, barejid);
if (!from_initial) {
@@ -226,7 +226,7 @@ roster_update(const char * const barejid, const char * const name,
// add groups
while (groups != NULL) {
autocomplete_add(groups_ac, strdup(groups->data));
autocomplete_add(groups_ac, groups->data);
groups = g_slist_next(groups);
}
}
@@ -248,7 +248,7 @@ roster_update_presence(const char * const barejid, Resource *resource,
}
p_contact_set_presence(contact, resource);
Jid *jid = jid_create_from_bare_and_resource(barejid, resource->name);
autocomplete_add(fulljid_ac, strdup(jid->fulljid));
autocomplete_add(fulljid_ac, jid->fulljid);
jid_destroy(jid);
return TRUE;
@@ -646,10 +646,10 @@ static void
_add_name_and_barejid(const char * const name, const char * const barejid)
{
if (name != NULL) {
autocomplete_add(name_ac, strdup(name));
autocomplete_add(name_ac, name);
g_hash_table_insert(name_to_barejid, strdup(name), strdup(barejid));
} else {
autocomplete_add(name_ac, strdup(barejid));
autocomplete_add(name_ac, barejid);
g_hash_table_insert(name_to_barejid, strdup(barejid), strdup(barejid));
}
}