devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 8 Actions Packages Projects 1 Releases Wiki Activity

fix: address code review comments from PR #79
All checks were successful
CI Code / Check spelling (pull_request) Successful in 17s
Details
CI Code / Check coding style (pull_request) Successful in 37s
Details
CI Code / Code Coverage (pull_request) Successful in 4m47s
Details
CI Code / Linux (debian) (pull_request) Successful in 6m8s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 6m12s
Details
CI Code / Linux (arch) (pull_request) Successful in 6m19s
Details

Browse Source 
- Add TEST_GROUPS constant to eliminate magic number
- Use stdout for info messages, stderr for errors only
- Remove redundant comments and dead code
- Add CI check before copying coverage.info
- Unify variable declaration order
- Add port allocation explanation comment
- Restore /* 50ms */ inline comment
- Update CONTRIBUTING.md with build 1 description
This commit is contained in:
jabber.developer2
2026-02-02 14:56:46 +03:00
parent cf86e60af6
commit 5978c77a45
3 changed files with 26 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@@ -91,7 +91,7 @@ set -e
This will run the same tests that the CI runs and refuse the push if it fails.
The CI script runs 4 parallel builds with different configurations, each with Valgrind and functional tests.
Use `./ci-build.sh --coverage-only` to run only build 1 with coverage collection.
Use `./ci-build.sh --coverage-only` to run only build 1 (full configuration with all optional components enabled) with coverage collection.
Output shows test results per build:
```