devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 8 Actions Packages Projects 1 Releases Wiki Activity

Fix memory corruption crash

Browse Source 
Under certain circumstances setting plain_str[len] to 0 might lead to crash
and it does not follow the best practices as well.

This change allows better handling of buffer copying and prevents crash.
This commit is contained in:
John Hernandez
2023-04-13 10:14:54 +02:00
parent 766dc76e33
commit 5e8f1f9c85
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/pgp/gpg.c
View File

@@ -721,10 +721,9 @@ p_gpg_decrypt(const char* const cipher)
char* plain_str = gpgme_data_release_and_get_mem(plain_data, &len); char* plain_str = gpgme_data_release_and_get_mem(plain_data, &len);
char* result = NULL; char* result = NULL;
if (plain_str) { if (plain_str) {
plain_str[len] = 0; result = strndup(plain_str, len);
result = g_strdup(plain_str); gpgme_free(plain_str);
} }
gpgme_free(plain_str);
if (passphrase_attempt) { if (passphrase_attempt) {
passphrase = strdup(passphrase_attempt); passphrase = strdup(passphrase_attempt);