merge: sync upstream profanity-im/profanity

Sync with upstream profanity-im/profanity.

Major upstream changes incorporated:

Memory management
  - Replace malloc+memset with g_new0 throughout codebase
  - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
  - Replace free() with g_free() for GAlloc'd memory

Editor rewrite
  - Remove pthread-based async editor; use GChildWatch callback API
  - New launch_editor(initial_content, callback, user_data) interface
  - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
  - ui_suspend()/ui_resume() integration for TTY management

OMEMO improvements
  - Dual backend support: libsignal-protocol-c and libomemo-c
  - Proper pre-key removal after use (XEP-0384 compliance)
  - Automatic pre-key regeneration when store drops below threshold
  - New functions: omemo_is_device_active(), omemo_is_jid_trusted()
  - omemo_get_jid_untrusted_fingerprints() for better error messages
  - Fingerprint notifications on new device identity discovery
  - Deterministic pre-key ID generation tracking max_pre_key_id
  - omemo_trust_changed() UI updates on trust state changes

JID validation
  - RFC 6122-compliant validation in jid_is_valid()
  - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
  - Length limits: 1023 per component, 3071 total
  - New jid_is_valid_user_jid() for user vs. service JID distinction

Database
  - Schema migration v3: UNIQUE constraint on archive_id for deduplication
  - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
  - db_history_result_t return type, _truncate_datetime_suffix()

UI / console
  - win_warn_needed() / win_warn_sent() warning deduplication hash table
  - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
  - Spellcheck integration in input field with Unicode word detection
  - cons_spellcheck_setting() for /settings ui output
  - /[command]? shortcut for command help

Account config
  - Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
  - Replace popen() with g_spawn_sync() for eval_password
  - TLS policy: add "direct" option alongside legacy

Connection
  - Port validation with g_assert (0–65535)
  - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
  - "direct" TLS policy alias for legacy SSL

Common utilities
  - str_xml_sanitize() for XML 1.0 illegal character removal
  - string_matches_one_of() with formatted error messages
  - valid_tls_policy_option() helper
  - prof_date_time_format_iso8601() utility
  - Improved strip_arg_quotes() with backslash unescaping
  - prof_occurrences() uses g_slist_prepend + reverse for performance

PGP / OX
  - Proper GPGME resource cleanup with goto-cleanup pattern
  - g_string_free(xmppuri) leak fix in _ox_key_lookup

CSV export
  - Use GString + g_file_set_contents instead of raw write() syscalls

Tests
  - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
  - New test_cmd_ac.c for autocompleter unit tests
  - Updated stubs for new UI suspend/resume functions

License headers
  - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)

────────────────────────────────────────────────────
cproof-specific preservations:

  - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
  - Force encryption: cmd_force_encryption, test_forced_encryption
  - CWE-134: format string protection (cons_show("%s", ...))
  - y_start_pos-based paging in window.c
  - db_history_result_t return type, _truncate_datetime_suffix()

Merge-time fixes:

  - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
  - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
  - console.c: implicit size_t → int cast — (int)(maxlen + 1)
  - tlscerts.c: %d for size_t — %zu

Build system:
  - Kept autotools (Makefile.am, configure.ac); upstream uses Meson
  - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
  - Updated Makefile.am test paths for subdirectory structure
  - Added test_cmd_ac, test_forced_encryption to test sources

Functional tests:
  - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
  - Not yet available in devs/stabber fork

Closes #64

Merge author: jabber.developer2
Commits authors:
 Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>

src/ui/inputwin.c

@@ -4,33 +4,7 @@
  *
  * Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
  *
- * This file is part of Profanity.
- *
- * Profanity is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * Profanity is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with Profanity.  If not, see <https://www.gnu.org/licenses/>.
- *
- * In addition, as a special exception, the copyright holders give permission to
- * link the code of portions of this program with the OpenSSL library under
- * certain conditions as described in each individual source file, and
- * distribute linked combinations including the two.
- *
- * You must obey the GNU General Public License in all respects for all of the
- * code used other than OpenSSL. If you modify file(s) with this exception, you
- * may extend this exception to your version of the file(s), but you are not
- * obligated to do so. If you do not wish to do so, delete this exception
- * statement from your version. If you delete this exception statement from all
- * source files in the program, then also delete it here.
- *
+ * SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
  */
 
 #define _XOPEN_SOURCE_EXTENDED
@@ -76,6 +50,7 @@
 #include "xmpp/roster_list.h"
 #include "xmpp/chat_state.h"
 #include "tools/editor.h"
+#include "tools/spellcheck.h"
 
 static WINDOW* inp_win;
 static int pad_start = 0;
@@ -90,6 +65,7 @@ static fd_set fds;
 static int r;
 static char* inp_line = NULL;
 static gboolean get_password = FALSE;
+static gboolean is_suspended = FALSE;
 
 static void _inp_win_update_virtual(void);
 static int _inp_edited(const wint_t ch);
@@ -204,6 +180,12 @@ _inp_slashguard_check(void)
 char*
 inp_readline(void)
 {
+    // UI is suspended
+    if (is_suspended || isendwin()) {
+        g_usleep(100000); // 100ms
+        return NULL;
+    }
+
     p_rl_timeout.tv_sec = inp_timeout / 1000;
     p_rl_timeout.tv_usec = inp_timeout % 1000 * 1000;
     FD_ZERO(&fds);
@@ -304,6 +286,22 @@ inp_close(void)
     discard = NULL;
 }
 
+void
+inp_suspend(void)
+{
+    is_suspended = TRUE;
+    rl_callback_handler_remove();
+    rl_deprep_terminal();
+}
+
+void
+inp_resume(void)
+{
+    is_suspended = FALSE;
+    rl_callback_handler_install(NULL, _inp_rl_linehandler);
+    rl_prep_terminal(0);
+}
+
 char*
 inp_get_line(void)
 {
@@ -380,12 +378,17 @@ _inp_write(char* line, int offset)
     getyx(inp_win, y, x);
     col += x;
 
+    gboolean do_spell = prefs_get_boolean(PREF_SPELLCHECK_ENABLE) && (line[0] != '/');
+
     for (size_t i = 0; line[i] != '\0'; i++) {
         char* c = &line[i];
         char retc[PROF_MB_CUR_MAX] = { 0 };
 
         size_t ch_len = mbrlen(c, MB_CUR_MAX, NULL);
-        if ((ch_len == (size_t)-2) || (ch_len == (size_t)-1)) {
+        // ch_len == 0 means mbrlen consumed the null wide character;
+        // skipping it here keeps `i += ch_len - 1` below from
+        // underflowing to SIZE_MAX.
+        if ((ch_len == (size_t)-2) || (ch_len == (size_t)-1) || ch_len == 0) {
             waddch(inp_win, ' ');
             continue;
         }
@@ -393,7 +396,7 @@ _inp_write(char* line, int offset)
         if (line[i] == '\n') {
             c = retc;
             ch_len = wctomb(retc, L'\u23ce'); /* return symbol */
-            if (ch_len == -1) {               /* not representable */
+            if (ch_len == (size_t)-1) {       /* not representable */
                 retc[0] = '\\';
                 ch_len = 1;
             }
@@ -401,7 +404,55 @@ _inp_write(char* line, int offset)
             i += ch_len - 1;
         }
 
-        waddnstr(inp_win, c, ch_len);
+        if (do_spell) {
+            gunichar uc = g_utf8_get_char(c);
+            if (g_unichar_isalnum(uc) || uc == '\'') {
+                // start of a word
+                size_t start = i - (ch_len - 1);
+                size_t end = start + ch_len;
+                while (line[end] != '\0') {
+                    size_t next_ch_len = mbrlen(&line[end], MB_CUR_MAX, NULL);
+                    // ch_len == 0 means embedded NUL — stop, otherwise
+                    // `end += next_ch_len` loops forever.
+                    if (next_ch_len == (size_t)-2 || next_ch_len == (size_t)-1 || next_ch_len == 0)
+                        break;
+                    gunichar next_uc = g_utf8_get_char(&line[end]);
+                    if (!g_unichar_isalnum(next_uc) && next_uc != '\'')
+                        break;
+                    end += next_ch_len;
+                }
+
+                auto_gchar gchar* word = g_strndup(&line[start], end - start);
+                gboolean misspelled = spellcheck_is_misspelled(word);
+
+                if (misspelled) {
+                    wattron(inp_win, theme_attrs(THEME_INPUT_MISSPELLED));
+                }
+
+                // add the word
+                size_t word_pos = start;
+                while (word_pos < end) {
+                    size_t cur_ch_len = mbrlen(&line[word_pos], MB_CUR_MAX, NULL);
+                    // Defensive: invalid or zero-length step would loop
+                    // forever; advance one byte and continue.
+                    if (cur_ch_len == (size_t)-2 || cur_ch_len == (size_t)-1 || cur_ch_len == 0) {
+                        word_pos++;
+                        continue;
+                    }
+                    waddnstr(inp_win, &line[word_pos], (int)cur_ch_len);
+                    word_pos += cur_ch_len;
+                }
+
+                if (misspelled) {
+                    wattroff(inp_win, theme_attrs(THEME_INPUT_MISSPELLED));
+                }
+
+                i = end - 1;
+                continue;
+            }
+        }
+
+        waddnstr(inp_win, c, (int)ch_len);
     }
 
     wmove(inp_win, 0, col);
@@ -454,11 +505,13 @@ _inp_offset_to_col(char* str, int offset)
     while (i < offset && str[i] != '\0') {
         gunichar uni = g_utf8_get_char(&str[i]);
         size_t ch_len = mbrlen(&str[i], MB_CUR_MAX, NULL);
-        if ((ch_len == (size_t)-2) || (ch_len == (size_t)-1)) {
+        // ch_len == 0 (embedded NUL) would freeze the loop on the same
+        // byte; treat it like an invalid step.
+        if ((ch_len == (size_t)-2) || (ch_len == (size_t)-1) || ch_len == 0) {
             i++;
             continue;
         }
-        i += ch_len;
+        i += (int)ch_len;
         col++;
         if (g_unichar_iswide(uni)) {
             col++;
@@ -1005,6 +1058,16 @@ _inp_rl_down_arrow_handler(int count, int key)
     return 0;
 }
 
+static void
+_editor_finished_cb(gchar* message, void* user_data)
+{
+    if (message) {
+        rl_replace_line(message, 0);
+        rl_point = rl_end;
+        rl_forced_update_display();
+    }
+}
+
 static int
 _inp_rl_send_to_editor(int count, int key)
 {
@@ -1012,9 +1075,7 @@ _inp_rl_send_to_editor(int count, int key)
         return 0;
     }
 
-    auto_gchar gchar* message = NULL;
-
-    get_message_from_editor_async(rl_line_buffer);
+    launch_editor(rl_line_buffer, _editor_finished_cb, NULL);
 
     return 0;
 }