merge: sync upstream profanity-im/profanity

Sync with upstream profanity-im/profanity.

Major upstream changes incorporated:

Memory management
  - Replace malloc+memset with g_new0 throughout codebase
  - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
  - Replace free() with g_free() for GAlloc'd memory

Editor rewrite
  - Remove pthread-based async editor; use GChildWatch callback API
  - New launch_editor(initial_content, callback, user_data) interface
  - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
  - ui_suspend()/ui_resume() integration for TTY management

OMEMO improvements
  - Dual backend support: libsignal-protocol-c and libomemo-c
  - Proper pre-key removal after use (XEP-0384 compliance)
  - Automatic pre-key regeneration when store drops below threshold
  - New functions: omemo_is_device_active(), omemo_is_jid_trusted()
  - omemo_get_jid_untrusted_fingerprints() for better error messages
  - Fingerprint notifications on new device identity discovery
  - Deterministic pre-key ID generation tracking max_pre_key_id
  - omemo_trust_changed() UI updates on trust state changes

JID validation
  - RFC 6122-compliant validation in jid_is_valid()
  - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
  - Length limits: 1023 per component, 3071 total
  - New jid_is_valid_user_jid() for user vs. service JID distinction

Database
  - Schema migration v3: UNIQUE constraint on archive_id for deduplication
  - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
  - db_history_result_t return type, _truncate_datetime_suffix()

UI / console
  - win_warn_needed() / win_warn_sent() warning deduplication hash table
  - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
  - Spellcheck integration in input field with Unicode word detection
  - cons_spellcheck_setting() for /settings ui output
  - /[command]? shortcut for command help

Account config
  - Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
  - Replace popen() with g_spawn_sync() for eval_password
  - TLS policy: add "direct" option alongside legacy

Connection
  - Port validation with g_assert (0–65535)
  - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
  - "direct" TLS policy alias for legacy SSL

Common utilities
  - str_xml_sanitize() for XML 1.0 illegal character removal
  - string_matches_one_of() with formatted error messages
  - valid_tls_policy_option() helper
  - prof_date_time_format_iso8601() utility
  - Improved strip_arg_quotes() with backslash unescaping
  - prof_occurrences() uses g_slist_prepend + reverse for performance

PGP / OX
  - Proper GPGME resource cleanup with goto-cleanup pattern
  - g_string_free(xmppuri) leak fix in _ox_key_lookup

CSV export
  - Use GString + g_file_set_contents instead of raw write() syscalls

Tests
  - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
  - New test_cmd_ac.c for autocompleter unit tests
  - Updated stubs for new UI suspend/resume functions

License headers
  - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)

────────────────────────────────────────────────────
cproof-specific preservations:

  - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
  - Force encryption: cmd_force_encryption, test_forced_encryption
  - CWE-134: format string protection (cons_show("%s", ...))
  - y_start_pos-based paging in window.c
  - db_history_result_t return type, _truncate_datetime_suffix()

Merge-time fixes:

  - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
  - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
  - console.c: implicit size_t → int cast — (int)(maxlen + 1)
  - tlscerts.c: %d for size_t — %zu

Build system:
  - Kept autotools (Makefile.am, configure.ac); upstream uses Meson
  - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
  - Updated Makefile.am test paths for subdirectory structure
  - Added test_cmd_ac, test_forced_encryption to test sources

Functional tests:
  - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
  - Not yet available in devs/stabber fork

Closes #64

Merge author: jabber.developer2
Commits authors:
 Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>

src/ui/statusbar.c

@@ -3,35 +3,9 @@
  * vim: expandtab:ts=4:sts=4:sw=4
  *
  * Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
- * Copyright (C) 2019 - 2025 Michael Vetter <jubalh@iodoru.org>
- *
- * This file is part of Profanity.
- *
- * Profanity is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * Profanity is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with Profanity.  If not, see <https://www.gnu.org/licenses/>.
- *
- * In addition, as a special exception, the copyright holders give permission to
- * link the code of portions of this program with the OpenSSL library under
- * certain conditions as described in each individual source file, and
- * distribute linked combinations including the two.
- *
- * You must obey the GNU General Public License in all respects for all of the
- * code used other than OpenSSL. If you modify file(s) with this exception, you
- * may extend this exception to your version of the file(s), but you are not
- * obligated to do so. If you do not wish to do so, delete this exception
- * statement from your version. If you delete this exception statement from all
- * source files in the program, then also delete it here.
+ * Copyright (C) 2019 - 2026 Michael Vetter <jubalh@iodoru.org>
  *
+ * SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
  */
 
 #include "config.h"
@@ -74,25 +48,27 @@ typedef struct _status_bar_t
     char* prompt;
     char* fulljid;
     GHashTable* tabs;
-    int current_tab;
+    guint current_tab;
 } StatusBar;
 
 static GTimeZone* tz;
 static StatusBar* statusbar;
 static WINDOW* statusbar_win;
 
-void _get_range_bounds(int* start, int* end, gboolean is_static);
-static int _status_bar_draw_time(int pos);
-static int _status_bar_draw_maintext(int pos);
-static int _status_bar_draw_dbbackend(int pos);
-static int _status_bar_draw_bracket(gboolean current, int pos, const char* ch);
-static int _status_bar_draw_extended_tabs(int pos, gboolean prefix, int start, int end, gboolean is_static);
-static int _status_bar_draw_tab(StatusBarTab* tab, int pos, int num, gboolean include_brackets);
-static int _status_bar_draw_tabs(int pos);
+#define CONSOLE_TAB_ID 10 // Console tab ID in status bar hash table
+
+void _get_range_bounds(guint* start, guint* end, gboolean is_static);
+static guint _status_bar_draw_time(guint pos);
+static guint _status_bar_draw_maintext(guint pos);
+static guint _status_bar_draw_dbbackend(guint pos);
+static guint _status_bar_draw_bracket(gboolean current, guint pos, const char* ch);
+static guint _status_bar_draw_extended_tabs(guint pos, gboolean prefix, guint start, guint end, gboolean is_static);
+static guint _status_bar_draw_tab(StatusBarTab* tab, guint pos, guint num, gboolean include_brackets);
+static guint _status_bar_draw_tabs(guint pos);
 static void _destroy_tab(StatusBarTab* tab);
-static int _tabs_width(int start, int end);
-static unsigned int _count_digits(int number);
-static unsigned int _count_digits_in_range(int start, int end);
+static guint _tabs_width(guint start, guint end);
+static guint _count_digits(guint number);
+static guint _count_digits_in_range(guint start, guint end);
 static char* _display_name(StatusBarTab* tab);
 static gboolean _tabmode_is_actlist(void);
 
@@ -101,12 +77,12 @@ status_bar_init(void)
 {
     tz = g_time_zone_new_local();
 
-    statusbar = malloc(sizeof(StatusBar));
+    statusbar = g_new0(StatusBar, 1);
     statusbar->time = NULL;
     statusbar->prompt = NULL;
     statusbar->fulljid = NULL;
     statusbar->tabs = g_hash_table_new_full(g_direct_hash, g_direct_equal, NULL, (GDestroyNotify)_destroy_tab);
-    StatusBarTab* console = calloc(1, sizeof(StatusBarTab));
+    StatusBarTab* console = g_new0(StatusBarTab, 1);
     console->window_type = WIN_CONSOLE;
     console->identifier = strdup("console");
     console->display_name = NULL;
@@ -180,10 +156,10 @@ status_bar_set_all_inactive(void)
 }
 
 void
-status_bar_current(int i)
+status_bar_current(guint i)
 {
     if (i == 0) {
-        statusbar->current_tab = 10;
+        statusbar->current_tab = CONSOLE_TAB_ID;
     } else {
         statusbar->current_tab = i;
     }
@@ -194,12 +170,7 @@ status_bar_current(int i)
 void
 status_bar_inactive(const int win)
 {
-    int true_win = win;
-    if (true_win == 0) {
-        true_win = 10;
-    }
-
-    g_hash_table_remove(statusbar->tabs, GINT_TO_POINTER(true_win));
+    g_hash_table_remove(statusbar->tabs, GINT_TO_POINTER((win == 0) ? CONSOLE_TAB_ID : win));
 
     status_bar_draw();
 }
@@ -207,9 +178,7 @@ status_bar_inactive(const int win)
 void
 _create_tab(const int win, win_type_t wintype, char* identifier, gboolean highlight)
 {
-    int true_win = win == 0 ? 10 : win;
-
-    StatusBarTab* tab = malloc(sizeof(StatusBarTab));
+    StatusBarTab* tab = g_new0(StatusBarTab, 1);
     tab->identifier = strdup(identifier);
     tab->highlight = highlight;
     tab->window_type = wintype;
@@ -238,7 +207,7 @@ _create_tab(const int win, win_type_t wintype, char* identifier, gboolean highli
         }
     }
 
-    g_hash_table_replace(statusbar->tabs, GINT_TO_POINTER(true_win), tab);
+    g_hash_table_replace(statusbar->tabs, GINT_TO_POINTER((win == 0) ? CONSOLE_TAB_ID : win), tab);
 
     status_bar_draw();
 }
@@ -310,8 +279,8 @@ status_bar_draw(void)
     werase(statusbar_win);
     wbkgd(statusbar_win, theme_attrs(THEME_STATUS_TEXT));
 
-    gint max_tabs = prefs_get_statusbartabs();
-    int pos = 1;
+    guint max_tabs = prefs_get_statusbartabs();
+    guint pos = 1;
 
     pos = _status_bar_draw_time(pos);
     pos = _status_bar_draw_maintext(pos);
@@ -323,24 +292,27 @@ status_bar_draw(void)
     inp_put_back();
 }
 
-static int
-_status_bar_draw_tabs(int pos)
+static guint
+_status_bar_draw_tabs(guint pos)
 {
     auto_gchar gchar* tabmode = prefs_get_string(PREF_STATUSBAR_TABMODE);
 
     if (g_strcmp0(tabmode, "actlist") != 0) {
-        int start, end;
+        guint start, end;
         gboolean is_static = g_strcmp0(tabmode, "dynamic") != 0;
         _get_range_bounds(&start, &end, is_static);
 
-        pos = getmaxx(stdscr) - _tabs_width(start, end);
-        if (pos < 0) {
+        guint tabs_w = _tabs_width(start, end);
+        int max_x = getmaxx(stdscr);
+        if (max_x > 0 && (guint)max_x > tabs_w) {
+            pos = (guint)max_x - tabs_w;
+        } else {
             pos = 0;
         }
 
         pos = _status_bar_draw_extended_tabs(pos, TRUE, start, end, is_static);
 
-        for (int i = start; i <= end; i++) {
+        for (guint i = start; i <= end; i++) {
             StatusBarTab* tab = g_hash_table_lookup(statusbar->tabs, GINT_TO_POINTER(i));
             if (tab) {
                 pos = _status_bar_draw_tab(tab, pos, i, TRUE);
@@ -388,9 +360,9 @@ _status_bar_draw_tabs(int pos)
 static gboolean
 _has_new_msgs_beyond_range_on_side(gboolean left_side, int display_tabs_start, int display_tabs_end)
 {
-    gint max_tabs = prefs_get_statusbartabs();
+    guint max_tabs = prefs_get_statusbartabs();
     int tabs_count = g_hash_table_size(statusbar->tabs);
-    if (tabs_count <= max_tabs) {
+    if ((guint)tabs_count <= max_tabs) {
         return FALSE;
     }
 
@@ -407,10 +379,10 @@ _has_new_msgs_beyond_range_on_side(gboolean left_side, int display_tabs_start, i
     return FALSE;
 }
 
-static int
-_status_bar_draw_extended_tabs(int pos, gboolean prefix, int start, int end, gboolean is_static)
+static guint
+_status_bar_draw_extended_tabs(guint pos, gboolean prefix, guint start, guint end, gboolean is_static)
 {
-    gint max_tabs = prefs_get_statusbartabs();
+    guint max_tabs = prefs_get_statusbartabs();
     if (max_tabs == 0) {
         return pos;
     }
@@ -423,7 +395,9 @@ _status_bar_draw_extended_tabs(int pos, gboolean prefix, int start, int end, gbo
     if (prefix && start < 2) {
         return pos;
     }
-    if (!prefix && end > opened_tabs - 1) {
+    // Guard against underflow when opened_tabs == 0 (reachable if the
+    // earlier `opened_tabs <= max_tabs` early-return no longer holds).
+    if (!prefix && end >= opened_tabs) {
         return pos;
     }
     gboolean is_current = is_static && statusbar->current_tab > max_tabs;
@@ -449,8 +423,8 @@ _status_bar_draw_extended_tabs(int pos, gboolean prefix, int start, int end, gbo
     return pos;
 }
 
-static int
-_status_bar_draw_tab(StatusBarTab* tab, int pos, int num, gboolean include_brackets)
+static guint
+_status_bar_draw_tab(StatusBarTab* tab, guint pos, guint num, gboolean include_brackets)
 {
     gboolean is_current = num == statusbar->current_tab;
 
@@ -498,8 +472,8 @@ _status_bar_draw_tab(StatusBarTab* tab, int pos, int num, gboolean include_brack
     return pos;
 }
 
-static int
-_status_bar_draw_bracket(gboolean current, int pos, const char* ch)
+static guint
+_status_bar_draw_bracket(gboolean current, guint pos, const char* ch)
 {
     int bracket_attrs = theme_attrs(THEME_STATUS_BRACKET);
     wattron(statusbar_win, bracket_attrs);
@@ -514,8 +488,8 @@ _status_bar_draw_bracket(gboolean current, int pos, const char* ch)
     return pos;
 }
 
-static int
-_status_bar_draw_time(int pos)
+static guint
+_status_bar_draw_time(guint pos)
 {
     auto_gchar gchar* time_pref = prefs_get_string(PREF_TIME_STATUSBAR);
     if (g_strcmp0(time_pref, "off") == 0) {
@@ -535,7 +509,7 @@ _status_bar_draw_time(int pos)
     int bracket_attrs = theme_attrs(THEME_STATUS_BRACKET);
     int time_attrs = theme_attrs(THEME_STATUS_TIME);
 
-    size_t len = strlen(statusbar->time);
+    guint len = (guint)strlen(statusbar->time);
     wattron(statusbar_win, bracket_attrs);
     mvwaddch(statusbar_win, 0, pos, '[');
     pos++;
@@ -559,8 +533,8 @@ _tabmode_is_actlist(void)
     return g_strcmp0(tabmode, "actlist") == 0;
 }
 
-static int
-_status_bar_draw_maintext(int pos)
+static guint
+_status_bar_draw_maintext(guint pos)
 {
     const char* maintext = NULL;
     auto_jid Jid* jidp = NULL;
@@ -606,8 +580,8 @@ _status_bar_draw_maintext(int pos)
     return pos;
 }
 
-static int
-_status_bar_draw_dbbackend(int pos)
+static guint
+_status_bar_draw_dbbackend(guint pos)
 {
     if (!prefs_get_boolean(PREF_STATUSBAR_SHOW_DBBACKEND))
         return pos;
@@ -633,20 +607,20 @@ _destroy_tab(StatusBarTab* tab)
     }
 }
 
-static int
-_tabs_width(int start, int end)
+static guint
+_tabs_width(guint start, guint end)
 {
     gboolean show_number = prefs_get_boolean(PREF_STATUSBAR_SHOW_NUMBER);
     gboolean show_name = prefs_get_boolean(PREF_STATUSBAR_SHOW_NAME);
     gboolean show_read = prefs_get_boolean(PREF_STATUSBAR_SHOW_READ);
-    gint max_tabs = prefs_get_statusbartabs();
+    guint max_tabs = prefs_get_statusbartabs();
     guint opened_tabs = g_hash_table_size(statusbar->tabs);
 
     int width = start < 2 ? 1 : 4;
-    width += end > opened_tabs - 1 ? 0 : 3;
+    width += (end < opened_tabs) ? 3 : 0;
 
     if (show_name && show_number) {
-        for (int i = start; i <= end; i++) {
+        for (guint i = start; i <= end; i++) {
             StatusBarTab* tab = g_hash_table_lookup(statusbar->tabs, GINT_TO_POINTER(i));
             if (tab) {
                 gboolean is_current = i == statusbar->current_tab;
@@ -663,7 +637,7 @@ _tabs_width(int start, int end)
     }
 
     if (show_name && !show_number) {
-        for (int i = start; i <= end; i++) {
+        for (guint i = start; i <= end; i++) {
             StatusBarTab* tab = g_hash_table_lookup(statusbar->tabs, GINT_TO_POINTER(i));
             if (tab) {
                 gboolean is_current = i == statusbar->current_tab;
@@ -739,7 +713,7 @@ _display_name(StatusBarTab* tab)
 }
 
 void
-_get_range_bounds(int* start, int* end, gboolean is_static)
+_get_range_bounds(guint* start, guint* end, gboolean is_static)
 {
     int current_tab = statusbar->current_tab;
     gint display_range = prefs_get_statusbartabs();
@@ -762,12 +736,10 @@ _get_range_bounds(int* start, int* end, gboolean is_static)
 }
 
 // Counts amount of digits in a number
-static unsigned int
-_count_digits(int number)
+static guint
+_count_digits(guint number)
 {
-    unsigned int digits_count = 0;
-    if (number < 0)
-        number = -number;
+    guint digits_count = 0;
 
     do {
         number /= 10;
@@ -779,12 +751,11 @@ _count_digits(int number)
 
 // Counts the total number of digits in a range of numbers, inclusive.
 // Example: _count_digits_in_range(2, 3) returns 2, _count_digits_in_range(2, 922) returns 2657
-static unsigned int
-_count_digits_in_range(int start, int end)
+static guint
+_count_digits_in_range(guint start, guint end)
 {
-    int total_digits = 0;
-
-    for (int i = start; i <= end; i++) {
+    guint total_digits = 0;
+    for (guint i = start; i <= end; i++) {
         total_digits += _count_digits(i);
     }