merge: sync upstream profanity-im/profanity

Sync with upstream profanity-im/profanity.

Major upstream changes incorporated:

Memory management
  - Replace malloc+memset with g_new0 throughout codebase
  - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
  - Replace free() with g_free() for GAlloc'd memory

Editor rewrite
  - Remove pthread-based async editor; use GChildWatch callback API
  - New launch_editor(initial_content, callback, user_data) interface
  - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
  - ui_suspend()/ui_resume() integration for TTY management

OMEMO improvements
  - Dual backend support: libsignal-protocol-c and libomemo-c
  - Proper pre-key removal after use (XEP-0384 compliance)
  - Automatic pre-key regeneration when store drops below threshold
  - New functions: omemo_is_device_active(), omemo_is_jid_trusted()
  - omemo_get_jid_untrusted_fingerprints() for better error messages
  - Fingerprint notifications on new device identity discovery
  - Deterministic pre-key ID generation tracking max_pre_key_id
  - omemo_trust_changed() UI updates on trust state changes

JID validation
  - RFC 6122-compliant validation in jid_is_valid()
  - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
  - Length limits: 1023 per component, 3071 total
  - New jid_is_valid_user_jid() for user vs. service JID distinction

Database
  - Schema migration v3: UNIQUE constraint on archive_id for deduplication
  - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
  - db_history_result_t return type, _truncate_datetime_suffix()

UI / console
  - win_warn_needed() / win_warn_sent() warning deduplication hash table
  - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
  - Spellcheck integration in input field with Unicode word detection
  - cons_spellcheck_setting() for /settings ui output
  - /[command]? shortcut for command help

Account config
  - Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
  - Replace popen() with g_spawn_sync() for eval_password
  - TLS policy: add "direct" option alongside legacy

Connection
  - Port validation with g_assert (0–65535)
  - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
  - "direct" TLS policy alias for legacy SSL

Common utilities
  - str_xml_sanitize() for XML 1.0 illegal character removal
  - string_matches_one_of() with formatted error messages
  - valid_tls_policy_option() helper
  - prof_date_time_format_iso8601() utility
  - Improved strip_arg_quotes() with backslash unescaping
  - prof_occurrences() uses g_slist_prepend + reverse for performance

PGP / OX
  - Proper GPGME resource cleanup with goto-cleanup pattern
  - g_string_free(xmppuri) leak fix in _ox_key_lookup

CSV export
  - Use GString + g_file_set_contents instead of raw write() syscalls

Tests
  - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
  - New test_cmd_ac.c for autocompleter unit tests
  - Updated stubs for new UI suspend/resume functions

License headers
  - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)

────────────────────────────────────────────────────
cproof-specific preservations:

  - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
  - Force encryption: cmd_force_encryption, test_forced_encryption
  - CWE-134: format string protection (cons_show("%s", ...))
  - y_start_pos-based paging in window.c
  - db_history_result_t return type, _truncate_datetime_suffix()

Merge-time fixes:

  - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
  - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
  - console.c: implicit size_t → int cast — (int)(maxlen + 1)
  - tlscerts.c: %d for size_t — %zu

Build system:
  - Kept autotools (Makefile.am, configure.ac); upstream uses Meson
  - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
  - Updated Makefile.am test paths for subdirectory structure
  - Added test_cmd_ac, test_forced_encryption to test sources

Functional tests:
  - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
  - Not yet available in devs/stabber fork

Closes #64

Merge author: jabber.developer2
Commits authors:
 Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>

src/xmpp/session.c

@@ -4,33 +4,7 @@
  *
  * Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
  *
- * This file is part of Profanity.
- *
- * Profanity is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * Profanity is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with Profanity.  If not, see <https://www.gnu.org/licenses/>.
- *
- * In addition, as a special exception, the copyright holders give permission to
- * link the code of portions of this program with the OpenSSL library under
- * certain conditions as described in each individual source file, and
- * distribute linked combinations including the two.
- *
- * You must obey the GNU General Public License in all respects for all of the
- * code used other than OpenSSL. If you modify file(s) with this exception, you
- * may extend this exception to your version of the file(s), but you are not
- * obligated to do so. If you do not wish to do so, delete this exception
- * statement from your version. If you delete this exception statement from all
- * source files in the program, then also delete it here.
- *
+ * SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
  */
 
 #include "config.h"
@@ -73,7 +47,7 @@ static struct
     char* passwd;
 } saved_account;
 
-static struct
+static struct session_details
 {
     char* name;
     char* jid;
@@ -143,7 +117,7 @@ session_connect_with_account(const ProfAccount* const account)
     auto_char char* jid = NULL;
     if (account->resource) {
         auto_jid Jid* jidp = jid_create_from_bare_and_resource(account->jid, account->resource);
-        jid = strdup(jidp->fulljid);
+        jid = strdup(jid_fulljid_or_barejid(jidp));
     } else {
         jid = strdup(account->jid);
     }
@@ -159,6 +133,18 @@ session_connect_with_account(const ProfAccount* const account)
     return result;
 }
 
+static jabber_conn_status_t
+_session_connect(struct session_details* details)
+{
+    return connection_connect(
+        details->jid,
+        details->passwd,
+        details->altdomain,
+        details->port,
+        details->tls_policy,
+        details->auth_policy);
+}
+
 jabber_conn_status_t
 session_connect_with_details(const char* const jid, const char* const passwd, const char* const altdomain,
                              const int port, const char* const tls_policy, const char* const auth_policy)
@@ -206,13 +192,7 @@ session_connect_with_details(const char* const jid, const char* const passwd, co
     // connect with fulljid
     log_info("Connecting without account, JID: %s", saved_details.jid);
 
-    return connection_connect(
-        saved_details.jid,
-        passwd,
-        saved_details.altdomain,
-        saved_details.port,
-        saved_details.tls_policy,
-        saved_details.auth_policy);
+    return _session_connect(&saved_details);
 }
 
 void
@@ -263,7 +243,7 @@ session_process_events(void)
     case JABBER_DISCONNECTED:
         reconnect_sec = prefs_get_reconnect();
         if ((reconnect_sec != 0) && reconnect_timer) {
-            int elapsed_sec = g_timer_elapsed(reconnect_timer, NULL);
+            int elapsed_sec = (int)g_timer_elapsed(reconnect_timer, NULL);
             if (elapsed_sec > reconnect_sec) {
                 log_debug("[CONNDBG] session_process_events: auto-reconnect triggered after %d seconds (threshold=%d)",
                           elapsed_sec, reconnect_sec);
@@ -426,8 +406,8 @@ session_check_autoaway(void)
     gboolean check = prefs_get_boolean(PREF_AUTOAWAY_CHECK);
     gint away_time = prefs_get_autoaway_time();
     gint xa_time = prefs_get_autoxa_time();
-    int away_time_ms = away_time * 60000;
-    int xa_time_ms = xa_time * 60000;
+    unsigned long away_time_ms = away_time * 60000;
+    unsigned long xa_time_ms = xa_time * 60000;
 
     const char* account = session_get_account_name();
     resource_presence_t curr_presence = accounts_get_last_presence(account);
@@ -457,7 +437,7 @@ session_check_autoaway(void)
                     auto_gchar gchar* message = prefs_get_string(PREF_AUTOAWAY_MESSAGE);
                     connection_set_presence_msg(message);
                     if (prefs_get_boolean(PREF_LASTACTIVITY)) {
-                        cl_ev_presence_send(RESOURCE_AWAY, idle_ms / 1000);
+                        cl_ev_presence_send(RESOURCE_AWAY, (int)(idle_ms / 1000));
                     } else {
                         cl_ev_presence_send(RESOURCE_AWAY, 0);
                     }
@@ -476,7 +456,7 @@ session_check_autoaway(void)
 
                 // send current presence with last activity
                 connection_set_presence_msg(curr_status);
-                cl_ev_presence_send(curr_presence, idle_ms / 1000);
+                cl_ev_presence_send(curr_presence, (int)(idle_ms / 1000));
             }
         }
         break;
@@ -499,7 +479,7 @@ session_check_autoaway(void)
             auto_gchar gchar* message = prefs_get_string(PREF_AUTOXA_MESSAGE);
             connection_set_presence_msg(message);
             if (prefs_get_boolean(PREF_LASTACTIVITY)) {
-                cl_ev_presence_send(RESOURCE_XA, idle_ms / 1000);
+                cl_ev_presence_send(RESOURCE_XA, (int)(idle_ms / 1000));
             } else {
                 cl_ev_presence_send(RESOURCE_XA, 0);
             }
@@ -560,31 +540,36 @@ void
 session_reconnect_now(void)
 {
     // reconnect with account.
-    ProfAccount* account = accounts_get_account(saved_account.name);
-    if (account == NULL) {
-        log_error("Unable to reconnect, account no longer exists: %s", saved_account.name);
-        return;
-    }
+    if (saved_account.name) {
+        ProfAccount* account = accounts_get_account(saved_account.name);
+        if (account == NULL) {
+            log_error("Unable to reconnect, account no longer exists: %s", saved_account.name);
+            return;
+        }
 
-    auto_char char* jid = NULL;
-    if (account->resource) {
-        jid = create_fulljid(account->jid, account->resource);
-    } else {
-        jid = strdup(account->jid);
-    }
-    const char* server;
-    unsigned short port;
-    if (reconnect.altdomain) {
-        server = reconnect.altdomain;
-        port = reconnect.altport;
-    } else {
-        server = account->server;
-        port = account->port;
-    }
+        auto_gchar gchar* jid = NULL;
+        if (account->resource) {
+            jid = create_fulljid(account->jid, account->resource);
+        } else {
+            jid = g_strdup(account->jid);
+        }
+        const char* server;
+        unsigned short port;
+        if (reconnect.altdomain) {
+            server = reconnect.altdomain;
+            port = reconnect.altport;
+        } else {
+            server = account->server;
+            g_assert(account->port >= 0 && account->port <= UINT16_MAX);
+            port = (unsigned short)account->port;
+        }
 
-    log_debug("Attempting reconnect with account %s", account->name);
-    connection_connect(jid, saved_account.passwd, server, port, account->tls_policy, account->auth_policy);
-    account_free(account);
+        log_debug("Attempting reconnect with account %s", account->name);
+        connection_connect(jid, saved_account.passwd, server, port, account->tls_policy, account->auth_policy);
+        account_free(account);
+    } else {
+        _session_connect(&saved_details);
+    }
     if (reconnect_timer)
         g_timer_start(reconnect_timer);
 }