Merge upstream/master into merge/upstream-full

Merge profanity-im/profanity master (373 commits) into cproof fork.

Source changes (manual merge):
- src/command/: cmd_defs, cmd_funcs, cmd_ac — upstream g_new0, auto_gchar,
  launch_editor callback; keep our XEP-0308 LMC, force-encryption, CWE-134
- src/config/: preferences, tlscerts, account — upstream UNIQUE dedup,
  dynamic pad capacity; keep our db_history_result_t, scroll logic
- src/database.*: upstream g_new0 memory mgmt; keep our return types,
  add null-check fix for msg->timestamp
- src/omemo/, src/pgp/: upstream _gpgme_key_get_email, g_new0;
  keep our replace_id in omemo_on_message_send
- src/tools/: editor, http_upload, bookmark_ignore — upstream launch_editor
  callback API
- src/ui/: console, window, chatwin, mucwin, inputwin, buffer —
  upstream win_warn_needed/sent dedup, PAD_MIN_HEIGHT dynamic pads;
  keep our y_start_pos scroll, _truncate_datetime_suffix
- src/xmpp/: message, stanza, presence, roster_list, iq, session —
  upstream connection_get_available_resources; keep our LMC stanza logic
- src/common.c: fix format-security (cons_show)

Build system:
- Makefile.am: updated test paths to subdirectory structure, added
  test_cmd_ac, test_forced_encryption
- Restored autotools files deleted by upstream meson migration:
  bootstrap.sh, autogen.sh, m4/ax_valgrind_check.m4, configure-debug

Tests:
- Unit tests: upstream unittests.c base + our forced_encryption tests
  (482 passed, 0 failed across all 4 configurations)
- Functional tests: kept our version (93 passed, 0 failed)
  upstream version requires stbbr_for_xmlns not yet in our stabber fork
- Updated test stubs: stub_xmpp.c, stub_omemo.c from upstream

Compile fixes:
- src/common.c: cons_show(errmsg) -> cons_show("%s", errmsg)
- src/database.c: null-check before msg->timestamp access
- src/ui/console.c: size_t -> (int) cast for format width
- src/config/tlscerts.c: %d -> %zu for size_t

src/plugins/api.c

@@ -4,33 +4,7 @@
  *
  * Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
  *
- * This file is part of Profanity.
- *
- * Profanity is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * Profanity is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with Profanity.  If not, see <https://www.gnu.org/licenses/>.
- *
- * In addition, as a special exception, the copyright holders give permission to
- * link the code of portions of this program with the OpenSSL library under
- * certain conditions as described in each individual source file, and
- * distribute linked combinations including the two.
- *
- * You must obey the GNU General Public License in all respects for all of the
- * code used other than OpenSSL. If you modify file(s) with this exception, you
- * may extend this exception to your version of the file(s), but you are not
- * obligated to do so. If you do not wish to do so, delete this exception
- * statement from your version. If you delete this exception statement from all
- * source files in the program, then also delete it here.
- *
+ * SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
  */
 
 #include "config.h"
@@ -112,29 +86,29 @@ api_register_command(const char* const plugin_name, const char* command_name, in
                      char** synopsis, const char* description, char* arguments[][2], char** examples,
                      void* callback, void (*callback_exec)(PluginCommand* command, gchar** args), void (*callback_destroy)(void* callback))
 {
-    PluginCommand* command = calloc(1, sizeof(PluginCommand));
-    command->command_name = strdup(command_name);
+    PluginCommand* command = g_new0(PluginCommand, 1);
+    command->command_name = g_strdup(command_name);
     command->min_args = min_args;
     command->max_args = max_args;
     command->callback = callback;
     command->callback_exec = callback_exec;
     command->callback_destroy = callback_destroy;
 
-    CommandHelp* help = calloc(1, sizeof(CommandHelp));
+    CommandHelp* help = g_new0(CommandHelp, 1);
 
     int i;
     for (i = 0; synopsis[i] != NULL; i++) {
-        help->synopsis[i] = strdup(synopsis[i]);
+        help->synopsis[i] = g_strdup(synopsis[i]);
     }
 
-    help->desc = strdup(description);
+    help->desc = g_strdup(description);
     for (i = 0; arguments[i][0] != NULL; i++) {
-        help->args[i][0] = strdup(arguments[i][0]);
-        help->args[i][1] = strdup(arguments[i][1]);
+        help->args[i][0] = g_strdup(arguments[i][0]);
+        help->args[i][1] = g_strdup(arguments[i][1]);
     }
 
     for (i = 0; examples[i] != NULL; i++) {
-        help->examples[i] = strdup(examples[i]);
+        help->examples[i] = g_strdup(examples[i]);
     }
 
     command->help = help;
@@ -146,7 +120,7 @@ void
 api_register_timed(const char* const plugin_name, void* callback, int interval_seconds,
                    void (*callback_exec)(PluginTimedFunction* timed_function), void (*callback_destroy)(void* callback))
 {
-    PluginTimedFunction* timed_function = malloc(sizeof(PluginTimedFunction));
+    PluginTimedFunction* timed_function = g_new0(PluginTimedFunction, 1);
     timed_function->callback = callback;
     timed_function->callback_exec = callback_exec;
     timed_function->callback_destroy = callback_destroy;
@@ -234,7 +208,7 @@ api_get_current_nick(void)
         ProfMucWin* mucwin = (ProfMucWin*)current;
         assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
         const char* const nick = muc_nick(mucwin->roomjid);
-        return nick ? strdup(nick) : NULL;
+        return nick ? g_strdup(nick) : NULL;
     } else {
         return NULL;
     }
@@ -243,7 +217,7 @@ api_get_current_nick(void)
 char*
 api_get_name_from_roster(const char* barejid)
 {
-    return strdup(roster_get_display_name(barejid));
+    return g_strdup(roster_get_display_name(barejid));
 }
 
 char*
@@ -261,14 +235,22 @@ api_get_current_occupants(void)
         assert(mucwin->memcheck == PROFMUCWIN_MEMCHECK);
         GList* occupants_list = muc_roster(mucwin->roomjid);
         char** result = malloc((g_list_length(occupants_list) + 1) * sizeof(char*));
+        if (result == NULL) {
+            g_list_free(occupants_list);
+            return NULL;
+        }
+
         GList* curr = occupants_list;
         int i = 0;
         while (curr) {
             Occupant* occupant = curr->data;
-            result[i++] = strdup(occupant->nick);
+            result[i++] = g_strdup(occupant->nick);
             curr = g_list_next(curr);
         }
         result[i] = NULL;
+
+        g_list_free(occupants_list);
+
         return result;
     } else {
         return NULL;
@@ -291,7 +273,7 @@ api_get_room_nick(const char* barejid)
 {
     const char* const nick = muc_nick(barejid);
 
-    return nick ? strdup(nick) : NULL;
+    return nick ? g_strdup(nick) : NULL;
 }
 
 void
@@ -339,7 +321,7 @@ api_win_create(
         return;
     }
 
-    PluginWindowCallback* window = malloc(sizeof(PluginWindowCallback));
+    PluginWindowCallback* window = g_new0(PluginWindowCallback, 1);
     window->callback = callback;
     window->callback_exec = callback_exec;
     window->callback_destroy = callback_destroy;
@@ -493,7 +475,7 @@ api_incoming_message(const char* const barejid, const char* const resource, cons
 {
     ProfMessage* message = message_init();
     message->from_jid = jid_create_from_bare_and_resource(barejid, resource);
-    message->plain = strdup(plain);
+    message->plain = g_strdup(plain);
 
     sv_ev_incoming_message(message);