devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 10 Actions Packages Projects 1 Releases Wiki Activity

Fix double free in room id handler

Browse Source 
Free is done in destructor now.
Regards https://github.com/profanity-im/profanity/issues/1148
This commit is contained in:
Michael Vetter
2019-07-09 09:47:35 +02:00
parent 7af85d0fe0
commit 89d8fc846e
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/xmpp/iq.c
View File

@@ -2069,8 +2069,6 @@ _room_info_response_id_handler(xmpp_stanza_t *const stanza, void *const userdata
mucwin_room_info_error(mucwin, error_message); mucwin_room_info_error(mucwin, error_message);
free(error_message); free(error_message);
} }
free(cb_data->room);
free(cb_data);
return 0; return 0;
} }
@@ -2136,9 +2134,6 @@ _room_info_response_id_handler(xmpp_stanza_t *const stanza, void *const userdata
g_slist_free_full(identities, (GDestroyNotify)_identity_destroy); g_slist_free_full(identities, (GDestroyNotify)_identity_destroy);
} }
free(cb_data->room);
free(cb_data);
return 0; return 0;
} }
@@ -2448,8 +2443,8 @@ iq_send_stanza(xmpp_stanza_t *const stanza)
xmpp_send_raw_string(conn, "%s", text); xmpp_send_raw_string(conn, "%s", text);
} }
xmpp_free(connection_get_ctx(), text); xmpp_free(connection_get_ctx(), text);
} }
static void static void
_iq_free_room_data(ProfRoomInfoData *roominfo) _iq_free_room_data(ProfRoomInfoData *roominfo)
{ {