From 9e1f9b666e94a531ec9d156b6fe57675dc55b4f8 Mon Sep 17 00:00:00 2001 From: Jabber Developer Date: Thu, 30 Apr 2026 19:14:49 +0000 Subject: [PATCH] fix(ai): fix provider_name leak and const-cast in cmd_ai_start Use auto_gchar temporary for g_strndup result in cmd_ai_start to prevent memory leak. Fix const-cast warning by using a proper non-const temporary variable. --- src/command/cmd_funcs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/command/cmd_funcs.c b/src/command/cmd_funcs.c index 2b0c42b5..2f522ddf 100644 --- a/src/command/cmd_funcs.c +++ b/src/command/cmd_funcs.c @@ -10760,13 +10760,15 @@ cmd_ai_start(ProfWin* window, const char* const command, gchar** args) // /ai start [/] const gchar* provider_model = (g_strv_length(args) >= 2) ? args[1] : NULL; + auto_gchar gchar* owned_provider_name = NULL; const gchar* provider_name = "openai"; const gchar* model = "gpt-4o"; if (provider_model) { const gchar* slash = strchr(provider_model, '/'); if (slash) { - provider_name = g_strndup(provider_model, slash - provider_model); + owned_provider_name = g_strndup(provider_model, slash - provider_model); + provider_name = owned_provider_name; model = slash + 1; } else { // Just a model name, use default provider