devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Add Valgrind to CI

Browse Source 
* Also pass `$*` to `configure` when invoking `ci-build.sh`, so one can
  e.g. run `./ci-build.sh --without-xscreensaver`

Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This commit is contained in:
Steffen Jaeckel
2025-03-07 20:38:18 +01:00
parent c0da36c48d
commit 9fc0326428
19 changed files with 319 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unittests/test_callbacks.c
View File

@@ -12,7 +12,7 @@
void
returns_no_commands(void** state)
{
callbacks_init();
plugins_init();
GList* commands = plugins_get_command_names();
assert_true(commands == NULL);
@@ -21,8 +21,7 @@ returns_no_commands(void** state)
void
returns_commands(void** state)
{
callbacks_init();
plugins_init();
PluginCommand* command1 = calloc(1, sizeof(PluginCommand));
command1->command_name = strdup("command1");
callbacks_add_command("plugin1", command1);

10
tests/unittests/test_cmd_bookmark.c
View File

@@ -196,8 +196,6 @@ cmd_bookmark_add_adds_bookmark_with_jid(void** state)
void
cmd_bookmark_uses_roomjid_in_room(void** state)
{
muc_init();
gchar* args[] = { NULL };
ProfMucWin muc_win;
muc_win.window.type = WIN_MUC;
@@ -221,8 +219,6 @@ cmd_bookmark_uses_roomjid_in_room(void** state)
void
cmd_bookmark_add_uses_roomjid_in_room(void** state)
{
muc_init();
gchar* args[] = { "add", NULL };
ProfMucWin muc_win;
muc_win.window.type = WIN_MUC;
@@ -246,8 +242,6 @@ cmd_bookmark_add_uses_roomjid_in_room(void** state)
void
cmd_bookmark_add_uses_supplied_jid_in_room(void** state)
{
muc_init();
char* jid = "room1@conf.server";
gchar* args[] = { "add", jid, NULL };
ProfMucWin muc_win;
@@ -378,8 +372,6 @@ cmd_bookmark_remove_shows_message_when_no_bookmark(void** state)
void
cmd_bookmark_remove_uses_roomjid_in_room(void** state)
{
muc_init();
gchar* args[] = { "remove", NULL };
ProfMucWin muc_win;
muc_win.window.type = WIN_MUC;
@@ -400,8 +392,6 @@ cmd_bookmark_remove_uses_roomjid_in_room(void** state)
void
cmd_bookmark_remove_uses_supplied_jid_in_room(void** state)
{
muc_init();
char* jid = "room1@conf.server";
gchar* args[] = { "remove", jid, NULL };
ProfMucWin muc_win;

2
tests/unittests/test_cmd_disconnect.c
View File

@@ -23,7 +23,7 @@ clears_chat_sessions(void** state)
chat_session_recipient_active("mike@server.org", "work", FALSE);
will_return(connection_get_status, JABBER_CONNECTED);
will_return(connection_get_barejid, strdup("myjid@myserver.com"));
will_return(connection_get_barejid, "myjid@myserver.com");
expect_any_cons_show();
gboolean result = cmd_disconnect(NULL, CMD_DISCONNECT, NULL);

8
tests/unittests/test_cmd_join.c
View File

@@ -73,8 +73,6 @@ cmd_join_uses_account_mucservice_when_no_service_specified(void** state)
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,
TRUE, NULL, 0, g_strdup("laptop"), NULL, NULL, 0, 0, 0, 0, 0, account_service, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0);
muc_init();
will_return(connection_get_status, JABBER_CONNECTED);
will_return(session_get_account_name, account_name);
@@ -99,8 +97,6 @@ cmd_join_uses_supplied_nick(void** state)
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,
TRUE, NULL, 0, g_strdup("laptop"), NULL, NULL, 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0);
muc_init();
will_return(connection_get_status, JABBER_CONNECTED);
will_return(session_get_account_name, account_name);
@@ -125,8 +121,6 @@ cmd_join_uses_account_nick_when_not_supplied(void** state)
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,
TRUE, NULL, 0, g_strdup("laptop"), NULL, NULL, 0, 0, 0, 0, 0, NULL, account_nick, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0);
muc_init();
will_return(connection_get_status, JABBER_CONNECTED);
will_return(session_get_account_name, account_name);
@@ -154,8 +148,6 @@ cmd_join_uses_password_when_supplied(void** state)
ProfAccount* account = account_new(account_name, g_strdup("user@server.org"), NULL, NULL,
TRUE, NULL, 0, g_strdup("laptop"), NULL, NULL, 0, 0, 0, 0, 0, account_service, account_nick, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0);
muc_init();
will_return(connection_get_status, JABBER_CONNECTED);
will_return(session_get_account_name, account_name);

2
tests/unittests/test_common.c
View File

@@ -543,7 +543,7 @@ prof_occurrences_of_large_message_tests(void** state)
*/
const size_t haystack_sz = 1024;
size_t haystack_cur = 0;
char* haystack = malloc(haystack_sz);
auto_char char* haystack = malloc(haystack_sz);
const char needle[] = "needle ";
while (haystack_sz - haystack_cur > sizeof(needle)) {
memcpy(&haystack[haystack_cur], needle, sizeof(needle));

3
tests/unittests/test_muc.c
View File

@@ -6,6 +6,8 @@
#include "xmpp/muc.h"
void prof_shutdown(void);
int
muc_before_test(void** state)
{
@@ -16,6 +18,7 @@ muc_before_test(void** state)
int
muc_after_test(void** state)
{
prof_shutdown();
return 0;
}

20
tests/unittests/unittests.c
View File

@@ -39,6 +39,8 @@
#include "test_callbacks.h"
#include "test_plugins_disco.h"
#define muc_unit_test(f) cmocka_unit_test_setup_teardown(f, muc_before_test, muc_after_test)
int
main(int argc, char* argv[])
{
@@ -501,11 +503,11 @@ main(int argc, char* argv[])
cmocka_unit_test(cmd_bookmark_list_shows_bookmarks),
cmocka_unit_test(cmd_bookmark_add_shows_message_when_invalid_jid),
cmocka_unit_test(cmd_bookmark_add_adds_bookmark_with_jid),
cmocka_unit_test(cmd_bookmark_uses_roomjid_in_room),
cmocka_unit_test(cmd_bookmark_add_uses_roomjid_in_room),
cmocka_unit_test(cmd_bookmark_add_uses_supplied_jid_in_room),
cmocka_unit_test(cmd_bookmark_remove_uses_roomjid_in_room),
cmocka_unit_test(cmd_bookmark_remove_uses_supplied_jid_in_room),
muc_unit_test(cmd_bookmark_uses_roomjid_in_room),
muc_unit_test(cmd_bookmark_add_uses_roomjid_in_room),
muc_unit_test(cmd_bookmark_add_uses_supplied_jid_in_room),
muc_unit_test(cmd_bookmark_remove_uses_roomjid_in_room),
muc_unit_test(cmd_bookmark_remove_uses_supplied_jid_in_room),
cmocka_unit_test(cmd_bookmark_add_adds_bookmark_with_jid_nick),
cmocka_unit_test(cmd_bookmark_add_adds_bookmark_with_jid_autojoin),
cmocka_unit_test(cmd_bookmark_add_adds_bookmark_with_jid_nick_autojoin),
@@ -576,10 +578,10 @@ main(int argc, char* argv[])
cmocka_unit_test(cmd_join_shows_message_when_connecting),
cmocka_unit_test(cmd_join_shows_message_when_disconnected),
cmocka_unit_test(cmd_join_shows_error_message_when_invalid_room_jid),
cmocka_unit_test(cmd_join_uses_account_mucservice_when_no_service_specified),
cmocka_unit_test(cmd_join_uses_supplied_nick),
cmocka_unit_test(cmd_join_uses_account_nick_when_not_supplied),
cmocka_unit_test(cmd_join_uses_password_when_supplied),
muc_unit_test(cmd_join_uses_account_mucservice_when_no_service_specified),
muc_unit_test(cmd_join_uses_supplied_nick),
muc_unit_test(cmd_join_uses_account_nick_when_not_supplied),
muc_unit_test(cmd_join_uses_password_when_supplied),
cmocka_unit_test(cmd_roster_shows_message_when_disconnecting),
cmocka_unit_test(cmd_roster_shows_message_when_connecting),