devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 9 Actions Packages Projects 1 Releases Wiki Activity

fix(xmpp): treat disco#info result without 'from' as from the server
All checks were successful
CI Code / Check spelling (pull_request) Successful in 14s
Details
CI Code / Check coding style (pull_request) Successful in 24s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 8m29s
Details
CI Code / Linux (debian) (pull_request) Successful in 8m53s
Details
CI Code / Code Coverage (pull_request) Successful in 9m7s
Details
CI Code / Linux (arch) (pull_request) Successful in 12m11s
Details

Browse Source 
RFC 6120 §8.1.2.1: a stanza received over a c2s stream without a 'from'
attribute must be treated as coming from the server itself. The
on-connect disco#info handler passed the absent attribute as NULL into
connection_features_received(), where g_str_hash() dereferenced the NULL
key and crashed (remotely triggerable DoS on connect).

Substitute connection_get_domain() at both disco#info handler
boundaries, and make connection_features_received() and
connection_get_features() NULL-safe as defense in depth. Add a stabber
regression test answering the on-connect disco#info with a from-less
result.

Fixes #168
This commit is contained in:
jabber.developer2
2026-07-21 09:09:49 +03:00
parent 2be16df905
commit a283c4e7b4
5 changed files with 43 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/functionaltests/functionaltests.c
View File

@@ -173,6 +173,7 @@ main(int argc, char* argv[])
PROF_FUNC_TEST(disco_info_without_name),
PROF_FUNC_TEST(disco_items_without_name),
PROF_FUNC_TEST(disco_info_service_unavailable),
PROF_FUNC_TEST(disco_info_result_no_from),
/* Roster management - add/remove/rename contacts */
PROF_FUNC_TEST(sends_new_item),