devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 9 Actions Packages Projects 1 Releases Wiki Activity

fix(ui): guard password/TLS prompt redraw while suspended

Browse Source 
inp_get_line()/inp_get_password() issued an unconditional doupdate()
before their input loop. If such a prompt is raised while an external
editor is active (e.g. a reconnect password or TLS-cert prompt arriving
via session_process_events), that doupdate() writes over the editor.
Guard it with is_suspended || isendwin(), matching the inp_readline()
guard, so it fails safe even if a stray write later clears isendwin().
This closes the one suspended-write path the upstream fix left open.
This commit is contained in:
jabber.developer2
2026-05-27 22:16:51 +03:00
parent 562bd28cff
commit b282b12497
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ui/inputwin.c
View File

@@ -311,7 +311,10 @@ inp_get_line(void)
werase(inp_win); werase(inp_win);
wmove(inp_win, 0, 0); wmove(inp_win, 0, 0);
_inp_win_update_virtual(); _inp_win_update_virtual();
doupdate(); // Don't write to the terminal while suspended (external editor active).
if (!is_suspended && !isendwin()) {
doupdate();
}
char* line = NULL; char* line = NULL;
while (!line) { while (!line) {
line = inp_readline(); line = inp_readline();
@@ -338,7 +341,10 @@ inp_get_password(void)
werase(inp_win); werase(inp_win);
wmove(inp_win, 0, 0); wmove(inp_win, 0, 0);
_inp_win_update_virtual(); _inp_win_update_virtual();
doupdate(); // Don't write to the terminal while suspended (external editor active).
if (!is_suspended && !isendwin()) {
doupdate();
}
char* password = NULL; char* password = NULL;
get_password = TRUE; get_password = TRUE;
while (!password) { while (!password) {