devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Always update UI in event loop, removed updates from rest of code

Browse Source
This commit is contained in:
James Booth
2014-09-01 19:14:52 +01:00
parent c73c4b20ef
commit bc3c4e09a1
9 changed files with 13 additions and 381 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/test_cmd_otr.c
View File

@@ -179,7 +179,6 @@ void cmd_otr_log_redact_shows_warning_when_chlog_disabled(void **state)
void cmd_otr_warn_shows_usage_when_no_args(void **state)
{
mock_cons_show();
stub_ui_current_update_virtual();
CommandHelp *help = malloc(sizeof(CommandHelp));
help->usage = "Some usage";
gchar *args[] = { "warn", NULL };
@@ -195,7 +194,6 @@ void cmd_otr_warn_shows_usage_when_no_args(void **state)
void cmd_otr_warn_shows_usage_when_invalid_arg(void **state)
{
mock_cons_show();
stub_ui_current_update_virtual();
CommandHelp *help = malloc(sizeof(CommandHelp));
help->usage = "Some usage";
gchar *args[] = { "warn", "badarg", NULL };
@@ -211,7 +209,6 @@ void cmd_otr_warn_shows_usage_when_invalid_arg(void **state)
void cmd_otr_warn_on_enables_unencrypted_warning(void **state)
{
mock_cons_show();
stub_ui_current_update_virtual();
CommandHelp *help = malloc(sizeof(CommandHelp));
gchar *args[] = { "warn", "on", NULL };
@@ -230,7 +227,6 @@ void cmd_otr_warn_on_enables_unencrypted_warning(void **state)
void cmd_otr_warn_off_disables_unencrypted_warning(void **state)
{
mock_cons_show();
stub_ui_current_update_virtual();
CommandHelp *help = malloc(sizeof(CommandHelp));
gchar *args[] = { "warn", "off", NULL };

11
tests/ui/mock_ui.c
View File

@@ -132,11 +132,6 @@ void _stub_ui_handle_recipient_not_found(const char * const recipient, const cha
{
}
static
void _stub_ui_current_update_virtual(void)
{
}
static
void _mock_ui_current_print_formatted_line(const char show_char, int attrs, const char * const msg, ...)
{
@@ -271,12 +266,6 @@ stub_ui_handle_recipient_error(void)
ui_handle_recipient_error = _stub_ui_handle_recipient_error;
}
void
stub_ui_current_update_virtual(void)
{
ui_current_update_virtual = _stub_ui_current_update_virtual;
}
void
mock_ui_current_print_formatted_line(void)
{