devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Fix crash on quick /reconnect now usage (double free)

Browse Source 
Check connection state before reconnection.

Fix #1894 https://github.com/profanity-im/profanity/issues/1894
This commit is contained in:
John Hernandez
2023-10-15 23:23:01 +02:00
parent 634cb586d9
commit be42ffcee9
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/event/client_events.c
View File

@@ -98,7 +98,14 @@ cl_ev_disconnect(void)
void
cl_ev_reconnect(void)
{
if (connection_get_status() != JABBER_DISCONNECTED) {
jabber_conn_status_t conn_status = connection_get_status();
if (conn_status == JABBER_CONNECTING) {
cons_show_error("Reconnection aborted: Connection attempt is already in progress");
return;
}
cons_show("Reconnecting now.");
if (conn_status != JABBER_DISCONNECTED && conn_status != JABBER_DISCONNECTING) {
connection_disconnect();
ev_disconnect_cleanup();
// on intentional disconnect reset the counter