devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Merge pull request #1121 from profanity-im/feature/notify-plugin-fail

Browse Source 
Improve plugin load/install failure message
This commit is contained in:
Michael Vetter
2019-06-07 12:17:56 +02:00
committed by GitHub
parent 172436a83f cc697de051
commit bee7846ea0
3 changed files with 31 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/command/cmd_funcs.c
View File

@@ -6912,12 +6912,14 @@ cmd_plugins_load(ProfWin *window, const char *const command, gchar **args)
return TRUE;
}
gboolean res = plugins_load(args[1]);
GString* error_message = g_string_new(NULL);
gboolean res = plugins_load(args[1], error_message);
if (res) {
cons_show("Loaded plugin: %s", args[1]);
} else {
cons_show("Failed to load plugin: %s", args[1]);
cons_show("Failed to load plugin: %s. %s", args[1], error_message->str);
}
g_string_free(error_message, TRUE);
return TRUE;
}
@@ -6954,12 +6956,14 @@ cmd_plugins_reload(ProfWin *window, const char *const command, gchar **args)
return TRUE;
}
gboolean res = plugins_reload(args[1]);
GString* error_message = g_string_new(NULL);
gboolean res = plugins_reload(args[1], error_message);
if (res) {
cons_show("Reloaded plugin: %s", args[1]);
} else {
cons_show("Failed to reload plugin: %s", args[1]);
cons_show("Failed to reload plugin: %s, %s", args[1], error_message);
}
g_string_free(error_message, TRUE);
return TRUE;
}