devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Improve plugin load/install failure message

Browse Source 
In case Python or C plugins are disabled install/load failed silently.
Notify the user that we can't load them because profanity was built
without support for plugins.
This commit is contained in:
Michael Vetter
2019-06-07 11:30:46 +02:00
parent c03f936390
commit cc697de051
3 changed files with 31 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/command/cmd_funcs.c
View File

@@ -6904,12 +6904,14 @@ cmd_plugins_load(ProfWin *window, const char *const command, gchar **args)
return TRUE;
}
gboolean res = plugins_load(args[1]);
GString* error_message = g_string_new(NULL);
gboolean res = plugins_load(args[1], error_message);
if (res) {
cons_show("Loaded plugin: %s", args[1]);
} else {
cons_show("Failed to load plugin: %s", args[1]);
cons_show("Failed to load plugin: %s. %s", args[1], error_message->str);
}
g_string_free(error_message, TRUE);
return TRUE;
}
@@ -6946,12 +6948,14 @@ cmd_plugins_reload(ProfWin *window, const char *const command, gchar **args)
return TRUE;
}
gboolean res = plugins_reload(args[1]);
GString* error_message = g_string_new(NULL);
gboolean res = plugins_reload(args[1], error_message);
if (res) {
cons_show("Reloaded plugin: %s", args[1]);
} else {
cons_show("Failed to reload plugin: %s", args[1]);
cons_show("Failed to reload plugin: %s, %s", args[1], error_message);
}
g_string_free(error_message, TRUE);
return TRUE;
}