docs(ui,window): update comments around buffer handling
Clarify buffer-related behavior and notes in the window module comments; no functional changes.
This commit is contained in:
@@ -750,7 +750,8 @@ win_page_down(ProfWin* window, int scroll_size)
|
|||||||
win_update_virtual(window);
|
win_update_virtual(window);
|
||||||
}
|
}
|
||||||
|
|
||||||
// switch off page if no messages left to read
|
/*switch off page if no messages left to read
|
||||||
|
TODO: update buffer end handling to check meassages just after last entry*/
|
||||||
if (*scroll_state == WIN_SCROLL_REACHED_BOTTOM) {
|
if (*scroll_state == WIN_SCROLL_REACHED_BOTTOM) {
|
||||||
window->layout->paged = 0;
|
window->layout->paged = 0;
|
||||||
window->layout->unread_msg = 0;
|
window->layout->unread_msg = 0;
|
||||||
@@ -1703,22 +1704,11 @@ static void
|
|||||||
_win_printf(ProfWin* window, const char* show_char, int pad_indent, GDateTime* timestamp, int flags, theme_item_t theme_item, const char* const display_from, const char* const from_jid, const char* const message_id, const char* const message, ...)
|
_win_printf(ProfWin* window, const char* show_char, int pad_indent, GDateTime* timestamp, int flags, theme_item_t theme_item, const char* const display_from, const char* const from_jid, const char* const message_id, const char* const message, ...)
|
||||||
{
|
{
|
||||||
|
|
||||||
/* Test code start
|
/* Prevent printing and buffer update when user is viewing message history [SCROLLING]*/
|
||||||
TODO:
|
|
||||||
- TOLERABLE check window->layout->paged handling for reliability (if buffer size is less than window size [SCROLLING] not set)
|
|
||||||
- make a propper condition check for differernt cases
|
|
||||||
- DONE add a user notification in header when new messages arrive while scrolling history
|
|
||||||
- DONE handle SCROLLED state properly in case of incominf messages (currently it is cleared before new message is printed)
|
|
||||||
|
|
||||||
Description: this code prevents printing and buffer when user is viewing message history [SCROLLING]
|
|
||||||
|
|
||||||
#warning "TEST CODE: temporary/test code present in window.c:1709 - remove before release"*/
|
|
||||||
|
|
||||||
if ((window->layout->paged) && wins_is_current(window)) {
|
if ((window->layout->paged) && wins_is_current(window)) {
|
||||||
window->layout->unread_msg++;
|
window->layout->unread_msg++;
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
/* Test code end */
|
|
||||||
|
|
||||||
if (timestamp == NULL) {
|
if (timestamp == NULL) {
|
||||||
timestamp = g_date_time_new_now_local();
|
timestamp = g_date_time_new_now_local();
|
||||||
|
|||||||
Reference in New Issue
Block a user