From d5d5dc5180f60b7ea5980e201a2385e438a10aaa Mon Sep 17 00:00:00 2001 From: Jabber Developer Date: Tue, 24 Jun 2025 15:53:10 +0200 Subject: [PATCH] ref(theme): ensure clean reinitialization and explicitly initialize static vars Improves code robustness by calling _theme_close() in theme_init() when the theme was already initialized, preventing potential memory leaks or inconsistent state. Closes #4 --- src/config/theme.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/config/theme.c b/src/config/theme.c index 81b43368..70b02b2f 100644 --- a/src/config/theme.c +++ b/src/config/theme.c @@ -56,9 +56,9 @@ #include "config/preferences.h" #include "config/color.h" -static GString* theme_loc; -static GKeyFile* theme; -static GHashTable* defaults; +static GString* theme_loc = NULL; +static GKeyFile* theme = NULL; +static GHashTable* defaults = NULL; static void _load_preferences(void); static void _theme_list_dir(const gchar* const dir, GSList** result); @@ -86,6 +86,12 @@ _theme_close(void) void theme_init(const char* const theme_name) { + if (defaults || theme_loc || theme) { + log_warning("theme_init(): Detected non-NULL state (theme=%p, theme_loc=%p, defaults=%p). Cleaning up previous initialization.", + theme, theme_loc, defaults); + _theme_close(); + } + if (!_theme_load_file(theme_name)) { log_error("Loading theme %s failed.", theme_name);