fix: resolve issues with async editor

If we build Profanity without GTK we dont iterate the context so we will
never know when the editor exited. Calling `g_main_context_iteration()`
or finally switching to GMainLoop fixes this.
So far calling `tray_update()` does this for us in GTK builds.
So this went unnoticed.

The editor will inherit ignored signal handlers (SIGINT, SIGTSTP, SIGPIPE)
from us. Neovim uses libuv which seems to check SIGINT on startup to
determine whether the environment is interactive or not.
We now reset these signals to SIG_DFL in the child process before execvp.

Profanity uses readline which still competed for terminal input with the
editor. We only took care about other Profanity UI processes in our
previous commit. This led to misordered characters in the editor.

In my tests with vim everything worked fine and these bugs were
discovered when a user used neovim.

Fixes: https://github.com/profanity-im/profanity/issues/2148
Ref: 36ec2b0ae1
Signed-off-by: Michael Vetter <jubalh@iodoru.org>

This commit is contained in:

Michael Vetter

2026-04-11 23:45:36 +02:00

parent 89fce43c07

commit dd76f9087f

5 changed files with 31 additions and 1 deletions

									
										2

src/profanity.c
									
												View File
												
				@@ -139,6 +139,8 @@ prof_run(gchar* log_level, gchar* account_name, gchar* config_file, gchar* log_f

				        session_process_events();

				        iq_autoping_check();

				        ui_update();

				        while (g_main_context_iteration(NULL, FALSE))

				            ;

				#ifdef HAVE_GTK

				        tray_update();

				#endif

fix: resolve issues with async editor

2 src/profanity.c Unescape Escape View File

2

src/profanity.c

View File