devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

refactor: replace calloc with g_new0 for struct allocations

Browse Source 
Migrate structure allocations from calloc to glibs g_new0 macro to
improve type safety and memory robustness.

* Type Safety: The macro takes the type name directly, ensuring the
  allocated size always matches the pointer type.
* Static Analysis: It guarantees a non-NULL return by aborting on
  failure, which silences -fanalyzer warnings regarding potential NULL
  pointer dereferences.
* Readability: Removes redundant sizeof() calls and is the glib way
This commit is contained in:
Michael Vetter
2026-02-26 16:49:53 +01:00
parent f1d4ed41d6
commit e1fd2a1cf6
13 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/command/cmd_funcs.c
View File

@@ -9229,7 +9229,7 @@ _url_aesgcm_method(ProfWin* window, const char* cmd_template, gchar* url, gchar*
auto_gchar gchar* filename = _prepare_filename(window, url, path);
if (!filename)
return;
AESGCMDownload* download = calloc(1, sizeof(AESGCMDownload));
AESGCMDownload* download = g_new0(AESGCMDownload, 1);
download->id = get_random_string(4);
download->url = strdup(url);
download->filename = strdup(filename);
@@ -9251,7 +9251,7 @@ _download_install_plugin(ProfWin* window, gchar* url, gchar* path)
auto_gchar gchar* filename = _prepare_filename(window, url, path);
if (!filename)
return FALSE;
HTTPDownload* download = calloc(1, sizeof(HTTPDownload));
HTTPDownload* download = g_new0(HTTPDownload, 1);
download->id = get_random_string(4);
download->url = strdup(url);
download->filename = strdup(filename);
@@ -9270,7 +9270,7 @@ _url_http_method(ProfWin* window, const char* cmd_template, gchar* url, gchar* p
auto_gchar gchar* filename = _prepare_filename(window, url, path);
if (!filename)
return;
HTTPDownload* download = calloc(1, sizeof(HTTPDownload));
HTTPDownload* download = g_new0(HTTPDownload, 1);
download->id = get_random_string(4);
download->url = strdup(url);
download->filename = strdup(filename);
@@ -9678,7 +9678,7 @@ cmd_vcard_add(ProfWin* window, const char* const command, gchar** args)
return TRUE;
}
vcard_element_t* element = calloc(1, sizeof(vcard_element_t));
vcard_element_t* element = g_new0(vcard_element_t, 1);
if (!element) {
cons_show_error("Memory allocation failed.");
return TRUE;