devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 9 Actions Packages Projects 1 Releases Wiki Activity

tests: standardize naming convention

Browse Source 
Use a behavior-driven naming convention for unit tests.

Functions are now named using the pattern: [unit]__[verb]__[scenario]
The __ works as a semantic separator.

Examples:
* jid_create__returns__null_from_null()
* cmd_connect__shows__usage_when_no_server_value

Benefits:
* Easy to find all tests associated with a specific function using the
  mandatory prefix.
* Test output in CI now explicitly describes the unit, the expected
  outcome, and the scenario being tested.

Also disabled keyhandlers tests due to missing code in src/ui.
This commit is contained in:
Michael Vetter
2026-02-28 12:41:33 +01:00
parent a7408a970e
commit e81435be06
53 changed files with 1601 additions and 1433 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unittests/command/test_cmd_join.c
View File

@@ -27,25 +27,25 @@ test_with_connection_status(jabber_conn_status_t status)
}
void
cmd_join_shows_message_when_disconnecting(void** state)
cmd_join__shows__message_when_disconnecting(void** state)
{
test_with_connection_status(JABBER_DISCONNECTING);
}
void
cmd_join_shows_message_when_connecting(void** state)
cmd_join__shows__message_when_connecting(void** state)
{
test_with_connection_status(JABBER_CONNECTING);
}
void
cmd_join_shows_message_when_disconnected(void** state)
cmd_join__shows__message_when_disconnected(void** state)
{
test_with_connection_status(JABBER_DISCONNECTED);
}
void
cmd_join_shows_error_message_when_invalid_room_jid(void** state)
cmd_join__shows__error_message_when_invalid_room_jid(void** state)
{
gchar* args[] = { "//@@/", NULL };
@@ -59,7 +59,7 @@ cmd_join_shows_error_message_when_invalid_room_jid(void** state)
}
void
cmd_join_uses_account_mucservice_when_no_service_specified(void** state)
cmd_join__tests__uses_account_mucservice_when_no_service_specified(void** state)
{
gchar* account_name = g_strdup("an_account");
char* room = "room";
@@ -85,7 +85,7 @@ cmd_join_uses_account_mucservice_when_no_service_specified(void** state)
}
void
cmd_join_uses_supplied_nick(void** state)
cmd_join__tests__uses_supplied_nick(void** state)
{
gchar* account_name = g_strdup("an_account");
char* room = "room@conf.server.org";
@@ -109,7 +109,7 @@ cmd_join_uses_supplied_nick(void** state)
}
void
cmd_join_uses_account_nick_when_not_supplied(void** state)
cmd_join__tests__uses_account_nick_when_not_supplied(void** state)
{
gchar* account_name = g_strdup("an_account");
char* room = "room2@conf.server.org";
@@ -133,7 +133,7 @@ cmd_join_uses_account_nick_when_not_supplied(void** state)
}
void
cmd_join_uses_password_when_supplied(void** state)
cmd_join__tests__uses_password_when_supplied(void** state)
{
gchar* account_name = g_strdup("an_account");
char* room = "room";