devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 8 Actions Packages Projects 1 Releases Wiki Activity

tests: standardize naming convention

Browse Source 
Use a behavior-driven naming convention for unit tests.

Functions are now named using the pattern: [unit]__[verb]__[scenario]
The __ works as a semantic separator.

Examples:
* jid_create__returns__null_from_null()
* cmd_connect__shows__usage_when_no_server_value

Benefits:
* Easy to find all tests associated with a specific function using the
  mandatory prefix.
* Test output in CI now explicitly describes the unit, the expected
  outcome, and the scenario being tested.

Also disabled keyhandlers tests due to missing code in src/ui.
This commit is contained in:
Michael Vetter
2026-02-28 12:41:33 +01:00
parent a7408a970e
commit e81435be06
53 changed files with 1601 additions and 1433 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
tests/unittests/xmpp/test_jid.c
View File

@@ -4,21 +4,21 @@
#include "xmpp/jid.h"
void
create_jid_from_null_returns_null(void** state)
jid_create__returns__null_from_null(void** state)
{
Jid* result = jid_create(NULL);
assert_null(result);
}
void
create_jid_from_empty_string_returns_null(void** state)
jid_create__returns__null_from_empty_string(void** state)
{
Jid* result = jid_create("");
assert_null(result);
}
void
create_jid_from_full_returns_full(void** state)
jid_create__returns__full_from_full(void** state)
{
Jid* result = jid_create("myuser@mydomain/laptop");
assert_string_equal("myuser@mydomain/laptop", result->fulljid);
@@ -26,7 +26,7 @@ create_jid_from_full_returns_full(void** state)
}
void
create_jid_from_full_returns_bare(void** state)
jid_create__returns__bare_from_full(void** state)
{
Jid* result = jid_create("myuser@mydomain/laptop");
assert_string_equal("myuser@mydomain", result->barejid);
@@ -34,7 +34,7 @@ create_jid_from_full_returns_bare(void** state)
}
void
create_jid_from_full_returns_resourcepart(void** state)
jid_create__returns__resourcepart_from_full(void** state)
{
Jid* result = jid_create("myuser@mydomain/laptop");
assert_string_equal("laptop", result->resourcepart);
@@ -42,7 +42,7 @@ create_jid_from_full_returns_resourcepart(void** state)
}
void
create_jid_from_full_returns_localpart(void** state)
jid_create__returns__localpart_from_full(void** state)
{
Jid* result = jid_create("myuser@mydomain/laptop");
assert_string_equal("myuser", result->localpart);
@@ -50,7 +50,7 @@ create_jid_from_full_returns_localpart(void** state)
}
void
create_jid_from_full_returns_domainpart(void** state)
jid_create__returns__domainpart_from_full(void** state)
{
Jid* result = jid_create("myuser@mydomain/laptop");
assert_string_equal("mydomain", result->domainpart);
@@ -58,7 +58,7 @@ create_jid_from_full_returns_domainpart(void** state)
}
void
create_jid_from_full_nolocal_returns_full(void** state)
jid_create__returns__full_from_full_nolocal(void** state)
{
Jid* result = jid_create("mydomain/laptop");
assert_string_equal("mydomain/laptop", result->fulljid);
@@ -66,7 +66,7 @@ create_jid_from_full_nolocal_returns_full(void** state)
}
void
create_jid_from_full_nolocal_returns_bare(void** state)
jid_create__returns__bare_from_full_nolocal(void** state)
{
Jid* result = jid_create("mydomain/laptop");
assert_string_equal("mydomain", result->barejid);
@@ -74,7 +74,7 @@ create_jid_from_full_nolocal_returns_bare(void** state)
}
void
create_jid_from_full_nolocal_returns_resourcepart(void** state)
jid_create__returns__resourcepart_from_full_nolocal(void** state)
{
Jid* result = jid_create("mydomain/laptop");
assert_string_equal("laptop", result->resourcepart);
@@ -82,7 +82,7 @@ create_jid_from_full_nolocal_returns_resourcepart(void** state)
}
void
create_jid_from_full_nolocal_returns_domainpart(void** state)
jid_create__returns__domainpart_from_full_nolocal(void** state)
{
Jid* result = jid_create("mydomain/laptop");
assert_string_equal("mydomain", result->domainpart);
@@ -90,7 +90,7 @@ create_jid_from_full_nolocal_returns_domainpart(void** state)
}
void
create_jid_from_full_nolocal_returns_null_localpart(void** state)
jid_create__returns__null_localpart_from_full_nolocal(void** state)
{
Jid* result = jid_create("mydomain/laptop");
assert_null(result->localpart);
@@ -98,7 +98,7 @@ create_jid_from_full_nolocal_returns_null_localpart(void** state)
}
void
create_jid_from_bare_returns_null_full(void** state)
jid_create__returns__null_full_from_bare(void** state)
{
Jid* result = jid_create("myuser@mydomain");
assert_null(result->fulljid);
@@ -106,7 +106,7 @@ create_jid_from_bare_returns_null_full(void** state)
}
void
create_jid_from_bare_returns_null_resource(void** state)
jid_create__returns__null_resource_from_bare(void** state)
{
Jid* result = jid_create("myuser@mydomain");
assert_null(result->resourcepart);
@@ -114,7 +114,7 @@ create_jid_from_bare_returns_null_resource(void** state)
}
void
create_jid_from_bare_returns_bare(void** state)
jid_create__returns__bare_from_bare(void** state)
{
Jid* result = jid_create("myuser@mydomain");
assert_string_equal("myuser@mydomain", result->barejid);
@@ -122,7 +122,7 @@ create_jid_from_bare_returns_bare(void** state)
}
void
create_jid_from_bare_returns_localpart(void** state)
jid_create__returns__localpart_from_bare(void** state)
{
Jid* result = jid_create("myuser@mydomain");
assert_string_equal("myuser", result->localpart);
@@ -130,7 +130,7 @@ create_jid_from_bare_returns_localpart(void** state)
}
void
create_jid_from_bare_returns_domainpart(void** state)
jid_create__returns__domainpart_from_bare(void** state)
{
Jid* result = jid_create("myuser@mydomain");
assert_string_equal("mydomain", result->domainpart);
@@ -138,7 +138,7 @@ create_jid_from_bare_returns_domainpart(void** state)
}
void
create_room_jid_returns_room(void** state)
jid_create_from_bare_and_resource__returns__room(void** state)
{
Jid* result = jid_create_from_bare_and_resource("room@conference.domain.org", "myname");
@@ -147,7 +147,7 @@ create_room_jid_returns_room(void** state)
}
void
create_room_jid_returns_nick(void** state)
jid_create_from_bare_and_resource__returns__nick(void** state)
{
Jid* result = jid_create_from_bare_and_resource("room@conference.domain.org", "myname");
@@ -156,7 +156,7 @@ create_room_jid_returns_nick(void** state)
}
void
create_with_slash_in_resource(void** state)
jid_create__returns__correct_parts_with_slash_in_resource(void** state)
{
Jid* result = jid_create("room@conference.domain.org/my/nick");
@@ -170,7 +170,7 @@ create_with_slash_in_resource(void** state)
}
void
create_with_at_in_resource(void** state)
jid_create__returns__correct_parts_with_at_in_resource(void** state)
{
Jid* result = jid_create("room@conference.domain.org/my@nick");
@@ -184,7 +184,7 @@ create_with_at_in_resource(void** state)
}
void
create_with_at_and_slash_in_resource(void** state)
jid_create__returns__correct_parts_with_at_and_slash_in_resource(void** state)
{
Jid* result = jid_create("room@conference.domain.org/my@nick/something");
@@ -198,7 +198,7 @@ create_with_at_and_slash_in_resource(void** state)
}
void
create_full_with_trailing_slash(void** state)
jid_create__returns__correct_parts_with_trailing_slash(void** state)
{
Jid* result = jid_create("room@conference.domain.org/nick/");
@@ -212,7 +212,7 @@ create_full_with_trailing_slash(void** state)
}
void
returns_fulljid_when_exists(void** state)
jid_fulljid_or_barejid__returns__fulljid_when_exists(void** state)
{
Jid* jid = jid_create("localpart@domainpart/resourcepart");
@@ -224,7 +224,7 @@ returns_fulljid_when_exists(void** state)
}
void
returns_barejid_when_fulljid_not_exists(void** state)
jid_fulljid_or_barejid__returns__barejid_when_fulljid_not_exists(void** state)
{
Jid* jid = jid_create("localpart@domainpart");