devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

fix(ai): unlock mutex before early return in error callback
Some checks failed
CI Code / Check coding style (pull_request) Successful in 36s
Details
CI Code / Check spelling (pull_request) Successful in 20s
Details
CI Code / Code Coverage (pull_request) Failing after 1m9s
Details
CI Code / Linux (debian) (pull_request) Failing after 2m45s
Details
CI Code / Linux (arch) (pull_request) Failing after 3m32s
Details
CI Code / Linux (ubuntu) (pull_request) Failing after 2m53s
Details

Browse Source 
The mutex was not released when the aiwin pointer was invalid, leading to a potential deadlock in the AI thread.
This commit is contained in:
Jabber Developer
2026-05-14 03:52:20 +00:00
parent a9f0153c0f
commit f93f7cdf2c
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/ai/ai_client.c
View File

@@ -110,6 +110,7 @@ _aiwin_display_error(gpointer user_data, const gchar* error_msg)
ProfAiWin* aiwin = _aiwin_validate(user_data); ProfAiWin* aiwin = _aiwin_validate(user_data);
if (!aiwin) { if (!aiwin) {
log_warning("[AI-THREAD] Cannot display error: aiwin is invalid or window was closed (msg: %s)", error_msg); log_warning("[AI-THREAD] Cannot display error: aiwin is invalid or window was closed (msg: %s)", error_msg);
pthread_mutex_unlock(&lock);
return; return;
} }
aiwin_display_error(aiwin, error_msg); aiwin_display_error(aiwin, error_msg);