24 Commits

Author	SHA1	Message	Date
Jabber Developer	72f4f186da	merge: sync upstream profanity-im/profanity ... Sync with upstream profanity-im/profanity. Major upstream changes incorporated: Memory management - Replace malloc+memset with g_new0 throughout codebase - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros - Replace free() with g_free() for GAlloc'd memory Editor rewrite - Remove pthread-based async editor; use GChildWatch callback API - New launch_editor(initial_content, callback, user_data) interface - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child) - ui_suspend()/ui_resume() integration for TTY management OMEMO improvements - Dual backend support: libsignal-protocol-c and libomemo-c - Proper pre-key removal after use (XEP-0384 compliance) - Automatic pre-key regeneration when store drops below threshold - New functions: omemo_is_device_active(), omemo_is_jid_trusted() - omemo_get_jid_untrusted_fingerprints() for better error messages - Fingerprint notifications on new device identity discovery - Deterministic pre-key ID generation tracking max_pre_key_id - omemo_trust_changed() UI updates on trust state changes JID validation - RFC 6122-compliant validation in jid_is_valid() - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @) - Length limits: 1023 per component, 3071 total - New jid_is_valid_user_jid() for user vs. service JID distinction Database - Schema migration v3: UNIQUE constraint on archive_id for deduplication - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id) - db_history_result_t return type, _truncate_datetime_suffix() UI / console - win_warn_needed() / win_warn_sent() warning deduplication hash table - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup - Spellcheck integration in input field with Unicode word detection - cons_spellcheck_setting() for /settings ui output - /[command]? shortcut for command help Account config - Account name sanitization for GKeyFile special chars ([ ] = # \n \r) - Replace popen() with g_spawn_sync() for eval_password - TLS policy: add "direct" option alongside legacy Connection - Port validation with g_assert (0–65535) - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256) - "direct" TLS policy alias for legacy SSL Common utilities - str_xml_sanitize() for XML 1.0 illegal character removal - string_matches_one_of() with formatted error messages - valid_tls_policy_option() helper - prof_date_time_format_iso8601() utility - Improved strip_arg_quotes() with backslash unescaping - prof_occurrences() uses g_slist_prepend + reverse for performance PGP / OX - Proper GPGME resource cleanup with goto-cleanup pattern - g_string_free(xmppuri) leak fix in _ox_key_lookup CSV export - Use GString + g_file_set_contents instead of raw write() syscalls Tests - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/ - New test_cmd_ac.c for autocompleter unit tests - Updated stubs for new UI suspend/resume functions License headers - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception) ──────────────────────────────────────────────────── cproof-specific preservations: - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo - Force encryption: cmd_force_encryption, test_forced_encryption - CWE-134: format string protection (cons_show("%s", ...)) - y_start_pos-based paging in window.c - db_history_result_t return type, _truncate_datetime_suffix() Merge-time fixes: - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg) - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp - console.c: implicit size_t → int cast — (int)(maxlen + 1) - tlscerts.c: %d for size_t — %zu Build system: - Kept autotools (Makefile.am, configure.ac); upstream uses Meson - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug - Updated Makefile.am test paths for subdirectory structure - Added test_cmd_ac, test_forced_encryption to test sources Functional tests: - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber - Not yet available in devs/stabber fork Closes #64 Merge author: jabber.developer2 Commits authors: Michael Vetter <jubalh@iodoru.org> & Steffen Jaeckel <s@jaeckel.eu>	2026-05-26 17:48:14 +00:00
Jabber Developer	3738be4af1	fix: prevent autoping disable on false negative ping support check ... Remove autodisable logic (prefs_set_autoping(0)) and early return in autoping to treat intermittent false negatives from connection_supports(XMPP_FEATURE_PING). Add one-time error display with debug features print for monitoring; warn on first failing check without aborting to maintain functionality while investigating root cause.	2025-10-14 12:42:00 +02:00
Steffen Jaeckel	988d3663d1	Introduce tests/prof_cmocka.h ... As 9f2abc75 accidentally got the ordering of some of the includes wrong, I decided to propose my initial solution again. Additional to that, I've opened a MR against CMocka to solve this on their side, since I believe that the current way this is done is not sustainable [0]. [0] https://gitlab.com/cmocka/cmocka/-/merge_requests/91 Fixes: 9f2abc75 ("Fix tests with gcc15 (uintptr_t)") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> CProof note: our new tests need to also be updated.	2025-09-10 14:11:03 +02:00
Andreas Stieger	1ae78400a4	Fix tests with gcc15 (uintptr_t) ... fixes: error: ‘uintptr_t’ undeclared, defined in header ‘<stdint.h> (cherry picked from commit 9f2abc75ad) Author: Andreas Stieger <Andreas.Stieger@gmx.de>	2025-09-10 13:57:36 +02:00
Steffen Jaeckel	c5a131ee46	Introduce our own shutdown callback mechanism. ... Instead of adding stuff to `_shutdown()`, we can now register a shutdown routine from the respective `init()` function of our modules. This also has the advantage, that we're sure they're called in reverse order from how the initialization happened. I didn't simply use `atexit()` because POSIX says that the number of possible callbacks is limited (min 32) and I was not sure whether we will maybe extend this number at one point. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-07 21:09:16 +01:00
Steffen Jaeckel	e9aaba938b	minor changes ... * fix typo * less code duplication * less `GString` usage * more `auto_gchar` usage * document connecting to servers supporting SASL ANONYMOUS * ignore valgrind output Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-01-18 20:02:46 +01:00
Michael Vetter	87bf85c40b	add chatlog unittest	2022-06-28 20:46:35 +02:00
Michael Vetter	57666bcb77	Remove log_reinit() ... Not needed anymore.	2020-12-11 11:18:24 +01:00
Michael Vetter	a2726b6a7d	Apply coding style	2020-07-07 14:18:57 +02:00
Michael Vetter	a4cadf78fa	Revert "Apply coding style" ... This reverts commit 9b55f2dec0. Sorting the includes creates some problems.	2020-07-07 13:53:30 +02:00
Michael Vetter	9b55f2dec0	Apply coding style ... Regards https://github.com/profanity-im/profanity/issues/1396	2020-07-07 09:43:28 +02:00
Michael Vetter	0942d98c61	Remove chat_log_get_previous() ... We now dont get the log files from the text files via chat_log_get_previous() anymore. We use the sql backend via log_database_get_previous_chat(). So far it just has the same behaviour like chat_log_get_previous(), except that in _chatwin_history() we don't pass the sender to win_print_history() which should be fixed in a commit soon. And log_database_get_previous_chat() can later easily be expanded to fix https://github.com/profanity-im/profanity/issues/205.	2020-04-06 14:42:52 +02:00
Michael Vetter	f055faf31c	Fix log test stub	2020-02-21 21:29:14 +01:00
Michael Vetter	6bfdc5422c	Adjust message stubs in unit tests	2019-10-29 11:55:27 +01:00
Paul Fariello	f831f65737	Rename prof_message_t into ProfMessage	2019-06-20 14:30:45 +02:00
Paul Fariello	44d16e9141	Add prof_message_t to wrap all message attributes ... Probably missing copy of body to plain in carbon and privmessage. Only covers the incoming message path because goal is OMEMO decryption of untrusted message. Cover some of the log functions but not all.	2019-06-20 14:30:42 +02:00
Frank Zschockelt	4683395aca	Use mock_type() for casting mock()	2019-05-08 21:52:16 +02:00
Paul Fariello	daf84ced0c	Add required OMEMO stub for unit-test	2019-04-10 17:23:45 +02:00
Michael Vetter	706af9a900	Update copyright to include 2019	2019-01-22 11:31:45 +01:00
James Booth	b266e4d035	Pass delay timestamp to all incoming chat events	2015-09-08 20:18:31 +01:00
James Booth	dd206ef637	WIP fix for #516, needs memory cleanup	2015-06-29 23:48:41 +01:00
Dmitry Podgorny	e831410669	log: Introduced stderr log handler ... This handler redirects stderr output to a pipe and gathers logs from the read end. The handler is called from main loop, therefore, if a function prints logs to stderr they will be put to log file only after function returns.	2015-06-23 20:52:04 +00:00
James Booth	3d2f999efb	Added PGP logging preferences	2015-06-21 21:42:58 +01:00
James Booth	68ed20f10d	Moved all tests to tests folder	2015-06-12 23:53:30 +01:00