24 Commits

Author	SHA1	Message	Date
Jabber Developer	72f4f186da	merge: sync upstream profanity-im/profanity ... Sync with upstream profanity-im/profanity. Major upstream changes incorporated: Memory management - Replace malloc+memset with g_new0 throughout codebase - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros - Replace free() with g_free() for GAlloc'd memory Editor rewrite - Remove pthread-based async editor; use GChildWatch callback API - New launch_editor(initial_content, callback, user_data) interface - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child) - ui_suspend()/ui_resume() integration for TTY management OMEMO improvements - Dual backend support: libsignal-protocol-c and libomemo-c - Proper pre-key removal after use (XEP-0384 compliance) - Automatic pre-key regeneration when store drops below threshold - New functions: omemo_is_device_active(), omemo_is_jid_trusted() - omemo_get_jid_untrusted_fingerprints() for better error messages - Fingerprint notifications on new device identity discovery - Deterministic pre-key ID generation tracking max_pre_key_id - omemo_trust_changed() UI updates on trust state changes JID validation - RFC 6122-compliant validation in jid_is_valid() - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @) - Length limits: 1023 per component, 3071 total - New jid_is_valid_user_jid() for user vs. service JID distinction Database - Schema migration v3: UNIQUE constraint on archive_id for deduplication - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id) - db_history_result_t return type, _truncate_datetime_suffix() UI / console - win_warn_needed() / win_warn_sent() warning deduplication hash table - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup - Spellcheck integration in input field with Unicode word detection - cons_spellcheck_setting() for /settings ui output - /[command]? shortcut for command help Account config - Account name sanitization for GKeyFile special chars ([ ] = # \n \r) - Replace popen() with g_spawn_sync() for eval_password - TLS policy: add "direct" option alongside legacy Connection - Port validation with g_assert (0–65535) - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256) - "direct" TLS policy alias for legacy SSL Common utilities - str_xml_sanitize() for XML 1.0 illegal character removal - string_matches_one_of() with formatted error messages - valid_tls_policy_option() helper - prof_date_time_format_iso8601() utility - Improved strip_arg_quotes() with backslash unescaping - prof_occurrences() uses g_slist_prepend + reverse for performance PGP / OX - Proper GPGME resource cleanup with goto-cleanup pattern - g_string_free(xmppuri) leak fix in _ox_key_lookup CSV export - Use GString + g_file_set_contents instead of raw write() syscalls Tests - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/ - New test_cmd_ac.c for autocompleter unit tests - Updated stubs for new UI suspend/resume functions License headers - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception) ──────────────────────────────────────────────────── cproof-specific preservations: - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo - Force encryption: cmd_force_encryption, test_forced_encryption - CWE-134: format string protection (cons_show("%s", ...)) - y_start_pos-based paging in window.c - db_history_result_t return type, _truncate_datetime_suffix() Merge-time fixes: - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg) - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp - console.c: implicit size_t → int cast — (int)(maxlen + 1) - tlscerts.c: %d for size_t — %zu Build system: - Kept autotools (Makefile.am, configure.ac); upstream uses Meson - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug - Updated Makefile.am test paths for subdirectory structure - Added test_cmd_ac, test_forced_encryption to test sources Functional tests: - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber - Not yet available in devs/stabber fork Closes #64 Merge author: jabber.developer2 Commits authors: Michael Vetter <jubalh@iodoru.org> & Steffen Jaeckel <s@jaeckel.eu>	2026-05-26 17:48:14 +00:00
Jabber Developer	9ec01fa8cc	fix: CWE-134 format string audit and compiler hardening ... Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-03-07 11:55:50 +01:00
Steffen Jaeckel	988d3663d1	Introduce tests/prof_cmocka.h ... As 9f2abc75 accidentally got the ordering of some of the includes wrong, I decided to propose my initial solution again. Additional to that, I've opened a MR against CMocka to solve this on their side, since I believe that the current way this is done is not sustainable [0]. [0] https://gitlab.com/cmocka/cmocka/-/merge_requests/91 Fixes: 9f2abc75 ("Fix tests with gcc15 (uintptr_t)") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> CProof note: our new tests need to also be updated.	2025-09-10 14:11:03 +02:00
Andreas Stieger	1ae78400a4	Fix tests with gcc15 (uintptr_t) ... fixes: error: ‘uintptr_t’ undeclared, defined in header ‘<stdint.h> (cherry picked from commit 9f2abc75ad) Author: Andreas Stieger <Andreas.Stieger@gmx.de>	2025-09-10 13:57:36 +02:00
Steffen Jaeckel	9fc0326428	Add Valgrind to CI ... * Also pass `$*` to `configure` when invoking `ci-build.sh`, so one can e.g. run `./ci-build.sh --without-xscreensaver` Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-11 12:15:09 +01:00
Steffen Jaeckel	72b99ceb6d	Some minor improvements ... * destroy/free/shutdown/close in reverse order of allocation * more static/auto_Xfree * less variables/strlen/GString * properly `\0`-terminate string of testcase Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>	2025-03-10 11:45:15 +01:00
John Hernandez	7f3fca2bd0	Cleanup: gchar as gchar instead of char ... Use gchar instead of char in most of the cases where gchar is intended. Reason: improve compatibility and stability. Issue #1819 Minor refactoring.	2023-05-04 16:15:09 +02:00
Steffen Jaeckel	2925e85cd6	add test-case for #1761 ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-03-11 15:05:03 +01:00
William Wennerström	867d895469	Add tests for format_call_external_argv	2020-12-07 16:16:15 +01:00
William Wennerström	ac03037847	Rework url to filename	2020-12-06 17:02:09 +01:00
William Wennerström	1d2c0a8836	Move unique_filename_from_url functions to common	2020-12-04 16:13:13 +01:00
Michael Vetter	a2726b6a7d	Apply coding style	2020-07-07 14:18:57 +02:00
Michael Vetter	a4cadf78fa	Revert "Apply coding style" ... This reverts commit 9b55f2dec0. Sorting the includes creates some problems.	2020-07-07 13:53:30 +02:00
Michael Vetter	9b55f2dec0	Apply coding style ... Regards https://github.com/profanity-im/profanity/issues/1396	2020-07-07 09:43:28 +02:00
Dmitry Podgorny	e3f2ca7d10	tests: remove cflag -w and fix warnings ... The flag hides errors. But we want unit tests to be correct in order to reveal errors in the main code. The patch removes tests_unittests_unittests_CFLAGS which makes autotools use AM_CFLAGS instead. Therefore, unit tests are built with flags derived from configure.ac.	2018-10-31 18:35:59 +02:00
Michael Vetter	82f8083b85	Move p_sha1_hash() to stanza.c ... Move `p_sha1_hash()` from `common.c` to `xmpp/stanza.c` as it is only used in this file and now depends on libstrophe so xmpp is a better namespace folder. Renaming it as `_stanza_create_sha1_hash()`. And making static since only used here. The function cannot be tested in the unit tests anymore. Once functional tests are working again we should write a test for the sha1 functionality.	2018-09-06 20:40:09 +02:00
James Booth	6679b890a0	Fix multibyte chars in prof_occurrences ... issue #901	2017-01-26 00:52:13 +00:00
James Booth	6cc4abedc5	Move window functions to window_list.c	2016-07-24 17:02:09 +01:00
James Booth	f243e333fc	Added whole word matches for room mention	2016-04-07 01:01:27 +01:00
James Booth	d9344b00fe	Added prof_strstr function	2016-04-03 22:30:24 +01:00
Michael Vetter	7a0e8f87b5	Remove trailing whitespaces	2015-10-21 15:07:58 +02:00
James Booth	1484e94b35	Fixed OTR decryption check	2015-08-27 00:37:48 +01:00
James Booth	ef52840d91	Added str_contains_str to common	2015-08-26 23:52:40 +01:00
James Booth	68ed20f10d	Moved all tests to tests folder	2015-06-12 23:53:30 +01:00