37 Commits

Author	SHA1	Message	Date
Jabber Developer	72f4f186da	merge: sync upstream profanity-im/profanity ... Sync with upstream profanity-im/profanity. Major upstream changes incorporated: Memory management - Replace malloc+memset with g_new0 throughout codebase - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros - Replace free() with g_free() for GAlloc'd memory Editor rewrite - Remove pthread-based async editor; use GChildWatch callback API - New launch_editor(initial_content, callback, user_data) interface - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child) - ui_suspend()/ui_resume() integration for TTY management OMEMO improvements - Dual backend support: libsignal-protocol-c and libomemo-c - Proper pre-key removal after use (XEP-0384 compliance) - Automatic pre-key regeneration when store drops below threshold - New functions: omemo_is_device_active(), omemo_is_jid_trusted() - omemo_get_jid_untrusted_fingerprints() for better error messages - Fingerprint notifications on new device identity discovery - Deterministic pre-key ID generation tracking max_pre_key_id - omemo_trust_changed() UI updates on trust state changes JID validation - RFC 6122-compliant validation in jid_is_valid() - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @) - Length limits: 1023 per component, 3071 total - New jid_is_valid_user_jid() for user vs. service JID distinction Database - Schema migration v3: UNIQUE constraint on archive_id for deduplication - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id) - db_history_result_t return type, _truncate_datetime_suffix() UI / console - win_warn_needed() / win_warn_sent() warning deduplication hash table - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup - Spellcheck integration in input field with Unicode word detection - cons_spellcheck_setting() for /settings ui output - /[command]? shortcut for command help Account config - Account name sanitization for GKeyFile special chars ([ ] = # \n \r) - Replace popen() with g_spawn_sync() for eval_password - TLS policy: add "direct" option alongside legacy Connection - Port validation with g_assert (0–65535) - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256) - "direct" TLS policy alias for legacy SSL Common utilities - str_xml_sanitize() for XML 1.0 illegal character removal - string_matches_one_of() with formatted error messages - valid_tls_policy_option() helper - prof_date_time_format_iso8601() utility - Improved strip_arg_quotes() with backslash unescaping - prof_occurrences() uses g_slist_prepend + reverse for performance PGP / OX - Proper GPGME resource cleanup with goto-cleanup pattern - g_string_free(xmppuri) leak fix in _ox_key_lookup CSV export - Use GString + g_file_set_contents instead of raw write() syscalls Tests - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/ - New test_cmd_ac.c for autocompleter unit tests - Updated stubs for new UI suspend/resume functions License headers - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception) ──────────────────────────────────────────────────── cproof-specific preservations: - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo - Force encryption: cmd_force_encryption, test_forced_encryption - CWE-134: format string protection (cons_show("%s", ...)) - y_start_pos-based paging in window.c - db_history_result_t return type, _truncate_datetime_suffix() Merge-time fixes: - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg) - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp - console.c: implicit size_t → int cast — (int)(maxlen + 1) - tlscerts.c: %d for size_t — %zu Build system: - Kept autotools (Makefile.am, configure.ac); upstream uses Meson - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug - Updated Makefile.am test paths for subdirectory structure - Added test_cmd_ac, test_forced_encryption to test sources Functional tests: - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber - Not yet available in devs/stabber fork Closes #64 Merge author: jabber.developer2 Commits authors: Michael Vetter <jubalh@iodoru.org> & Steffen Jaeckel <s@jaeckel.eu>	2026-05-26 17:48:14 +00:00
Jabber Developer	9ec01fa8cc	fix: CWE-134 format string audit and compiler hardening ... Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-03-07 11:55:50 +01:00
Michael Vetter	07dfeec816	Release 0.15.0	2025-03-27 20:06:38 +01:00
Michael Vetter	f147a5ca27	Change default download location ... `/url save $someurl` will now download to `~/.local/share/profanity/downloads/from_jid/date/filename` instead of `~/.local/share/profanity/downloads`. Like this the downloaded files should be better ordered. This will only happen for MUC and 1:1 chat windows. Private windows might have only a nick or jid. Lets not distinguish between those two ways. And since the nick option is unreliable to be the same person lets just put them in the general downloads folder. As is done with downloads from all other windows as well. I also had the idea to make this configurable but this suits my needs and time limits right now.	2024-06-20 13:35:14 +02:00
Michael Vetter	569e37f018	Update copyright to 2024	2024-01-22 16:03:48 +01:00
Steffen Jaeckel	ca2df180d8	Introduce a shared implementation for keyfile loading ... Instead of copy&pasting the same code over again, use a common implementation. Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-09-04 09:59:09 +02:00
Michael Vetter	e853c121d9	Fix my email address ... in all files	2023-07-31 16:51:58 +02:00
John Hernandez	09f217d667	Improve documentation	2023-07-13 21:22:42 +02:00
John Hernandez	8304ac86ff	g_free() to auto_gfree, introduce auto_guchar ... Fix 11 potential mem leaks in theme.c	2023-07-13 17:04:59 +02:00
John Hernandez	3a4cd7da48	Cleanup and mem leak fix ... Improve usage of `gchar` and `char` by setting them correctly Increase usage of `auto_gchar` and `auto_char` Fix 2 mem leaks (rosterwin.c, avatar.c)	2023-07-12 17:43:33 +02:00
John Hernandez	00bea804e2	Improve documentation two functions ... Namely `cmd_process_input()` and `files_get_data_path()`. Edited by @jubalh.	2023-07-11 13:26:37 +02:00
John Hernandez	e1d137f4e6	Change char->free to auto_char char for autocleanup ... Replace `gchar` and `g_free` to `auto_gchar` Correct certain `char` functions/variables to `gchar` Related to #1819. Edited by @jubalh.	2023-07-11 13:26:37 +02:00
John Hernandez	7f3fca2bd0	Cleanup: gchar as gchar instead of char ... Use gchar instead of char in most of the cases where gchar is intended. Reason: improve compatibility and stability. Issue #1819 Minor refactoring.	2023-05-04 16:15:09 +02:00
Michael Vetter	3adc399da0	Update copyright year	2023-01-10 10:37:25 +01:00
Michael Vetter	1330ad4e1e	Update copyright year	2022-05-09 15:43:33 +02:00
Steffen Jaeckel	4d71848837	replace GString usage where a simple strdup works ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2022-03-14 13:17:46 +01:00
Steffen Jaeckel	705b6f7806	use g_mkdir_with_parents() instead of home-baked solution ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2022-03-14 13:17:46 +01:00
Steffen Jaeckel	b8e46552bf	add files_file_in_account_data_path() ... As all parts of the code invoking the `files_get_account_data_path()` function did the same afterwards, a function has been added with the same behavior. 1. create path 2. `mkdir` of that path 3. return final path Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2022-03-13 14:15:02 +01:00
Michael Vetter	f21595597f	Format code correctly	2021-10-05 10:01:27 +02:00
Michael Vetter	a8990014e2	Use whole path as logfile when defined via -f ... `profanity -f my` created ~/.local/share/profanity/logs/my.log`. It would be nicer if one could define the actual path, so one can choose another directory or even use /dev/null. Fixes https://github.com/profanity-im/profanity/issues/1442	2020-12-11 10:40:10 +01:00
Michael Vetter	a2726b6a7d	Apply coding style	2020-07-07 14:18:57 +02:00
Michael Vetter	a4cadf78fa	Revert "Apply coding style" ... This reverts commit 9b55f2dec0. Sorting the includes creates some problems.	2020-07-07 13:53:30 +02:00
Michael Vetter	9b55f2dec0	Apply coding style ... Regards https://github.com/profanity-im/profanity/issues/1396	2020-07-07 09:43:28 +02:00
Michael Vetter	9b514ad3d6	files.c: use const char *const where appropriate	2020-07-01 10:07:42 +02:00
Michael Vetter	1224aa414e	Use files_get_account_data_path instead of duplicate code ... We often had a use case where we want the account specific data dir. Let's create a function for this instead of doing it by hand each time.	2020-07-01 10:05:45 +02:00
Michael Vetter	74e061165a	Define POSIX macro to have strdup ... 98c38dc6d6 sets C99 as standard. strdup() is not part of C99. For now set `-D_POSIX_C_SOURCE=200809L` macro to have strdup() in C99. Using `gnu99` instead would be another option. We should take more care to use glib functions whenever possible. Regards https://github.com/profanity-im/profanity/issues/1357	2020-06-12 16:12:21 +02:00
Michael Vetter	f1141932fc	Dont manipulate pointer from getenv ... Found this when looking to fix bug https://github.com/profanity-im/profanity/issues/1357 Not sure if it is related. man 3 getenv sais: ``` As typically implemented, getenv() returns a pointer to a string within the environment list. The caller must take care not to modify this string, since that would change the environment of the process. ```	2020-06-12 10:23:31 +02:00
Michael Vetter	11663625cc	db: Have one database per account	2020-04-06 10:50:20 +02:00
Michael Vetter	a7163b24f3	database: Define chatlog database location	2020-04-06 10:50:20 +02:00
Michael Vetter	75cfe38808	Allow setting custom log file via -f FILENAME ... `profanity -f TEST` will use `~/.local/share/profanity/logs/TEST.log` as the log file.	2020-02-21 21:10:00 +01:00
Michael Vetter	46fd7150e5	Add vim modeline	2019-11-13 12:11:05 +01:00
Michael Vetter	706af9a900	Update copyright to include 2019	2019-01-22 11:31:45 +01:00
James Booth	250e972b7a	Update copyright	2018-01-21 15:00:02 +00:00
James Booth	68a3daedb9	Update Copyright	2017-01-28 17:24:22 +00:00
James Booth	a3a73cf003	Move all filepath handling to files.c	2016-07-24 21:49:35 +01:00
James Booth	29452f8f1b	Move xgd functions	2016-07-24 17:12:09 +01:00
James Booth	ef942bd27a	Add config/files.c	2016-07-24 16:22:15 +01:00