devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity
7,577 Commits 62 Branches 0 Tags
4dcaa839fa4fd378b501baf36cc38d322ec00bb8
Commit Graph

149 Commits

Author SHA1 Message Date
aryansri05
cff26a97af Fix OTR whitespace tag detection to prevent false positives 
The previous implementation used strstr() which would match OTR tag patterns anywhere in the message. This caused normal messages containing these patterns to incorrectly trigger OTR session initialization.

Changed to use strncmp() to verify that V1/V2 tags immediately follow the base tag, ensuring only legitimate OTR whitespace tags trigger session establishment.

Fixes #1957
 2025-11-03 22:02:14 +01:00
Steffen Jaeckel
95c2199ca2 Some more memory improvements 
* Less leaks
* Less allocations

Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
 2025-03-12 10:09:41 +01:00
Steffen Jaeckel
b55bf6e4bd Fix some more memory leaks + an invalid read. 
`ProfMessage` was not completely initialized, fix this by using `calloc()`
for the allocation.

Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
 2025-03-10 11:45:15 +01:00
Steffen Jaeckel
c5a131ee46 Introduce our own shutdown callback mechanism. 
Instead of adding stuff to `_shutdown()`, we can now register a shutdown
routine from the respective `init()` function of our modules.

This also has the advantage, that we're sure they're called in reverse
order from how the initialization happened.

I didn't simply use `atexit()` because POSIX says that the number of
possible callbacks is limited (min 32) and I was not sure whether
we will maybe extend this number at one point.

Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
 2025-03-07 21:09:16 +01:00
Steffen Jaeckel
2696989ce5 Fix a bunch of obvious memory leaks at termination 
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
 2025-01-28 16:43:13 +01:00
Steffen Jaeckel
848acdd1fa Improve const correctness 
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
 2024-06-19 16:01:46 +02:00
John Hernandez
8304ac86ff g_free() to auto_gfree, introduce auto_guchar 
Fix 11 potential mem leaks in theme.c
 2023-07-13 17:04:59 +02:00
John Hernandez
e1d137f4e6 Change char->free to auto_char char for autocleanup 
Replace `gchar` and `g_free` to `auto_gchar`
Correct certain  `char` functions/variables to `gchar`

Related to #1819.

Edited by @jubalh.
 2023-07-11 13:26:37 +02:00
John Hernandez
4a70f5f513 Cleanup char* to auto_gchar gchar* for prefs_get_string 
Necessity explained in #1819
 2023-07-03 16:06:27 +02:00
Martin Dosch
e1ffc64a65 User proper ellipsis char 
As stated in
https://github.com/profanity-im/profanity/pull/1820#issuecomment-1498083383
profanity uses "..." (three dots) in a lot of places instead the proper
ellipsis char "…".
 2023-04-09 12:19:18 +02:00
John Hernandez
99c9f150f6 Fix PGP 
Fix of PGP and potentially other encryption methods by calling correct function that would initiate them in case if someone writes.
 2023-03-31 12:30:51 +02:00
Michael Vetter
e59c401c84 Adapt to g_string_free glib 2.75.3 change 
glib 2.75.3 changes warning behaviour of `g_string_free()`.
See:
* https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219
* https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226

Use this opportunity to replace the use of GString with
`g_strdup_printf()` where possible.
Otherwise correctly take the return value of `g_string_free()`
which is nicer anyways.
 2023-03-21 10:53:10 +01:00
Michael Vetter
585f68f4f7 Split log.c into log.c and chatlog.c 2022-06-28 20:08:38 +02:00
Steffen Jaeckel
b8e46552bf add files_file_in_account_data_path() 
As all parts of the code invoking the `files_get_account_data_path()`
function did the same afterwards, a function has been added with the same
behavior.

1. create path
2. `mkdir` of that path
3. return final path

Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
 2022-03-13 14:15:02 +01:00
Michael Vetter
33106ecf9c build: remove otr3 support 
All the distributions I checked have libotr 4.1.1 now.
 2022-02-18 14:01:28 +01:00
Steffen Jaeckel
9cf78e59d5 auto-format 
Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
 2022-02-01 15:01:28 +01:00
Michael Vetter
057c9ad776 Add config.h in files were it was missing 
Related to https://github.com/profanity-im/profanity/issues/1512
 2021-03-26 19:54:22 +01:00
Michael Vetter
a2726b6a7d Apply coding style 2020-07-07 14:18:57 +02:00
Michael Vetter
a4cadf78fa Revert "Apply coding style" 
This reverts commit 9b55f2dec0.

Sorting the includes creates some problems.
 2020-07-07 13:53:30 +02:00
Michael Vetter
9b55f2dec0 Apply coding style 
Regards https://github.com/profanity-im/profanity/issues/1396
 2020-07-07 09:43:28 +02:00
Michael Vetter
e5ac12afa6 Remove prefs_free_string() 
It just does a free.
Related to b580b9ef11
 2020-07-02 11:34:12 +02:00
Michael Vetter
a92942a4b7 otr.c: Simplify freeing 
free(NULL) is a noop.
 2020-07-01 17:09:03 +02:00
Michael Vetter
b96e25d9c3 Fix overlooking variable 
Fix mistake where I overlooked some variables in 1224aa414e.
 2020-07-01 17:07:42 +02:00
Michael Vetter
1224aa414e Use files_get_account_data_path instead of duplicate code 
We often had a use case where we want the account specific data dir.
Let's create a function for this instead of doing it by hand each time.
 2020-07-01 10:05:45 +02:00
Michael Vetter
a0a4fd0426 db: log all incoming and outgoing messages 2020-04-06 10:50:20 +02:00
Michael Vetter
a4b53550ca Rename PROF_MSG_ENC_PLAIN to PROF_MSG_ENC_NONE 2020-04-06 10:50:20 +02:00
Michael Vetter
1f8b1eb740 Allow utf8 symbols as omemo/pgp/otr indicator char 
Fix https://github.com/profanity-im/profanity/issues/1264
 2020-02-20 23:36:10 +01:00
Michael Vetter
11b6e1bfa0 xep-0308: enable corrections for outgoing encrypted messages 2020-02-12 08:54:12 +01:00
Michael Vetter
b6b7dd5ad4 xep-0308: update the UI upon sending a corrected message 
So far we don't do this for encrypted messages. Still needs to be done.
And MUC also needs to be done.
 2020-02-11 15:26:58 +01:00
Michael Vetter
46fd7150e5 Add vim modeline 2019-11-13 12:11:05 +01:00
Michael Vetter
8c8c18c6fd Actually log MUC PM messages 
If I'm not mistaken MUC PMs have not been logged at all if there was no
other client sending carbons.
This should add MUC PM logging functionality.

We still need to make sure carbons log to the same file.

Regards https://github.com/profanity-im/profanity/issues/1214
 2019-10-28 23:36:42 +01:00
Michael Vetter
bb08c7270d Make sure result is always set for otr_get_policy() 2019-07-23 08:03:39 +02:00
Paul Fariello
44d16e9141 Add prof_message_t to wrap all message attributes 
Probably missing copy of body to plain in carbon and privmessage.
Only covers the incoming message path because goal is OMEMO decryption
of untrusted message.
Cover some of the log functions but not all.
 2019-06-20 14:30:42 +02:00
Michael Vetter
706af9a900 Update copyright to include 2019 2019-01-22 11:31:45 +01:00
James Booth
250e972b7a Update copyright 2018-01-21 15:00:02 +00:00
James Booth
68a3daedb9 Update Copyright 2017-01-28 17:24:22 +00:00
James Booth
8f1d3ab55c Add win_print 2016-10-15 18:29:02 +01:00
James Booth
9d075c9805 Remove ui_win_error_line 2016-10-15 17:07:15 +01:00
Jack Henschel
4b2f9448f7 Correct minor spelling errors 2016-09-27 16:20:37 +02:00
James Booth
a978bb12bf Send receipt request only when receiver supports feature 
issue #829
 2016-08-18 22:53:23 +01:00
James Booth
a3a73cf003 Move all filepath handling to files.c 2016-07-24 21:49:35 +01:00
James Booth
29452f8f1b Move xgd functions 2016-07-24 17:12:09 +01:00
James Booth
ef942bd27a Add config/files.c 2016-07-24 16:22:15 +01:00
James Booth
0a57c4de78 Tidy headers 2016-07-24 15:43:51 +01:00
James Booth
5bc38b6bc2 Moved window_list.c 2016-07-24 15:14:46 +01:00
James Booth
90b9b48ab9 Moved roster_list.c 2016-07-24 15:08:47 +01:00
James Booth
c23506f453 Moved contact.c 2016-07-24 14:55:32 +01:00
James Booth
9cff37352a Make header defines consistent 2016-07-24 14:51:39 +01:00
James Booth
25a6252a28 Moved chat_session.c 2016-07-24 14:23:55 +01:00
James Booth
e8fc80f5c1 Update GPL link in headers 2016-07-24 01:14:49 +01:00