59 Commits

Author	SHA1	Message	Date
Michael Vetter	562bd28cff	fix(ui): guard terminal writes while suspended ... We forgot to guard `beep()` and `flush()`. Ref: 36ec2b0ae1 Ref: dd76f9087f Signed-off-by: Michael Vetter <jubalh@iodoru.org> Fixes: https://github.com/profanity-im/profanity/issues/2162 (cherry picked from commit 5e4b5d313a9e055e039e2feb4efae58b6aaead78)	2026-05-27 21:59:27 +03:00
Jabber Developer	72f4f186da	merge: sync upstream profanity-im/profanity ... Sync with upstream profanity-im/profanity. Major upstream changes incorporated: Memory management - Replace malloc+memset with g_new0 throughout codebase - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros - Replace free() with g_free() for GAlloc'd memory Editor rewrite - Remove pthread-based async editor; use GChildWatch callback API - New launch_editor(initial_content, callback, user_data) interface - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child) - ui_suspend()/ui_resume() integration for TTY management OMEMO improvements - Dual backend support: libsignal-protocol-c and libomemo-c - Proper pre-key removal after use (XEP-0384 compliance) - Automatic pre-key regeneration when store drops below threshold - New functions: omemo_is_device_active(), omemo_is_jid_trusted() - omemo_get_jid_untrusted_fingerprints() for better error messages - Fingerprint notifications on new device identity discovery - Deterministic pre-key ID generation tracking max_pre_key_id - omemo_trust_changed() UI updates on trust state changes JID validation - RFC 6122-compliant validation in jid_is_valid() - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @) - Length limits: 1023 per component, 3071 total - New jid_is_valid_user_jid() for user vs. service JID distinction Database - Schema migration v3: UNIQUE constraint on archive_id for deduplication - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id) - db_history_result_t return type, _truncate_datetime_suffix() UI / console - win_warn_needed() / win_warn_sent() warning deduplication hash table - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup - Spellcheck integration in input field with Unicode word detection - cons_spellcheck_setting() for /settings ui output - /[command]? shortcut for command help Account config - Account name sanitization for GKeyFile special chars ([ ] = # \n \r) - Replace popen() with g_spawn_sync() for eval_password - TLS policy: add "direct" option alongside legacy Connection - Port validation with g_assert (0–65535) - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256) - "direct" TLS policy alias for legacy SSL Common utilities - str_xml_sanitize() for XML 1.0 illegal character removal - string_matches_one_of() with formatted error messages - valid_tls_policy_option() helper - prof_date_time_format_iso8601() utility - Improved strip_arg_quotes() with backslash unescaping - prof_occurrences() uses g_slist_prepend + reverse for performance PGP / OX - Proper GPGME resource cleanup with goto-cleanup pattern - g_string_free(xmppuri) leak fix in _ox_key_lookup CSV export - Use GString + g_file_set_contents instead of raw write() syscalls Tests - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/ - New test_cmd_ac.c for autocompleter unit tests - Updated stubs for new UI suspend/resume functions License headers - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception) ──────────────────────────────────────────────────── cproof-specific preservations: - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo - Force encryption: cmd_force_encryption, test_forced_encryption - CWE-134: format string protection (cons_show("%s", ...)) - y_start_pos-based paging in window.c - db_history_result_t return type, _truncate_datetime_suffix() Merge-time fixes: - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg) - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp - console.c: implicit size_t → int cast — (int)(maxlen + 1) - tlscerts.c: %d for size_t — %zu Build system: - Kept autotools (Makefile.am, configure.ac); upstream uses Meson - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug - Updated Makefile.am test paths for subdirectory structure - Added test_cmd_ac, test_forced_encryption to test sources Functional tests: - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber - Not yet available in devs/stabber fork Closes #64 Merge author: jabber.developer2 Commits authors: Michael Vetter <jubalh@iodoru.org> & Steffen Jaeckel <s@jaeckel.eu>	2026-05-26 17:48:14 +00:00
Jabber Developer	9ec01fa8cc	fix: CWE-134 format string audit and compiler hardening ... Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-03-07 11:55:50 +01:00
Steffen Jaeckel	5657aac33d	Fix some more char* -> gchar*. ... Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>	2023-08-31 23:14:02 +02:00
John Hernandez	029f1caa52	Cleanup jid_destroy to auto_jid ... Remove unused variables Apply minor cleanups	2023-07-13 17:05:07 +02:00
Michael Vetter	e59c401c84	Adapt to g_string_free glib 2.75.3 change ... glib 2.75.3 changes warning behaviour of `g_string_free()`. See: * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3219 * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3226 Use this opportunity to replace the use of GString with `g_strdup_printf()` where possible. Otherwise correctly take the return value of `g_string_free()` which is nicer anyways.	2023-03-21 10:53:10 +01:00
MarcoPolo-PasTonMolo	6d266984a4	Fix quote and url autocompletion for MAM and history ... After adding MAM quote and url autocompletion wouldn't pick up messages from MAM or history(from DB) or would have them in the wrong order. This commit fixes that. Fixes https://github.com/profanity-im/profanity/issues/1770	2023-02-13 23:40:58 +02:00
Michael Vetter	c8b2979dcd	Exit *_incoming_msg functions when plain message is empty ... Fix https://github.com/profanity-im/profanity/issues/1733	2022-07-04 16:58:16 +02:00
MarcoPolo-PasTonMolo	06ef6842e8	Add quote autocompletion for previous messages ... Fixes https://github.com/profanity-im/profanity/issues/1649 Type `>` then press tab or shift tab to autocomplete previous messages, then type your reply and send message. Newlines are replaced with newline followed by `> `. A newline is added at the end so that the user can immediately type a message without manually adding a new line.	2022-03-21 13:46:50 +02:00
Michael Vetter	057c9ad776	Add config.h in files were it was missing ... Related to https://github.com/profanity-im/profanity/issues/1512	2021-03-26 19:54:22 +01:00
Michael Vetter	7b49fbdf45	Pass window to functions so we dont have to call twice	2020-07-09 16:11:50 +02:00
Michael Vetter	a2726b6a7d	Apply coding style	2020-07-07 14:18:57 +02:00
Michael Vetter	a4cadf78fa	Revert "Apply coding style" ... This reverts commit 9b55f2dec0. Sorting the includes creates some problems.	2020-07-07 13:53:30 +02:00
Michael Vetter	9b55f2dec0	Apply coding style ... Regards https://github.com/profanity-im/profanity/issues/1396	2020-07-07 09:43:28 +02:00
Michael Vetter	ce32d874e0	Build URL ac upon printing of message in window	2020-05-20 10:54:54 +02:00
Michael Vetter	1f8b1eb740	Allow utf8 symbols as omemo/pgp/otr indicator char ... Fix https://github.com/profanity-im/profanity/issues/1264	2020-02-20 23:36:10 +01:00
Michael Vetter	69d474b3a7	Refactor win_print_outgoing() ... We never use the printf like behaviour anyways.	2020-02-17 11:48:50 +01:00
Michael Vetter	50271493b7	xep-0308: remove replace_id from privwin signature ... No `/correct` allowed in privwins	2020-02-14 10:17:07 +01:00
Michael Vetter	b6b7dd5ad4	xep-0308: update the UI upon sending a corrected message ... So far we don't do this for encrypted messages. Still needs to be done. And MUC also needs to be done.	2020-02-11 15:26:58 +01:00
Michael Vetter	3036834ec8	separator: Enable for MUC and PRIVWIN too ... Fix https://github.com/profanity-im/profanity/issues/1238	2019-12-13 13:13:02 +01:00
Michael Vetter	46fd7150e5	Add vim modeline	2019-11-13 12:11:05 +01:00
Paul Fariello	f831f65737	Rename prof_message_t into ProfMessage	2019-06-20 14:30:45 +02:00
Paul Fariello	44d16e9141	Add prof_message_t to wrap all message attributes ... Probably missing copy of body to plain in carbon and privmessage. Only covers the incoming message path because goal is OMEMO decryption of untrusted message. Cover some of the log functions but not all.	2019-06-20 14:30:42 +02:00
Michael Vetter	706af9a900	Update copyright to include 2019	2019-01-22 11:31:45 +01:00
James Booth	59382984c0	Add preferences for tab display	2018-03-09 21:15:27 +00:00
James Booth	119c5650cf	Show name in statusbar tabs WIP	2018-03-08 20:01:36 +00:00
James Booth	250e972b7a	Update copyright	2018-01-21 15:00:02 +00:00
James Booth	68a3daedb9	Update Copyright	2017-01-28 17:24:22 +00:00
James Booth	80309462ca	Rename win_print_incoming_message -> win_print_incoming	2016-10-15 20:09:14 +01:00
James Booth	3b2ceee89b	Add win_print_outgoing	2016-10-15 20:07:33 +01:00
James Booth	8f1d3ab55c	Add win_print	2016-10-15 18:29:02 +01:00
James Booth	8cf9e0cccc	Use win_printf_line where appropriate	2016-10-15 16:31:54 +01:00
James Booth	33b4b79f2e	Add ch arg to win_printf_line	2016-10-15 00:04:57 +01:00
James Booth	54cf1dbec4	Add win_printf_line	2016-10-14 23:38:39 +01:00
James Booth	24f0dc2734	Always use string format in win_printf	2016-10-12 00:40:41 +01:00
James Booth	0890179fc4	Remove win_print, use win_printf instead	2016-10-11 23:38:59 +01:00
James Booth	0337c5b22c	Rename win_vprint -> win_printf	2016-10-11 23:10:48 +01:00
James Booth	0a57c4de78	Tidy headers	2016-07-24 15:43:51 +01:00
James Booth	e8fc80f5c1	Update GPL link in headers	2016-07-24 01:14:49 +01:00
James Booth	e53e94f1e2	Updated copyright	2016-02-14 22:54:46 +00:00
James Booth	6702bb9739	Don't show notification reminders for messages the user does not want notifications for	2016-02-04 01:24:37 +00:00
James Booth	c14ef33906	Tidy notify_message()	2016-02-04 00:41:53 +00:00
James Booth	8342265607	Removed unused arg: prefs_do_chat_notify()	2016-02-04 00:21:38 +00:00
James Booth	bab75cae15	Implemented /console private setting	2016-02-03 23:39:20 +00:00
James Booth	77e819e81a	Handle self leaving room in private wins	2016-02-03 00:11:38 +00:00
James Booth	3ddef99dfe	Handle occupant kicked/banned in private chat wins	2016-02-02 22:25:55 +00:00
James Booth	150015fa3d	Show message in private windows when user offline	2016-02-02 21:52:13 +00:00
James Booth	d9f5a2bda6	Updated console new message text	2015-12-20 23:26:05 +00:00
James Booth	d9435d3b65	Tidy wins_create_summary()	2015-11-29 23:58:52 +00:00
James Booth	3fbee4023e	Renamed /notify message -> /notify chat	2015-11-29 00:08:49 +00:00