devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 9 Actions Packages Projects 1 Releases Wiki Activity
5,556 Commits 65 Branches 0 Tags
fd36fcdb1ee78a5aa1a84bc42d32ceeb3653783c
Commit Graph

4104 Commits

Author SHA1 Message Date
Michael Vetter
bfa4a2ef1f Close windows on connection loss not general disc. 
Call `ui_close_all_wins();` only if we disconnect on purpose not when
connection is lost.

Otherwise users might miss messages.

This partly reverts 6ac73db876.
Regards https://github.com/profanity-im/profanity/issues/1083
 2019-05-27 12:52:04 +02:00
Michael Vetter
eb16c674ae Merge pull request #1092 from frnky/remove_mblen 
Don't call mblen() to not depend on locale
 2019-05-23 21:18:46 +02:00
Paul Fariello
04cd1b4409 Correctly handle malformed OMEMO messages 
Fix #1101
 2019-05-23 13:12:02 +02:00
Frank Zschockelt
56e925ed03 Don't call mblen() to not depend on locale 
mblen will fail with return code -1 if the locale used by the unit tests
isn't available on the machine. This will lead to an off by one error in some
tests where the needle is at the end of the haystack.

Since prof_occurrences expect null-terminated strings, the character after
the needle can simply be found by incrementing the address of the found needle
with strlen(needle).
 2019-05-22 19:57:52 +02:00
Michael Vetter
91d17edcb4 Merge pull request #1098 from optmzr/fix-omemo-gen-message 
Force UI update before generating OMEMO crypto materials

The message wouldn't show up before the generation of OMEMO crypto materials started.
 2019-05-22 09:52:29 +02:00
William Wennerström
e07a06d1a2 Force UI update before generating OMEMO crypto materials 2019-05-21 22:32:06 +02:00
Michael Vetter
883dbe1911 Create seperate function for disconnect cleanup 
Duplicate code in client_events.c and server_events.c. Let's have
events/common.c and a function containing that code.
 2019-05-19 22:57:51 +02:00
Michael Vetter
c94f3d0b4a Fix ifdef guard (should have been OMEMO) 2019-05-06 16:11:22 +02:00
Michael Vetter
9ecc14c95d Merge pull request #1090 from jubalh/fix/connection-loss-1089 
Reset things on connection loss
 2019-05-06 16:06:41 +02:00
Michael Vetter
6ac73db876 Reset things on connection loss 
Remove the windows, clear tls certs, clean omemo.
Regards https://github.com/profanity-im/profanity/issues/1089
 2019-05-06 12:30:33 +02:00
Michael Vetter
4a165b81e6 Merge pull request #1084 from jubalh/occupants-char 
Add occupants char
 2019-05-03 11:11:40 +02:00
Michael Vetter
a28f0d9e74 Update tests with new URL 
https://github.com/profanity-im/profanity/issues/1085
 2019-05-03 10:46:41 +02:00
Michael Vetter
ebbacec667 Update profanity URL in entity capabilities stanza 
Regards https://github.com/profanity-im/profanity/issues/1085
 2019-05-03 10:36:26 +02:00
Michael Vetter
9288621320 Update profanity URL in /tiny example 
Regards https://github.com/profanity-im/profanity/issues/1085
 2019-05-03 10:33:52 +02:00
Michael Vetter
1446ac15cb Check for new profanity version using new URL 
Regards https://github.com/profanity-im/profanity/issues/1085
 2019-05-03 10:33:46 +02:00
Michael Vetter
f082563bf2 Add occupants char 
`/occupants char` now sets a character that is displayed before the nick
in MUCs. Similar like `/roster char` is displaying a char for the roster.

Regards #690
 2019-05-02 17:01:55 +02:00
Michael Vetter
722cb5fdc3 OMEMO: Initialize result in omemo_automatic_start 
This is actually not needed because result will always be set.

hartmann had problems building profanity on OpenBSD and he proposed this
patch.

Let's use it to make the compiler happy there.
 2019-04-29 11:32:22 +02:00
Michael Vetter
a794dadfa9 OMEMO: Check if ID is present before using it 
Fixes https://github.com/boothj5/profanity/issues/1079
 2019-04-24 15:20:54 +02:00
Michael Vetter
1d2c0ddc69 Fix statusbar number in theme 
There is a typo here. So this actually never worked ;-)
 2019-04-24 14:48:24 +02:00
Michael Vetter
a666f0deae Fix formatting for privileges on 
`/privileges on` lists `Moderator`, `Visitor` etc. Formatting was wrong
here. Printing privilige followed by nickaname in the same line.
 2019-04-24 10:28:27 +02:00
Michael Vetter
30f9de61d0 Occupantswin: handle newline correctly 2019-04-24 09:49:14 +02:00
Michael Vetter
98f768bdc2 Add occupants wrap to help 2019-04-24 09:49:14 +02:00
Michael Vetter
259c5801cf Fix occupants header char message 2019-04-24 09:49:14 +02:00
Michael Vetter
125ca2f0d2 Add occupants wrap option 
Wrapping for the occupants panel like already exists for the roster
panel. See `/occupants wrap on`.

Regards https://github.com/boothj5/profanity/issues/690
 2019-04-24 09:49:14 +02:00
kaffeekanne
f8640019f3 Update copyright years 2019-04-24 01:08:38 +02:00
Michael Vetter
028839e35a Put occupants update into own function 2019-04-23 14:13:08 +02:00
Michael Vetter
566022786d Add occupants header char 
`/occupants header char` now sets a character that is displayed before
the role (moderator, visitor..) in a room. Similar to `/roster header
char` is displaying a char for the roster.

Regards https://github.com/boothj5/profanity/issues/690
 2019-04-23 14:13:03 +02:00
kaffeekanne
49e2838a98 Fix indentation for time config 2019-04-23 12:39:05 +02:00
Michael Vetter
d520667935 Adjust jid for occupants indent 
Indent the jid one more space than nick.
 2019-04-20 20:35:45 +02:00
Michael Vetter
2b0e75ce35 Add occupants indent autocompletion 2019-04-20 20:35:45 +02:00
Michael Vetter
62c23233f7 Allow setting occupants indent outside of MUC 
And when not connected.
 2019-04-20 20:35:37 +02:00
Michael Vetter
0c248a0b16 Add /occupants indent command 
Roster has a `/roster contact indent` option.
Now we have the same for occupants. So contacts in roster and in MUC can
have configurable indentation.

Regards https://github.com/boothj5/profanity/issues/690
 2019-04-18 20:53:02 +02:00
Michael Vetter
7e4e9e6688 Fix typo in /help roster 2019-04-18 17:05:10 +02:00
Michael Vetter
199e8752ca Merge pull request #1063 from paulfariello/hotfix/presence-before-roster 
Handle presence received before roster
 2019-04-17 20:47:54 +02:00
Michael Vetter
2f6387f3fa Set correct year in copyright display 
Fixes https://github.com/boothj5/profanity/issues/1069
 2019-04-17 20:44:39 +02:00
Paul Fariello
db55e01dce Follow OMEMO policy even when opening window on message and carbon reception 
This should close #1052
 2019-04-17 15:54:15 +02:00
Paul Fariello
973a05d15a Handle presence received before roster 
Presence of contact not found in roster are filtered out.
But sometimes roster is received after a first few presences.

We choose to store presences until we receive roster and then process
this presences.

Fixes #1050
 2019-04-17 14:19:31 +02:00
Paul Fariello
21ae946896 Handle MUC anonymous state when auto starting OMEMO 
When auto joining a MUC we don't have access to required information so
we just don't start OMEMO at this time.

Once we receive disco info we then try to start OMEMO.
 2019-04-17 14:03:14 +02:00
Paul Fariello
a6eb0d2c43 Handle missing real jid in OMEMO encrypted MUC 
This should never happens since we should ensure MUC is Non-Anonymous
before enabling OMEMO.

But we should neither segfault if this happens.
 2019-04-17 14:03:14 +02:00
Paul Fariello
5f015e32b2 Add OMEMO policy 
There is 3 policy:

- manual: OMEMO session are only started manually
- automatic: OMEMO session are only started if they have been started
  manually before
- always: OMEMO session are always started unless they have been ended
  manually before

Closes #1040 and fixes #1052
 2019-04-17 14:03:14 +02:00
Michael Vetter
9574127177 Merge pull request #1066 from paulfariello/hotfix/OMEMO-ensure-muc-is-nonanonymous 
Ensure MUC is Non-Anonymous before starting OMEMO
 2019-04-17 13:58:45 +02:00
Paul Fariello
8c71a74afe Ensure MUC is Non-Anonymous before starting OMEMO 
Store MUC anonymous type in mucwin for that purpose.

Fixes #1065
 2019-04-17 13:56:27 +02:00
Paul Fariello
fc8dc328a4 Alert about long OMEMO cryptographic generation 
Fixes #1055
 2019-04-17 09:55:16 +02:00
Michael Vetter
02d0f7fc38 Merge pull request #1061 from paulfariello/hotfix/handle-message-without-id-in-muc 
Handle message without id in MUC
 2019-04-15 10:43:39 +02:00
Paul Fariello
9c0a395408 Don't persist OMEMO {signed,}prekey cleaning on disconnect 
We should not remove signed prekey and prekey from persistent storage
when cleaning OMEMO store on disconnect.
 2019-04-14 22:03:16 +02:00
Paul Fariello
94a39b2e9b Handle malformed OMEMO identity.txt 
If OMEMO identity.txt is malformed just abort loading.
User should be able to call `/omemo gen` again.
 2019-04-14 22:03:16 +02:00
Paul Fariello
c33d8e5f0b Don't unload OMEMO cryto on disconnect if OMEMO wasn't loaded 
If OMEMO wasn't loaded, removing key would create empty identity.txt
file. Then at load time it would segfault profanity.

Another commit should fix load of malformed identity.txt.
 2019-04-14 22:03:16 +02:00
Paul Fariello
cdc0290a59 Handle message without id in MUC 
Some clients seems to send message without id.
 2019-04-14 21:53:26 +02:00
Paul Fariello
9714d1d867 Add random string at the end of the default resource 
When connecting for the first time or when creating a new account don't
use only 'profanity' as default resource.

Some server don't support having 2 connection with same resource. Using
profanity as default lead to deconnections.
 2019-04-12 15:49:54 +02:00
Paul Fariello
f75e1d7a7b Support contact name in /omemo fingerprint command 2019-04-10 17:24:56 +02:00