cproof

devs/cproof

Fork 1

Author SHA1 Message Date

Author	SHA1	Message	Date
jabber.developer2	adab585c09	fix(review): address PR #105 review follow-ups All checks were successful CI Code / Check coding style (pull_request) Successful in 31s Details CI Code / Check spelling (pull_request) Successful in 18s Details CI Code / Linux (debian) (pull_request) Successful in 4m45s Details CI Code / Linux (ubuntu) (pull_request) Successful in 4m56s Details CI Code / Linux (arch) (pull_request) Successful in 5m39s Details CI Code / Code Coverage (pull_request) Successful in 6m41s Details - src/log.c: log_stderr_init no longer closes STDERR_FILENO immediately after dup2(). The previous 'close(dup_fd)' closed fd 2 because dup2 returns newfd on success; the in-app stderr capture pipe was silently dead, dropping libstrophe/openssl error output. Close the original stderr_pipe[1] instead and remember that the write end now lives at STDERR_FILENO so _log_stderr_close stays correct. - src/database_sqlite.c: NULL-check sqlite3_mprintf result before passing it to sqlite3_exec in the DbVersion bootstrap path. - src/tools/editor.c: drop three orphan #includes (<fcntl.h>, <pthread.h>, <readline/readline.h>) left behind when `9b03e3a50` removed the async-editor path. - src/xmpp/jid.c: match the g_new0 allocation in jid_create with g_free in jid_destroy. Same behaviour on glibc but stops being a foot-gun under custom glib allocators. Verified with ci-build.sh in Debian docker: all 4 configs pass (644/0, 605/0, 605/0, 644/0 unit + 130/0 functional).	2026-05-21 15:40:25 +03:00

jabber.developer2

adab585c09

fix(review): address PR #105 review follow-ups

CI Code / Check coding style (pull_request) Successful in 31s

Details

CI Code / Check spelling (pull_request) Successful in 18s

Details

CI Code / Linux (debian) (pull_request) Successful in 4m45s

Details

CI Code / Linux (ubuntu) (pull_request) Successful in 4m56s

Details

CI Code / Linux (arch) (pull_request) Successful in 5m39s

Details

CI Code / Code Coverage (pull_request) Successful in 6m41s

Details

- src/log.c: log_stderr_init no longer closes STDERR_FILENO immediately
  after dup2(). The previous 'close(dup_fd)' closed fd 2 because dup2
  returns newfd on success; the in-app stderr capture pipe was silently
  dead, dropping libstrophe/openssl error output. Close the original
  stderr_pipe[1] instead and remember that the write end now lives at
  STDERR_FILENO so _log_stderr_close stays correct.

- src/database_sqlite.c: NULL-check sqlite3_mprintf result before
  passing it to sqlite3_exec in the DbVersion bootstrap path.

- src/tools/editor.c: drop three orphan #includes (<fcntl.h>,
  <pthread.h>, <readline/readline.h>) left behind when 9b03e3a50
  removed the async-editor path.

- src/xmpp/jid.c: match the g_new0 allocation in jid_create with
  g_free in jid_destroy. Same behaviour on glibc but stops being a
  foot-gun under custom glib allocators.

Verified with ci-build.sh in Debian docker: all 4 configs pass
(644/0, 605/0, 605/0, 644/0 unit + 130/0 functional).

2026-05-21 15:40:25 +03:00

Compare commits

1 Commits

97fd81b60b ... adab585c09

Diff Content Not Available

Compare commits

1 Commits 97fd81b60b ... adab585c09

Diff Content Not Available

1 Commits

97fd81b60b ... adab585c09