devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Memory leak due to theme reinitiation #4

New Issue
Closed
opened 2025-06-20 15:41:08 +00:00 by jabber.developer · 0 comments
jabber.developer commented 2025-06-20 15:41:08 +00:00
Owner
Copy Link

Commit 6034b833be introduced a call to theme_init(theme) after entering the PGP key password. However, this introduces two issues:

  1. The call may be unnecessary in this context, as no visual redrawing occurs — only preference loading.
  2. It introduces a potential memory leak.

The function theme_init(const char* const theme_name) includes the following line:

src/config/theme.c Line 104 in ddc4290c99
defaults = g_hash_table_new_full(g_str_hash, g_str_equal, free, free);

Because there is no check for an existing defaults table, any previously allocated hash table is silently overwritten. If _theme_close() is not called beforehand, this results in a memory leak.

This behavior is problematic, as it makes it easy to introduce memory leaks simply by invoking theme_init() repeatedly without proper cleanup.

Recommended Fix

  • Add explicit support for theme reinitialization, including proper cleanup and logging.
  • Ensure any existing hash tables are freed or reused appropriately inside theme_init().
  • Consider removing the theme_init() call from sv_ev_roster_received, as it appears unnecessary for this code path and contributes to inefficiency and resource leaks.
Commit 6034b833be introduced a call to `theme_init(theme)` after entering the PGP key password. However, this introduces two issues: 1. The call may be unnecessary in this context, as no visual redrawing occurs — only preference loading. 2. It introduces a potential memory leak. The function `theme_init(const char* const theme_name)` includes the following line: https://git.jabber.space/devs/profanity/src/commit/ddc4290c990cd3941d324d9b8ae9ed1f99bc9a46/src/config/theme.c#L104 Because there is no check for an existing `defaults` table, any previously allocated hash table is silently overwritten. If `_theme_close()` is not called beforehand, this results in a memory leak. This behavior is problematic, as it makes it easy to introduce memory leaks simply by invoking `theme_init()` repeatedly without proper cleanup. ### Recommended Fix - Add explicit support for theme reinitialization, including proper cleanup and logging. - Ensure any existing hash tables are freed or reused appropriately inside `theme_init()`. - Consider removing the `theme_init()` call from `sv_ev_roster_received`, as it appears unnecessary for this code path and contributes to inefficiency and resource leaks.
admin closed this issue 2025-06-24 15:37:12 +00:00
jabber.developer self-assigned this 2025-09-01 22:23:52 +00:00
jabber.developer added the
Kind/Bug
 label 2025-09-01 22:24:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees jabber.developer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?