devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Minor optimizations and improvements #58

New Issue
Closed
opened 2025-11-10 12:09:55 +00:00 by jabber.developer · 0 comments
jabber.developer commented 2025-11-10 12:09:55 +00:00
Owner
Copy Link
  • Optimize glib iterations: g_hash_table_get_keys to g_hash_table_iter_init
  • connection.c: potential bug on 1031 calloc zeros the array, so each conn.queued_messages[n] starts as NULL. The loop condition n < send_queue_len && conn.queued_messages[n] evaluates to false immediately (since NULL is falsey), skipping the body entirely. Messages are dropped from the queue (via drop_element) but never stored—effectively lost.
  • cons_show(variable instead of cons_show("%s", variable)
- [x] Optimize glib iterations: g_hash_table_get_keys to g_hash_table_iter_init - [x] connection.c: potential bug on 1031 calloc zeros the array, so each conn.queued_messages[n] starts as NULL. The loop condition n < send_queue_len && conn.queued_messages[n] evaluates to false immediately (since NULL is falsey), skipping the body entirely. Messages are dropped from the queue (via drop_element) but never stored—effectively lost. - [x] cons_show(variable instead of cons_show("%s", variable)
jabber.developer added the
Kind/Enhancement
 label 2025-11-10 12:09:55 +00:00
jabber.developer added this to the Plans (2025-2026) project 2025-11-10 12:25:47 +00:00
jabber.developer moved this to To Do in Plans (2025-2026) on 2025-11-10 12:26:06 +00:00
jabber.developer moved this to In Progress in Plans (2025-2026) on 2025-11-10 12:27:44 +00:00
jabber.developer moved this to To Do in Plans (2025-2026) on 2025-11-10 12:28:23 +00:00
jabber.developer2 moved this to In Progress in Plans (2025-2026) on 2025-11-10 12:55:42 +00:00
jabber.developer2 moved this to To Do in Plans (2025-2026) on 2025-11-10 12:55:47 +00:00
jabber.developer2 moved this to In Progress in Plans (2025-2026) on 2025-11-10 12:55:49 +00:00
jabber.developer2 self-assigned this 2025-11-10 12:56:41 +00:00
jabber.developer2 added reference playground/fix/src_refactoring 2025-11-10 15:50:07 +00:00
jabber.developer moved this to Verification in Plans (2025-2026) on 2026-01-16 15:41:04 +00:00
jabber.developer moved this to In Progress in Plans (2025-2026) on 2026-01-16 15:41:22 +00:00
jabber.developer added the
Priority
Medium
3
Reviewed
Confirmed
1
 labels 2026-01-21 17:02:23 +00:00
jabber.developer moved this to Done in Plans (2025-2026) on 2026-02-06 19:02:01 +00:00
Sign in to join this conversation.
playground/fix/src_refactoring
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Enhancement
Priority
Medium
3
Reviewed
Confirmed
1
Milestone
No items
No Milestone
Projects
Clear projects
No project Plans (2025-2026)
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees jabber.developer2
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#58
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?