devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

TODOs and Disabled Tests in Functional Tests #66

New Issue
Open
opened 2026-01-06 15:08:04 +00:00 by jabber.developer2 · 1 comment
jabber.developer2 commented 2026-01-06 15:08:04 +00:00
Collaborator
Copy Link

Description

Several TODO items and disabled test are need clarification.

TODO Items

  1. Replace synchronization with proper mechanism
    File: tests/functionaltests/proftest.c:308

The current implementation uses a workaround for synchronization between test harness and profanity process.

  1. XEP-0308 Message Correction compliance
    File: tests/functionaltests/test_message.c:26

Need to verify that message corrections properly reference the original message ID per XEP-0308 specification.

  1. Proper wait mechanism for capabilities
    File: tests/functionaltests/test_ping.c:41

Current implementation may use timing-based waits instead of event-based synchronization. Stabber issue

Disabled Tests

  1. shows_history_message - MUC history test
    File: tests/functionaltests/functionaltests.c:129

Status: Temporarily disabled
Reason: Timing issues in CI environment

The test verifies that MUC (Multi-User Chat) history messages with element (XEP-0203) are displayed correctly. It was disabled due to flaky behavior under CI load.

Suggested fix: Add proper synchronization or increase timeout for history message processing.

## Description Several TODO items and disabled test are need clarification. ### TODO Items 1. Replace synchronization with proper mechanism File: tests/functionaltests/proftest.c:308 The current implementation uses a workaround for synchronization between test harness and profanity process. 2. XEP-0308 Message Correction compliance File: tests/functionaltests/test_message.c:26 Need to verify that message corrections properly reference the original message ID per XEP-0308 specification. 3. Proper wait mechanism for capabilities File: tests/functionaltests/test_ping.c:41 Current implementation may use timing-based waits instead of event-based synchronization. [Stabber issue](https://git.jabber.space/devs/stabber/issues/3) ### Disabled Tests 1. shows_history_message - MUC history test File: tests/functionaltests/functionaltests.c:129 Status: Temporarily disabled Reason: Timing issues in CI environment The test verifies that MUC (Multi-User Chat) history messages with <delay> element (XEP-0203) are displayed correctly. It was disabled due to flaky behavior under CI load. Suggested fix: Add proper synchronization or increase timeout for history message processing.
jabber.developer2 added this to the Plans (2025-2026) project 2026-01-06 15:08:30 +00:00
jabber.developer2 moved this to To Do in Plans (2025-2026) on 2026-01-06 15:08:56 +00:00
jabber.developer2 added the
Kind/Testing
 label 2026-01-06 15:09:52 +00:00
jabber.developer commented 2026-01-21 17:12:48 +00:00
Owner
Copy Link

We also have certain "inconsistencies" reported by codecov.

We also have certain "inconsistencies" reported by codecov.
jabber.developer added the
Priority
Medium
3
Reviewed
Confirmed
1
 labels 2026-01-21 17:13:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Testing
Priority
Medium
3
Reviewed
Confirmed
1
Milestone
No items
No Milestone
Projects
Clear projects
No project Plans (2025-2026)
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#66
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?