devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Light code cleanup #8

Manually merged
jabber.developer merged 3 commits from ref/light-cleanup into master 2026-06-16 11:33:10 +00:00
Conversation 0 Commits 3 Files Changed 11 +27 -9
jabber.developer commented 2025-06-25 16:32:42 +00:00
Owner
Copy Link

PR aims to cleanup code parts based on the clangd's suggestions.

  • I ran valgrind when using my new feature

How to test the functionality

  • step 1
  • step 2
PR aims to cleanup code parts based on the `clangd`'s suggestions. <!-- For completed items, change [ ] to [x]. --> - [ ] I ran valgrind when using my new feature ### How to test the functionality - step 1 - step 2
jabber.developer added 3 commits 2025-06-25 16:32:43 +00:00
build: add missing includes to header files 0a4ab72dd5 
This change adds necessary `#include` directives that were previously
omitted in some header files. Without these includes, compilation
could fail or produce undefined behavior when the headers are used
in isolation (i.e., before their dependencies are included elsewhere).

Ensures better modularity and reliability of header usage.
fix: add missing parameter types to function declarations 4756981097 
Some functions were declared without parameters in header files,
despite their implementations specifying arguments. This mismatch
is deprecated in all versions of C and is disallowed in C23.

This change updates the declarations to match their definitions,
ensuring compatibility with C standards, avoiding potential
undefined behavior, and improving support in tools and editors.
refactor: rename argument to avoid C++ keyword conflict
All checks were successful
CI / Check spelling (pull_request) Successful in 16s
Details
CI / Check coding style (pull_request) Successful in 31s
Details
CI / Linux (debian) (pull_request) Successful in 9m43s
Details
CI / Linux (ubuntu) (pull_request) Successful in 10m0s
Details
CI / Linux (fedora) (pull_request) Successful in 10m36s
Details
CI / Linux (arch) (pull_request) Successful in 16m37s
Details
3a771a8c81 
The parameter `template` in format_call_external_argv() was renamed
to `template_fmt` to avoid collision with the `template` keyword in
C++. This improves compatibility when the header is included in
C++ code.
jabber.developer force-pushed ref/light-cleanup from 3a771a8c81 to b002e6237b 2025-07-19 18:32:35 +00:00 Compare
jabber.developer force-pushed ref/light-cleanup from b002e6237b to dc66dab7f5 2025-08-26 09:47:05 +00:00 Compare
jabber.developer force-pushed ref/light-cleanup from dc66dab7f5 to 25ad07f592 2025-09-01 19:31:47 +00:00 Compare
jabber.developer force-pushed ref/light-cleanup from 25ad07f592 to 51b6167ead 2025-09-16 22:49:58 +00:00 Compare
jabber.developer requested review from jabber.developer2 2025-12-02 16:38:00 +00:00
jabber.developer added this to the Plans (2025-2026) project 2025-12-02 16:38:54 +00:00
jabber.developer moved this to In Progress in Plans (2025-2026) on 2025-12-02 16:39:07 +00:00
jabber.developer force-pushed ref/light-cleanup from 51b6167ead to 971d60ce36 2026-02-16 14:55:34 +00:00 Compare
jabber.developer force-pushed ref/light-cleanup from 971d60ce36 to 6c25806bec 2026-04-26 11:18:11 +00:00 Compare
jabber.developer force-pushed ref/light-cleanup from 6c25806bec to 9aef595b2d 2026-05-15 12:23:58 +00:00 Compare
jabber.developer force-pushed ref/light-cleanup from 9aef595b2d to 5b45b35b3e 2026-06-16 11:21:25 +00:00 Compare
jabber.developer manually merged commit 5b45b35b3e into master 2026-06-16 11:33:10 +00:00
jabber.developer moved this to Done in Plans (2025-2026) on 2026-06-16 11:34:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
jabber.developer2
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Plans (2025-2026)
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#8
No description provided.
Delete Branch "ref/light-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?