devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

auto-fallback to UTF-8 locale when MB_CUR_MAX exceeds limit #86

New Issue
Open
opened 2026-02-06 11:16:28 +00:00 by jabber.developer2 · 0 comments
jabber.developer2 commented 2026-02-06 11:16:28 +00:00
Collaborator
Copy Link

Summary

Currently, when MB_CUR_MAX exceeds PROF_MB_CUR_MAX, we show an error and disable the input window. The user must manually run export LC_ALL=C.UTF-8 before starting profanity.

Proposal

Automatically attempt to switch to a safe UTF-8 locale at runtime and notify the user.

Implementation

if (MB_CUR_MAX > PROF_MB_CUR_MAX) {
    const char* fallbacks[] = {"C.UTF-8", "en_US.UTF-8", "POSIX", NULL};
    for (int i = 0; fallbacks[i]; i++) {
        if (setlocale(LC_ALL, fallbacks[i])) {
            cons_show_warn("Locale auto-switched to %s (original MB_CUR_MAX exceeded limit)", fallbacks[i]);
            break;
        }
    }
    if (MB_CUR_MAX > PROF_MB_CUR_MAX) {
        cons_show_error("Unsupported locale...");
        return;
    }
}

Benefits

  • Better UX: works out-of-the-box on exotic locales
  • User is informed about the fallback
  • Preserves current behavior if fallback fails

Considerations

  • setlocale() affects the entire process — document this
  • May want a config option to disable auto-fallback
  • Test on various distros with different locale availability

Dependencies

  • Requires #XX (cons_show_warn() implementation)
## Summary Currently, when `MB_CUR_MAX` exceeds `PROF_MB_CUR_MAX`, we show an error and disable the input window. The user must manually run `export LC_ALL=C.UTF-8` before starting profanity. ## Proposal Automatically attempt to switch to a safe UTF-8 locale at runtime and notify the user. ### Implementation ```c if (MB_CUR_MAX > PROF_MB_CUR_MAX) { const char* fallbacks[] = {"C.UTF-8", "en_US.UTF-8", "POSIX", NULL}; for (int i = 0; fallbacks[i]; i++) { if (setlocale(LC_ALL, fallbacks[i])) { cons_show_warn("Locale auto-switched to %s (original MB_CUR_MAX exceeded limit)", fallbacks[i]); break; } } if (MB_CUR_MAX > PROF_MB_CUR_MAX) { cons_show_error("Unsupported locale..."); return; } } ``` ### Benefits - Better UX: works out-of-the-box on exotic locales - User is informed about the fallback - Preserves current behavior if fallback fails ### Considerations - `setlocale()` affects the entire process — document this - May want a config option to disable auto-fallback - Test on various distros with different locale availability ### Dependencies - Requires #XX (`cons_show_warn()` implementation)
jabber.developer2 added the
Kind/Enhancement
Priority
Low
4
 labels 2026-02-06 11:16:28 +00:00
jabber.developer2 added this to the Plans (2025-2026) project 2026-02-06 11:16:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Enhancement
Priority
Low
4
Milestone
No items
No Milestone
Projects
Clear projects
No project Plans (2025-2026)
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#86
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?