[#7] Fix scrolling being stuck #9

Manually merged

jabber.developer merged 2 commits from fix/scrolling-issue into master 2025-07-01 21:23:16 +00:00

Conversation 0 Commits 2 Files Changed 8 +85 -42

jabber.developer commented 2025-07-01 18:54:19 +00:00

Owner

Copy Link

• I ran valgrind when using my new feature

How to test the functionality

• Use page up/page down and observe that paging is smooth

Fixes #7
Closes #7

<!--- Make sure to read CONTRIBUTING.md --> <!--- It mentions the rules to follow and helpful tools --> <!-- For completed items, change [ ] to [x]. --> - [x] I ran valgrind when using my new feature ### How to test the functionality - Use page up/page down and observe that paging is smooth Fixes #7 Closes #7

jabber.developer added 2 commits 2025-07-01 18:54:19 +00:00

fix: Increase scrollback buffer height for chat rendering (PAD_SIZE) ... 6a394ae2e5

f27fa98 commit introduced issue of scrolling seemingly randomly being stuck and the following message flood in the logs: "WRN: Ncurses Overflow..."

A pad is an off-screen buffer — larger than the visible terminal screen — that you can scroll, render parts of, or update selectively.

Unlike regular windows, a pad is not tied to screen size. You can create a pad that's 1,000 lines tall, even if your terminal is only 40 lines tall.

This commit addresses the issue by increasing PAD_SIZE to a reasonable number,
allowing messages from buffer to be displayed without overflowing NCurses' window size (maxy).

Minor change: add .cache folder to gitignore

Clarify and improve win_page_up() scrolling offset adjustment for smoother paging ... 40b7a12543

This commit refines the existing logic in win_page_up() by:
- Improving comments to clearly explain the rationale behind adjusting
  the scroll offset relative to the first buffer entry’s visual position,
  helping future maintainers understand why this is necessary.
- Fixing offset recalculation to better handle cases where older messages
  with variable heights are loaded from the DB, improving scroll smoothness.
- Changing the logging of negative *page_start values from warning to debug,
  recognizing that this can be a normal scenario when insufficient history is loaded.
- Simplifying some conditionals and renaming variables for clearer intent.

No changes yet applied to win_page_down(), but similar improvements could
be considered in the future.

Overall, this enhances the robustness and user experience of scrolling up
in chat windows, while preserving existing functional logic.

jabber.developer manually merged commit 40b7a12543 into master 2025-07-01 21:23:16 +00:00

jabber.developer referenced this pull request 2025-07-01 21:23:59 +00:00

Scrolling being stuck #7

jabber.developer changed title from Fix scrolling to Fix scrolling being stuck 2025-07-02 08:21:01 +00:00

jabber.developer changed title from Fix scrolling being stuck to [#7] Fix scrolling being stuck 2025-11-10 06:59:36 +00:00

jabber.developer2 referenced this issue from a commit 2026-05-27 11:30:15 +00:00

fix: address issue #112 follow-ups (OTR strip, presence UAF, OMEMO load)

jabber.developer2 referenced this pull request 2026-05-27 11:30:53 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load #130

jabber.developer2 referenced this issue from a commit 2026-06-19 09:46:13 +00:00

fix: address issue #112 follow-ups (OTR strip, presence UAF, OMEMO load)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin jabber.developer jabber.developer2

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: devs/cproof#9

No description provided.