All checks were successful
CI Code / Check spelling (push) Successful in 18s
CI Code / Check coding style (push) Successful in 34s
CI Code / Code Coverage (push) Successful in 2m36s
CI Code / Linux (debian) (push) Successful in 4m41s
CI Code / Linux (ubuntu) (push) Successful in 4m52s
CI Code / Linux (arch) (push) Successful in 5m40s
Sync with upstream profanity-im/profanity.
Major upstream changes incorporated:
Memory management
- Replace malloc+memset with g_new0 throughout codebase
- Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
- Replace free() with g_free() for GAlloc'd memory
Editor rewrite
- Remove pthread-based async editor; use GChildWatch callback API
- New launch_editor(initial_content, callback, user_data) interface
- Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
- ui_suspend()/ui_resume() integration for TTY management
OMEMO improvements
- Dual backend support: libsignal-protocol-c and libomemo-c
- Proper pre-key removal after use (XEP-0384 compliance)
- Automatic pre-key regeneration when store drops below threshold
- New functions: omemo_is_device_active(), omemo_is_jid_trusted()
- omemo_get_jid_untrusted_fingerprints() for better error messages
- Fingerprint notifications on new device identity discovery
- Deterministic pre-key ID generation tracking max_pre_key_id
- omemo_trust_changed() UI updates on trust state changes
JID validation
- RFC 6122-compliant validation in jid_is_valid()
- Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
- Length limits: 1023 per component, 3071 total
- New jid_is_valid_user_jid() for user vs. service JID distinction
Database
- Schema migration v3: UNIQUE constraint on archive_id for deduplication
- Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
- db_history_result_t return type, _truncate_datetime_suffix()
UI / console
- win_warn_needed() / win_warn_sent() warning deduplication hash table
- PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
- Spellcheck integration in input field with Unicode word detection
- cons_spellcheck_setting() for /settings ui output
- /[command]? shortcut for command help
Account config
- Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
- Replace popen() with g_spawn_sync() for eval_password
- TLS policy: add "direct" option alongside legacy
Connection
- Port validation with g_assert (0–65535)
- SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
- "direct" TLS policy alias for legacy SSL
Common utilities
- str_xml_sanitize() for XML 1.0 illegal character removal
- string_matches_one_of() with formatted error messages
- valid_tls_policy_option() helper
- prof_date_time_format_iso8601() utility
- Improved strip_arg_quotes() with backslash unescaping
- prof_occurrences() uses g_slist_prepend + reverse for performance
PGP / OX
- Proper GPGME resource cleanup with goto-cleanup pattern
- g_string_free(xmppuri) leak fix in _ox_key_lookup
CSV export
- Use GString + g_file_set_contents instead of raw write() syscalls
Tests
- Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
- New test_cmd_ac.c for autocompleter unit tests
- Updated stubs for new UI suspend/resume functions
License headers
- Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)
────────────────────────────────────────────────────
cproof-specific preservations:
- XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
- Force encryption: cmd_force_encryption, test_forced_encryption
- CWE-134: format string protection (cons_show("%s", ...))
- y_start_pos-based paging in window.c
- db_history_result_t return type, _truncate_datetime_suffix()
Merge-time fixes:
- common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
- database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
- console.c: implicit size_t → int cast — (int)(maxlen + 1)
- tlscerts.c: %d for size_t — %zu
Build system:
- Kept autotools (Makefile.am, configure.ac); upstream uses Meson
- Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
- Updated Makefile.am test paths for subdirectory structure
- Added test_cmd_ac, test_forced_encryption to test sources
Functional tests:
- Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
- Not yet available in devs/stabber fork
Closes #64
Merge author: jabber.developer2
Commits authors:
Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
766 lines
19 KiB
C
766 lines
19 KiB
C
#include "prof_cmocka.h"
|
|
#include <stdlib.h>
|
|
|
|
#include "tools/parser.h"
|
|
|
|
void
|
|
parse_args__returns__null_from_null(void** state)
|
|
{
|
|
char* inp = NULL;
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__null_from_empty(void** state)
|
|
{
|
|
char* inp = "";
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__null_from_space(void** state)
|
|
{
|
|
char* inp = " ";
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__null_when_no_args(void** state)
|
|
{
|
|
char* inp = "/cmd";
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__null_from_cmd_with_space(void** state)
|
|
{
|
|
char* inp = "/cmd ";
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__null_when_too_few(void** state)
|
|
{
|
|
char* inp = "/cmd arg1";
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 2, 3, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__null_when_too_many(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 arg2 arg3 arg4";
|
|
gboolean result = TRUE;
|
|
gchar** args = parse_args(inp, 1, 3, &result);
|
|
|
|
assert_false(result);
|
|
assert_null(args);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__one_arg(void** state)
|
|
{
|
|
char* inp = "/cmd arg1";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(1, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__two_args(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 1, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__three_args(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 arg2 arg3";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 3, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
assert_string_equal("arg3", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__three_args_with_spaces(void** state)
|
|
{
|
|
char* inp = " /cmd arg1 arg2 arg3 ";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 3, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
assert_string_equal("arg3", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__freetext(void** state)
|
|
{
|
|
char* inp = "/cmd this is some free text";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 1, 1, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(1, g_strv_length(args));
|
|
assert_string_equal("this is some free text", args[0]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__one_arg_with_freetext(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 this is some free text";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 1, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("this is some free text", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__two_args_with_freetext(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 arg2 this is some free text";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 1, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
assert_string_equal("this is some free text", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__zero_args_when_min_zero(void** state)
|
|
{
|
|
char* inp = "/cmd";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 0, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(0, g_strv_length(args));
|
|
assert_null(args[0]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__zero_args_when_min_zero(void** state)
|
|
{
|
|
char* inp = "/cmd";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 0, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(0, g_strv_length(args));
|
|
assert_null(args[0]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__quoted_args(void** state)
|
|
{
|
|
char* inp = "/cmd \"arg1\" arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__quoted_args_with_space(void** state)
|
|
{
|
|
char* inp = "/cmd \"the arg1\" arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("the arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__quoted_args_with_many_spaces(void** state)
|
|
{
|
|
char* inp = "/cmd \"the arg1 is here\" arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("the arg1 is here", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__many_quoted_args_with_many_spaces(void** state)
|
|
{
|
|
char* inp = "/cmd \"the arg1 is here\" \"and arg2 is right here\"";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("the arg1 is here", args[0]);
|
|
assert_string_equal("and arg2 is right here", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__quoted_args(void** state)
|
|
{
|
|
char* inp = "/cmd \"arg1\" arg2 hello there what's up";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 3, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
assert_string_equal("hello there what's up", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__quoted_args_with_space(void** state)
|
|
{
|
|
char* inp = "/cmd \"the arg1\" arg2 another bit of freetext";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 3, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("the arg1", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
assert_string_equal("another bit of freetext", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__quoted_args_with_many_spaces(void** state)
|
|
{
|
|
char* inp = "/cmd \"the arg1 is here\" arg2 some more freetext";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 3, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("the arg1 is here", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
assert_string_equal("some more freetext", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__many_quoted_args_with_many_spaces(void** state)
|
|
{
|
|
char* inp = "/cmd \"the arg1 is here\" \"and arg2 is right here\" and heres the free text";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 3, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("the arg1 is here", args[0]);
|
|
assert_string_equal("and arg2 is right here", args[1]);
|
|
assert_string_equal("and heres the free text", args[2]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__quoted_freetext(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 here is \"some\" quoted freetext";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 1, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("here is \"some\" quoted freetext", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__quoted_start_of_freetext(void** state)
|
|
{
|
|
char* inp = "/cmd arg1 \"arg2 with space\" more text";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 1, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("arg1", args[0]);
|
|
assert_string_equal("\"arg2 with space\" more text", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__third_arg_quoted(void** state)
|
|
{
|
|
char* inp = "/group add friends \"The User\"";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 0, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("add", args[0]);
|
|
assert_string_equal("friends", args[1]);
|
|
assert_string_equal("The User", args[2]);
|
|
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__second_arg_quoted(void** state)
|
|
{
|
|
char* inp = "/group add \"The Group\" friend";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 0, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("add", args[0]);
|
|
assert_string_equal("The Group", args[1]);
|
|
assert_string_equal("friend", args[2]);
|
|
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args_with_freetext__returns__second_and_third_arg_quoted(void** state)
|
|
{
|
|
char* inp = "/group add \"The Group\" \"The User\"";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args_with_freetext(inp, 0, 3, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(3, g_strv_length(args));
|
|
assert_string_equal("add", args[0]);
|
|
assert_string_equal("The Group", args[1]);
|
|
assert_string_equal("The User", args[2]);
|
|
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__escaped_quotes(void** state)
|
|
{
|
|
char* inp = "/cmd \"Thor \\\"The Thunderer\\\" Odinson\" arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("Thor \"The Thunderer\" Odinson", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__escaped_spaces(void** state)
|
|
{
|
|
char* inp = "/cmd Thor\\ The\\ Thunderer\\ Odinson arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("Thor The Thunderer Odinson", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
parse_args__returns__escaped_backslash(void** state)
|
|
{
|
|
char* inp = "/cmd \"Thor \\\\ Odinson\" arg2";
|
|
gboolean result = FALSE;
|
|
gchar** args = parse_args(inp, 2, 2, &result);
|
|
|
|
assert_true(result);
|
|
assert_int_equal(2, g_strv_length(args));
|
|
assert_string_equal("Thor \\ Odinson", args[0]);
|
|
assert_string_equal("arg2", args[1]);
|
|
g_strfreev(args);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__one_token(void** state)
|
|
{
|
|
char* inp = "one";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(1, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__one_token_quoted_no_whitespace(void** state)
|
|
{
|
|
char* inp = "\"one\"";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(1, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__one_token_quoted_with_whitespace(void** state)
|
|
{
|
|
char* inp = "\"one two\"";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(1, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__two_tokens(void** state)
|
|
{
|
|
char* inp = "one two";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(2, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__two_tokens_first_quoted(void** state)
|
|
{
|
|
char* inp = "\"one and\" two";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(2, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__two_tokens_second_quoted(void** state)
|
|
{
|
|
char* inp = "one \"two and\"";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(2, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__returns__two_tokens_both_quoted(void** state)
|
|
{
|
|
char* inp = "\"one and then\" \"two and\"";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(2, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__handles__escapes(void** state)
|
|
{
|
|
char* inp = "one\\ two \"three \\\" four\"";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(2, result);
|
|
}
|
|
|
|
void
|
|
count_tokens__handles__multiple_spaces(void** state)
|
|
{
|
|
char* inp = "one two";
|
|
int result = count_tokens(inp);
|
|
|
|
assert_int_equal(2, result);
|
|
}
|
|
|
|
void
|
|
get_start__returns__first_of_one(void** state)
|
|
{
|
|
char* inp = "one";
|
|
char* result = get_start(inp, 2);
|
|
|
|
assert_string_equal("one", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__returns__first_of_two(void** state)
|
|
{
|
|
char* inp = "one two";
|
|
char* result = get_start(inp, 2);
|
|
|
|
assert_string_equal("one ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__returns__first_two_of_three(void** state)
|
|
{
|
|
char* inp = "one two three";
|
|
char* result = get_start(inp, 3);
|
|
|
|
assert_string_equal("one two ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__returns__first_two_of_three_first_quoted(void** state)
|
|
{
|
|
char* inp = "\"one\" two three";
|
|
char* result = get_start(inp, 3);
|
|
|
|
assert_string_equal("\"one\" two ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__returns__first_two_of_three_second_quoted(void** state)
|
|
{
|
|
char* inp = "one \"two\" three";
|
|
char* result = get_start(inp, 3);
|
|
|
|
assert_string_equal("one \"two\" ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__returns__first_two_of_three_first_and_second_quoted(void** state)
|
|
{
|
|
char* inp = "\"one\" \"two\" three";
|
|
char* result = get_start(inp, 3);
|
|
|
|
assert_string_equal("\"one\" \"two\" ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__handles__escapes(void** state)
|
|
{
|
|
char* inp = "one\\ two three";
|
|
char* result = get_start(inp, 2);
|
|
|
|
assert_string_equal("one\\ two ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
get_start__handles__multiple_spaces(void** state)
|
|
{
|
|
char* inp = "one two";
|
|
char* result = get_start(inp, 2);
|
|
|
|
assert_string_equal("one ", result);
|
|
g_free(result);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__empty_hashmap_when_none(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", NULL };
|
|
gchar* keys[] = { "opt1", NULL };
|
|
|
|
gboolean res = FALSE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_true(options != NULL);
|
|
assert_int_equal(0, g_hash_table_size(options));
|
|
assert_true(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__error_when_opt1_no_val(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", NULL };
|
|
gchar* keys[] = { "opt1", NULL };
|
|
|
|
gboolean res = TRUE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_null(options);
|
|
assert_false(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__map_when_one(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", NULL };
|
|
gchar* keys[] = { "opt1", NULL };
|
|
|
|
gboolean res = FALSE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_int_equal(1, g_hash_table_size(options));
|
|
assert_true(g_hash_table_contains(options, "opt1"));
|
|
assert_string_equal("val1", g_hash_table_lookup(options, "opt1"));
|
|
assert_true(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__error_when_opt2_no_val(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", "opt2", NULL };
|
|
gchar* keys[] = { "opt1", "opt2", NULL };
|
|
|
|
gboolean res = TRUE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_null(options);
|
|
assert_false(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__map_when_two(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", "opt2", "val2", NULL };
|
|
gchar* keys[] = { "opt1", "opt2", NULL };
|
|
|
|
gboolean res = FALSE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_int_equal(2, g_hash_table_size(options));
|
|
assert_true(g_hash_table_contains(options, "opt1"));
|
|
assert_true(g_hash_table_contains(options, "opt2"));
|
|
assert_string_equal("val1", g_hash_table_lookup(options, "opt1"));
|
|
assert_string_equal("val2", g_hash_table_lookup(options, "opt2"));
|
|
assert_true(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__error_when_opt3_no_val(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", "opt2", "val2", "opt3", NULL };
|
|
gchar* keys[] = { "opt1", "opt2", "opt3", NULL };
|
|
|
|
gboolean res = TRUE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_null(options);
|
|
assert_false(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__map_when_three(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", "opt2", "val2", "opt3", "val3", NULL };
|
|
gchar* keys[] = { "opt1", "opt2", "opt3", NULL };
|
|
|
|
gboolean res = FALSE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_int_equal(3, g_hash_table_size(options));
|
|
assert_true(g_hash_table_contains(options, "opt1"));
|
|
assert_true(g_hash_table_contains(options, "opt2"));
|
|
assert_true(g_hash_table_contains(options, "opt3"));
|
|
assert_string_equal("val1", g_hash_table_lookup(options, "opt1"));
|
|
assert_string_equal("val2", g_hash_table_lookup(options, "opt2"));
|
|
assert_string_equal("val3", g_hash_table_lookup(options, "opt3"));
|
|
assert_true(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__error_when_unknown_opt(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", "oops", "val2", "opt3", "val3", NULL };
|
|
gchar* keys[] = { "opt1", "opt2", "opt3", NULL };
|
|
|
|
gboolean res = TRUE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_null(options);
|
|
assert_false(res);
|
|
|
|
options_destroy(options);
|
|
}
|
|
|
|
void
|
|
parse_options__returns__error_when_duplicated_option(void** state)
|
|
{
|
|
gchar* args[] = { "cmd1", "cmd2", "opt1", "val1", "opt2", "val2", "opt1", "val3", NULL };
|
|
gchar* keys[] = { "opt1", "opt2", "opt3", NULL };
|
|
|
|
gboolean res = TRUE;
|
|
|
|
GHashTable* options = parse_options(&args[2], keys, &res);
|
|
|
|
assert_null(options);
|
|
assert_false(res);
|
|
|
|
options_destroy(options);
|
|
}
|