Jabber Developer
9ec01fa8cc
All checks were successful
CI Code / Check spelling (push) Successful in 20s
CI Code / Check coding style (push) Successful in 36s
CI Code / Code Coverage (push) Successful in 5m38s
CI Code / Linux (ubuntu) (push) Successful in 7m1s
CI Code / Linux (debian) (push) Successful in 7m5s
CI Code / Linux (arch) (push) Successful in 7m19s
Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>
84 lines
2.9 KiB
C
84 lines
2.9 KiB
C
/*
|
|
* log.h
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
|
|
*
|
|
* This file is part of Profanity.
|
|
*
|
|
* Profanity is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Profanity is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Profanity. If not, see <https://www.gnu.org/licenses/>.
|
|
*
|
|
* In addition, as a special exception, the copyright holders give permission to
|
|
* link the code of portions of this program with the OpenSSL library under
|
|
* certain conditions as described in each individual source file, and
|
|
* distribute linked combinations including the two.
|
|
*
|
|
* You must obey the GNU General Public License in all respects for all of the
|
|
* code used other than OpenSSL. If you modify file(s) with this exception, you
|
|
* may extend this exception to your version of the file(s), but you are not
|
|
* obligated to do so. If you do not wish to do so, delete this exception
|
|
* statement from your version. If you delete this exception statement from all
|
|
* source files in the program, then also delete it here.
|
|
*
|
|
*/
|
|
|
|
#ifndef LOG_H
|
|
#define LOG_H
|
|
|
|
#include <glib.h>
|
|
|
|
#define PROF_TMPVAR__(n, l) n##l
|
|
#define PROF_TMPVAR_(n, l) PROF_TMPVAR__(n, l)
|
|
#define PROF_TMPVAR(n) PROF_TMPVAR_(PROF_##n##_, __LINE__)
|
|
|
|
// log levels
|
|
typedef enum {
|
|
PROF_LEVEL_DEBUG,
|
|
PROF_LEVEL_INFO,
|
|
PROF_LEVEL_WARN,
|
|
PROF_LEVEL_ERROR
|
|
} log_level_t;
|
|
|
|
void log_init(log_level_t filter, const char* const log_file);
|
|
log_level_t log_get_filter(void);
|
|
void log_close(void);
|
|
const gchar* get_log_file_location(void);
|
|
G_GNUC_PRINTF(1, 2)
|
|
void log_debug(const char* const msg, ...);
|
|
G_GNUC_PRINTF(1, 2)
|
|
void log_info(const char* const msg, ...);
|
|
G_GNUC_PRINTF(1, 2)
|
|
void log_warning(const char* const msg, ...);
|
|
G_GNUC_PRINTF(1, 2)
|
|
void log_error(const char* const msg, ...);
|
|
void log_msg(log_level_t level, const char* const area, const char* const msg);
|
|
int log_level_from_string(char* log_level, log_level_t* level);
|
|
const char* log_string_from_level(log_level_t level);
|
|
|
|
#define _log_Xtype_once(type, ...) \
|
|
do { \
|
|
static gboolean PROF_TMPVAR(once) = FALSE; \
|
|
if (!PROF_TMPVAR(once)) { \
|
|
log_##type(__VA_ARGS__); \
|
|
PROF_TMPVAR(once) = TRUE; \
|
|
} \
|
|
} while (0)
|
|
|
|
#define log_error_once(...) _log_Xtype_once(error, __VA_ARGS__)
|
|
|
|
void log_stderr_init(log_level_t level);
|
|
void log_stderr_handler(void);
|
|
|
|
#endif
|