jabber.developer2
250703a0bf
All checks were successful
CI Code / Check spelling (pull_request) Successful in 14s
CI Code / Check coding style (pull_request) Successful in 26s
CI Code / Code Coverage (pull_request) Successful in 3m29s
CI Code / Linux (debian) (pull_request) Successful in 5m13s
CI Code / Linux (ubuntu) (pull_request) Successful in 5m16s
CI Code / Linux (arch) (pull_request) Successful in 7m34s
T02: guard the receive-path handlers that dereferenced jid_create() without a NULL check — MUC join errors, subscribed/unsubscribed presence and, with silence.non-roster enabled, every incoming message. A stanza with a missing or malformed 'from' crashed the client (REQ-INP-01) T11: restrict /url open and /url save to http, https and aesgcm, so a received file:, javascript: or data: URL is refused (REQ-INP-06); spawn terminal-notifier through g_spawn_async with an argv instead of building a shell command for system() (REQ-INP-07); apply the XEP-0359 disco gate to MAM result ids, as live stanza-ids already do (REQ-INP-05); replace control and bidi-reordering characters in incoming message bodies with U+FFFD before they reach the terminal, the logs and the database, keeping LRM/RLM for legitimate RTL text (REQ-INP-08); cover JID part-length boundaries and invalid UTF-8 (REQ-INP-02) T10: replace strcpy/strcat/alloca and sprintf with g_strdup_printf and g_snprintf (REQ-MEM-03); allocate the OMEMO key buffers with g_malloc so a failed allocation cannot reach the following memcpy (REQ-MEM-04); remove the variable-length arrays and enforce -Werror=vla. Two of them were sized from remote input: the disco#info feature count and a chat message word length. The flag also caught a one-past-the-end write and a leak in the plugin autocompleter bindings (REQ-MEM-09)
342 lines
9.0 KiB
C
342 lines
9.0 KiB
C
#include <glib.h>
|
|
#include "prof_cmocka.h"
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include <stabber.h>
|
|
|
|
#include "proftest.h"
|
|
|
|
void
|
|
presence_online(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set online");
|
|
|
|
assert_true(prof_output_exact("Status set to online (priority 0), \"online\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<status>online</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_online_with_message(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set online \"Hi there\"");
|
|
|
|
assert_true(prof_output_exact("Status set to online (priority 0), \"Hi there\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<status>Hi there</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_away(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set away");
|
|
|
|
assert_true(prof_output_exact("Status set to away (priority 0), \"away\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>away</show>"
|
|
"<status>away</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_away_with_message(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set away \"I'm not here for a bit\"");
|
|
|
|
assert_true(prof_output_exact("Status set to away (priority 0), \"I'm not here for a bit\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>away</show>"
|
|
"<status>I'm not here for a bit</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_xa(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set xa");
|
|
|
|
assert_true(prof_output_exact("Status set to xa (priority 0), \"xa\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>xa</show>"
|
|
"<status>xa</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_xa_with_message(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set xa \"Gone to the shops\"");
|
|
|
|
assert_true(prof_output_exact("Status set to xa (priority 0), \"Gone to the shops\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>xa</show>"
|
|
"<status>Gone to the shops</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_dnd(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set dnd");
|
|
|
|
assert_true(prof_output_exact("Status set to dnd (priority 0), \"dnd\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>dnd</show>"
|
|
"<status>dnd</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_dnd_with_message(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set dnd \"Working\"");
|
|
|
|
assert_true(prof_output_exact("Status set to dnd (priority 0), \"Working\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>dnd</show>"
|
|
"<status>Working</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_chat(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set chat");
|
|
|
|
assert_true(prof_output_exact("Status set to chat (priority 0), \"chat\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>chat</show>"
|
|
"<status>chat</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_chat_with_message(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set chat \"Free to talk\"");
|
|
|
|
assert_true(prof_output_exact("Status set to chat (priority 0), \"Free to talk\"."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>chat</show>"
|
|
"<status>Free to talk</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_set_priority(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/priority 25");
|
|
|
|
assert_true(prof_output_exact("Priority set to 25."));
|
|
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<priority>25</priority>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_includes_priority(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/priority 25");
|
|
assert_true(prof_output_exact("Priority set to 25."));
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<priority>25</priority>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
|
|
prof_input("/status set chat \"Free to talk\"");
|
|
assert_true(prof_output_exact("Status set to chat (priority 25), \"Free to talk\"."));
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<priority>25</priority>"
|
|
"<show>chat</show>"
|
|
"<status>Free to talk</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_keeps_status(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
prof_input("/status set chat \"Free to talk\"");
|
|
assert_true(prof_output_exact("Status set to chat (priority 0), \"Free to talk\"."));
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>chat</show>"
|
|
"<status>Free to talk</status>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
|
|
prof_input("/priority 25");
|
|
assert_true(prof_output_exact("Priority set to 25."));
|
|
assert_true(stbbr_received(
|
|
"<presence id='*'>"
|
|
"<show>chat</show>"
|
|
"<status>Free to talk</status>"
|
|
"<priority>25</priority>"
|
|
"<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' ver='*' node='*'/>"
|
|
"</presence>"
|
|
));
|
|
}
|
|
|
|
void
|
|
presence_received(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
stbbr_send(
|
|
"<presence to='stabber@localhost' from='buddy1@localhost/mobile'>"
|
|
"<priority>10</priority>"
|
|
"<status>I'm here</status>"
|
|
"</presence>"
|
|
);
|
|
|
|
assert_true(prof_output_exact("Buddy1 (mobile) is online, \"I'm here\""));
|
|
}
|
|
|
|
// Typical use case for gateways that don't support resources
|
|
void
|
|
presence_missing_resource_defaults(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
stbbr_send(
|
|
"<presence to='stabber@localhost' from='buddy1@localhost'>"
|
|
"<priority>15</priority>"
|
|
"<status>My status</status>"
|
|
"</presence>"
|
|
);
|
|
|
|
assert_true(prof_output_exact("Buddy1 is online, \"My status\""));
|
|
|
|
prof_input("/info Buddy1");
|
|
|
|
assert_true(prof_output_exact("__prof_default (15), online"));
|
|
}
|
|
|
|
/* Regression tests for issue #148 (REQ-INP-01): presence handlers used to
|
|
* dereference jid_create() results without a NULL check, so a stanza with a
|
|
* missing or invalid 'from' crashed the client. */
|
|
void
|
|
presence_error_invalid_from_no_crash(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
/* MUC join error with an invalid 'from' */
|
|
stbbr_send(
|
|
"<presence to='stabber@localhost' from='bad@@room' type='error'>"
|
|
"<x xmlns='http://jabber.org/protocol/muc'/>"
|
|
"<error type='cancel'><not-allowed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/></error>"
|
|
"</presence>"
|
|
);
|
|
|
|
/* same, with no 'from' at all */
|
|
stbbr_send(
|
|
"<presence to='stabber@localhost' type='error'>"
|
|
"<x xmlns='http://jabber.org/protocol/muc'/>"
|
|
"<error type='cancel'><not-allowed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/></error>"
|
|
"</presence>"
|
|
);
|
|
|
|
/* client is still alive and processing stanzas */
|
|
stbbr_send(
|
|
"<presence to='stabber@localhost' from='buddy1@localhost/mobile'>"
|
|
"<status>still alive</status>"
|
|
"</presence>"
|
|
);
|
|
assert_true(prof_output_exact("Buddy1 (mobile) is online, \"still alive\""));
|
|
}
|
|
|
|
void
|
|
presence_subscription_invalid_from_no_crash(void **state)
|
|
{
|
|
prof_connect();
|
|
|
|
stbbr_send("<presence to='stabber@localhost' from='bad@@jid' type='subscribed'/>");
|
|
stbbr_send("<presence to='stabber@localhost' from='bad@@jid' type='unsubscribed'/>");
|
|
stbbr_send("<presence to='stabber@localhost' from='bad@@jid' type='subscribe'/>");
|
|
|
|
stbbr_send(
|
|
"<presence to='stabber@localhost' from='buddy1@localhost/mobile'>"
|
|
"<status>still alive</status>"
|
|
"</presence>"
|
|
);
|
|
assert_true(prof_output_exact("Buddy1 (mobile) is online, \"still alive\""));
|
|
}
|