Jabber Developer
72f4f186da
All checks were successful
CI Code / Check spelling (push) Successful in 18s
CI Code / Check coding style (push) Successful in 34s
CI Code / Code Coverage (push) Successful in 2m36s
CI Code / Linux (debian) (push) Successful in 4m41s
CI Code / Linux (ubuntu) (push) Successful in 4m52s
CI Code / Linux (arch) (push) Successful in 5m40s
Sync with upstream profanity-im/profanity.
Major upstream changes incorporated:
Memory management
- Replace malloc+memset with g_new0 throughout codebase
- Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
- Replace free() with g_free() for GAlloc'd memory
Editor rewrite
- Remove pthread-based async editor; use GChildWatch callback API
- New launch_editor(initial_content, callback, user_data) interface
- Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
- ui_suspend()/ui_resume() integration for TTY management
OMEMO improvements
- Dual backend support: libsignal-protocol-c and libomemo-c
- Proper pre-key removal after use (XEP-0384 compliance)
- Automatic pre-key regeneration when store drops below threshold
- New functions: omemo_is_device_active(), omemo_is_jid_trusted()
- omemo_get_jid_untrusted_fingerprints() for better error messages
- Fingerprint notifications on new device identity discovery
- Deterministic pre-key ID generation tracking max_pre_key_id
- omemo_trust_changed() UI updates on trust state changes
JID validation
- RFC 6122-compliant validation in jid_is_valid()
- Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
- Length limits: 1023 per component, 3071 total
- New jid_is_valid_user_jid() for user vs. service JID distinction
Database
- Schema migration v3: UNIQUE constraint on archive_id for deduplication
- Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
- db_history_result_t return type, _truncate_datetime_suffix()
UI / console
- win_warn_needed() / win_warn_sent() warning deduplication hash table
- PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
- Spellcheck integration in input field with Unicode word detection
- cons_spellcheck_setting() for /settings ui output
- /[command]? shortcut for command help
Account config
- Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
- Replace popen() with g_spawn_sync() for eval_password
- TLS policy: add "direct" option alongside legacy
Connection
- Port validation with g_assert (0–65535)
- SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
- "direct" TLS policy alias for legacy SSL
Common utilities
- str_xml_sanitize() for XML 1.0 illegal character removal
- string_matches_one_of() with formatted error messages
- valid_tls_policy_option() helper
- prof_date_time_format_iso8601() utility
- Improved strip_arg_quotes() with backslash unescaping
- prof_occurrences() uses g_slist_prepend + reverse for performance
PGP / OX
- Proper GPGME resource cleanup with goto-cleanup pattern
- g_string_free(xmppuri) leak fix in _ox_key_lookup
CSV export
- Use GString + g_file_set_contents instead of raw write() syscalls
Tests
- Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
- New test_cmd_ac.c for autocompleter unit tests
- Updated stubs for new UI suspend/resume functions
License headers
- Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)
────────────────────────────────────────────────────
cproof-specific preservations:
- XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
- Force encryption: cmd_force_encryption, test_forced_encryption
- CWE-134: format string protection (cons_show("%s", ...))
- y_start_pos-based paging in window.c
- db_history_result_t return type, _truncate_datetime_suffix()
Merge-time fixes:
- common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
- database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
- console.c: implicit size_t → int cast — (int)(maxlen + 1)
- tlscerts.c: %d for size_t — %zu
Build system:
- Kept autotools (Makefile.am, configure.ac); upstream uses Meson
- Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
- Updated Makefile.am test paths for subdirectory structure
- Added test_cmd_ac, test_forced_encryption to test sources
Functional tests:
- Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
- Not yet available in devs/stabber fork
Closes #64
Merge author: jabber.developer2
Commits authors:
Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
85 lines
3.6 KiB
C
85 lines
3.6 KiB
C
/*
|
|
* omemo.h
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2019 Paul Fariello <paul@fariello.eu>
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
|
|
*/
|
|
#include <glib.h>
|
|
#include <gcrypt.h>
|
|
|
|
#include "ui/ui.h"
|
|
#include "config/account.h"
|
|
|
|
#define OMEMO_ERR_UNSUPPORTED_CRYPTO -10000
|
|
#define OMEMO_ERR_GCRYPT -20000
|
|
|
|
#define OMEMO_AESGCM_NONCE_LENGTH AES128_GCM_IV_LENGTH
|
|
#define OMEMO_AESGCM_KEY_LENGTH 32
|
|
#define OMEMO_AESGCM_URL_SCHEME "aesgcm"
|
|
|
|
typedef enum {
|
|
PROF_OMEMOPOLICY_MANUAL,
|
|
PROF_OMEMOPOLICY_AUTOMATIC,
|
|
PROF_OMEMOPOLICY_ALWAYS
|
|
} prof_omemopolicy_t;
|
|
|
|
typedef struct omemo_key
|
|
{
|
|
unsigned char* data;
|
|
size_t length;
|
|
gboolean prekey;
|
|
uint32_t device_id;
|
|
uint32_t id;
|
|
} omemo_key_t;
|
|
|
|
void omemo_init(void);
|
|
void omemo_on_connect(ProfAccount* account);
|
|
void omemo_on_disconnect(void);
|
|
void omemo_generate_crypto_materials(ProfAccount* account);
|
|
void omemo_key_free(omemo_key_t* key);
|
|
void omemo_publish_crypto_materials(void);
|
|
|
|
uint32_t omemo_device_id(void);
|
|
void omemo_identity_key(unsigned char** output, size_t* length);
|
|
void omemo_signed_prekey(unsigned char** output, size_t* length);
|
|
void omemo_signed_prekey_signature(unsigned char** output, size_t* length);
|
|
void omemo_prekeys(GList** prekeys, GList** ids, GList** lengths);
|
|
void omemo_set_device_list(const char* const jid, GList* device_list);
|
|
GKeyFile* omemo_identity_keyfile(void);
|
|
void omemo_identity_keyfile_save(void);
|
|
GKeyFile* omemo_trust_keyfile(void);
|
|
void omemo_trust_keyfile_save(void);
|
|
GKeyFile* omemo_sessions_keyfile(void);
|
|
void omemo_sessions_keyfile_save(void);
|
|
char* omemo_format_fingerprint(const char* const fingerprint);
|
|
char* omemo_own_fingerprint(gboolean formatted);
|
|
void omemo_trust(const char* const jid, const char* const fingerprint);
|
|
void omemo_untrust(const char* const jid, const char* const fingerprint);
|
|
GList* omemo_known_device_identities(const char* const jid);
|
|
gboolean omemo_is_trusted_identity(const char* const jid, const char* const fingerprint);
|
|
gboolean omemo_is_jid_trusted(const char* const jid);
|
|
GList* omemo_get_jid_untrusted_fingerprints(const char* const jid);
|
|
gboolean omemo_is_device_active(const char* const jid, const char* const fingerprint);
|
|
char* omemo_fingerprint_autocomplete(const char* const search_str, gboolean previous, void* context);
|
|
void omemo_fingerprint_autocomplete_reset(void);
|
|
gboolean omemo_automatic_start(const char* const recipient);
|
|
|
|
void omemo_start_sessions(void);
|
|
void omemo_start_session(const char* const barejid);
|
|
void omemo_start_muc_sessions(const char* const roomjid);
|
|
void omemo_start_device_session(const char* const jid, uint32_t device_id, GList* prekeys, uint32_t signed_prekey_id, const unsigned char* const signed_prekey, size_t signed_prekey_len, const unsigned char* const signature, size_t signature_len, const unsigned char* const identity_key, size_t identity_key_len);
|
|
|
|
gboolean omemo_loaded(void);
|
|
|
|
char* omemo_on_message_send(ProfWin* win, const char* const message, gboolean request_receipt, gboolean muc, const char* const replace_id);
|
|
char* omemo_on_message_recv(const char* const from, uint32_t sid, const unsigned char* const iv, size_t iv_len, GList* keys, const unsigned char* const payload, size_t payload_len, gboolean muc, gboolean* trusted, omemo_error_t* error) __attribute__((nonnull(9, 10)));
|
|
|
|
char* omemo_encrypt_file(FILE* in, FILE* out, off_t file_size, int* gcry_res);
|
|
gcry_error_t omemo_decrypt_file(FILE* in, FILE* out, off_t file_size, const char* fragment);
|
|
void omemo_free(void* a);
|
|
int omemo_parse_aesgcm_url(const char* aesgcm_url, char** https_url, char** fragment);
|
|
|
|
char* omemo_qrcode_str();
|