e9c6b3b3d8
Autocompletion failed for nicknames using non Latin scripts. We used `g_str_to_ascii`, which replaces characters it cannot transliterate with '?', leading search failures and false matches between different scripts. Now we do: Use `g_utf8_casefold` for case-insensitive UTF-8 comparison. This ensures that like 'Σ' correctly match 'σ' across all Unicode scripts, providing correct results for non English nicknames. If we don't fine anything typing a base ASCII character matches an accented one (typing `e` matches `è`). This pass uses `g_str_to_ascii` followed by `g_ascii_strdown` for comparison. It is now restricted to run if the search string itself is valid ASCII, preventing the "everything matches '?'" bug in non Latin scripts. Autocomplete items are sorted using `strcmp`. `g_utf8_collate` provides linguistical ordering for a specific language. But its behavior is locale dependent and undefined when comparing strings from different scripts. `strcmp` does byte-wise ordering that correctly follows Unicode code order for UTF-8 strings.
743 lines
23 KiB
C
743 lines
23 KiB
C
#include <glib.h>
|
|
#include <string.h>
|
|
#include "prof_cmocka.h"
|
|
#include <stdlib.h>
|
|
|
|
#include "xmpp/contact.h"
|
|
#include "xmpp/roster_list.h"
|
|
|
|
void
|
|
roster_get_contacts__returns__empty_list_when_none_added(void** state)
|
|
{
|
|
roster_create();
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
assert_null(list);
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_contacts__returns__one_element(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
assert_int_equal(1, g_slist_length(list));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_contacts__returns__correct_first_element(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
PContact james = list->data;
|
|
|
|
assert_string_equal("James", p_contact_barejid(james));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_contacts__returns__two_elements(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
|
|
assert_int_equal(2, g_slist_length(list));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_contacts__returns__correct_first_and_second_elements(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
|
|
PContact first = list->data;
|
|
PContact second = (g_slist_next(list))->data;
|
|
|
|
assert_string_equal("Dave", p_contact_barejid(first));
|
|
assert_string_equal("James", p_contact_barejid(second));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_contacts__returns__three_elements(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
|
|
assert_int_equal(3, g_slist_length(list));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_contacts__returns__correct_first_three_elements(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
PContact bob = list->data;
|
|
PContact dave = (g_slist_next(list))->data;
|
|
PContact james = (g_slist_next(g_slist_next(list)))->data;
|
|
|
|
assert_string_equal("James", p_contact_barejid(james));
|
|
assert_string_equal("Dave", p_contact_barejid(dave));
|
|
assert_string_equal("Bob", p_contact_barejid(bob));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_add__updates__adds_once_when_called_twice_at_beginning(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
PContact first = list->data;
|
|
PContact second = (g_slist_next(list))->data;
|
|
PContact third = (g_slist_next(g_slist_next(list)))->data;
|
|
|
|
assert_int_equal(3, g_slist_length(list));
|
|
assert_string_equal("Bob", p_contact_barejid(first));
|
|
assert_string_equal("Dave", p_contact_barejid(second));
|
|
assert_string_equal("James", p_contact_barejid(third));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_add__updates__adds_once_when_called_twice_in_middle(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
PContact first = list->data;
|
|
PContact second = (g_slist_next(list))->data;
|
|
PContact third = (g_slist_next(g_slist_next(list)))->data;
|
|
|
|
assert_int_equal(3, g_slist_length(list));
|
|
assert_string_equal("Bob", p_contact_barejid(first));
|
|
assert_string_equal("Dave", p_contact_barejid(second));
|
|
assert_string_equal("James", p_contact_barejid(third));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_add__updates__adds_once_when_called_twice_at_end(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
GSList* list = roster_get_contacts(ROSTER_ORD_NAME);
|
|
PContact first = list->data;
|
|
PContact second = (g_slist_next(list))->data;
|
|
PContact third = (g_slist_next(g_slist_next(list)))->data;
|
|
|
|
assert_int_equal(3, g_slist_length(list));
|
|
assert_string_equal("Bob", p_contact_barejid(first));
|
|
assert_string_equal("Dave", p_contact_barejid(second));
|
|
assert_string_equal("James", p_contact_barejid(third));
|
|
|
|
g_slist_free(list);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__first_exists(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
|
|
char* search = g_strdup("B");
|
|
|
|
char* result = roster_contact_autocomplete(search, FALSE, NULL);
|
|
assert_string_equal("Bob", result);
|
|
g_free(result);
|
|
g_free(search);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__second_exists(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
|
|
char* result = roster_contact_autocomplete("Dav", FALSE, NULL);
|
|
assert_string_equal("Dave", result);
|
|
g_free(result);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__third_exists(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
|
|
char* result = roster_contact_autocomplete("Ja", FALSE, NULL);
|
|
assert_string_equal("James", result);
|
|
g_free(result);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__null_when_no_match(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
|
|
char* result = roster_contact_autocomplete("Mike", FALSE, NULL);
|
|
assert_null(result);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__null_on_empty_roster(void** state)
|
|
{
|
|
roster_create();
|
|
char* result = roster_contact_autocomplete("James", FALSE, NULL);
|
|
assert_null(result);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__second_when_two_match(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamie", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
|
|
char* result1 = roster_contact_autocomplete("Jam", FALSE, NULL);
|
|
char* result2 = roster_contact_autocomplete(result1, FALSE, NULL);
|
|
assert_string_equal("Jamie", result2);
|
|
g_free(result1);
|
|
g_free(result2);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__fifth_when_multiple_match(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("Jama", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamb", NULL, NULL, NULL, FALSE);
|
|
roster_add("Mike", NULL, NULL, NULL, FALSE);
|
|
roster_add("Dave", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamm", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamn", NULL, NULL, NULL, FALSE);
|
|
roster_add("Matt", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamo", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamy", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamz", NULL, NULL, NULL, FALSE);
|
|
|
|
char* result1 = roster_contact_autocomplete("Jam", FALSE, NULL);
|
|
char* result2 = roster_contact_autocomplete(result1, FALSE, NULL);
|
|
char* result3 = roster_contact_autocomplete(result2, FALSE, NULL);
|
|
char* result4 = roster_contact_autocomplete(result3, FALSE, NULL);
|
|
char* result5 = roster_contact_autocomplete(result4, FALSE, NULL);
|
|
assert_string_equal("Jamo", result5);
|
|
g_free(result1);
|
|
g_free(result2);
|
|
g_free(result3);
|
|
g_free(result4);
|
|
g_free(result5);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__first_when_two_match_and_reset(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("James", NULL, NULL, NULL, FALSE);
|
|
roster_add("Jamie", NULL, NULL, NULL, FALSE);
|
|
roster_add("Bob", NULL, NULL, NULL, FALSE);
|
|
|
|
char* result1 = roster_contact_autocomplete("Jam", FALSE, NULL);
|
|
roster_reset_search_attempts();
|
|
char* result2 = roster_contact_autocomplete(result1, FALSE, NULL);
|
|
assert_string_equal("James", result2);
|
|
g_free(result1);
|
|
g_free(result2);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_contact_autocomplete__returns__utf8(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("Σωκράτης", NULL, NULL, NULL, FALSE);
|
|
roster_add("Πλάτων", NULL, NULL, NULL, FALSE);
|
|
|
|
// Byte-wise (strcmp): Πλάτων (CE A0...) < Σωκράτης (CE A3...)
|
|
char* result = roster_contact_autocomplete("Π", FALSE, NULL);
|
|
assert_string_equal("Πλάτων", result);
|
|
g_free(result);
|
|
|
|
roster_reset_search_attempts();
|
|
|
|
result = roster_contact_autocomplete("σω", FALSE, NULL);
|
|
assert_string_equal("Σωκράτης", result);
|
|
g_free(result);
|
|
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_groups__returns__empty_for_no_group(void** state)
|
|
|
|
{
|
|
roster_create();
|
|
roster_add("person@server.org", NULL, NULL, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 0);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_groups__returns__one_group(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups = NULL;
|
|
groups = g_slist_append(groups, g_strdup("friends"));
|
|
roster_add("person@server.org", NULL, groups, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 1);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "friends");
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_groups__returns__two_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups = NULL;
|
|
groups = g_slist_append(groups, g_strdup("friends"));
|
|
groups = g_slist_append(groups, g_strdup("work"));
|
|
roster_add("person@server.org", NULL, groups, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 2);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "friends");
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "work");
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_groups__returns__three_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups = NULL;
|
|
groups = g_slist_append(groups, g_strdup("friends"));
|
|
groups = g_slist_append(groups, g_strdup("work"));
|
|
groups = g_slist_append(groups, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 3);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "friends");
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "work");
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "stuff");
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_update__updates__adding_two_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("friends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("work"));
|
|
groups2 = g_slist_append(groups2, g_strdup("stuff"));
|
|
groups2 = g_slist_append(groups2, g_strdup("things"));
|
|
groups2 = g_slist_append(groups2, g_strdup("people"));
|
|
roster_update("person@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 5);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "friends");
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "work");
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "stuff");
|
|
found = g_list_find_custom(groups_res, "things", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "things");
|
|
found = g_list_find_custom(groups_res, "people", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "people");
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_update__updates__removing_one_group(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("friends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("stuff"));
|
|
roster_update("person@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 2);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "friends");
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "stuff");
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_update__updates__removing_two_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("stuff"));
|
|
roster_update("person@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 1);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
assert_string_equal(found->data, "stuff");
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_update__updates__removing_three_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
roster_update("person@server.org", NULL, NULL, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 0);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_update__updates__two_new_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("newfriends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("somepeople"));
|
|
roster_update("person@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 2);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "newfriends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "somepeople", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_remove__updates__contact_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
roster_remove("person@server.org", "person@server.org");
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 0);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_add__updates__different_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("newfriends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("somepeople"));
|
|
roster_add("bob@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 5);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "newfriends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "somepeople", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_add__updates__same_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("friends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("work"));
|
|
groups2 = g_slist_append(groups2, g_strdup("stuff"));
|
|
roster_add("bob@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 3);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_add__updates__overlapping_groups(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("friends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("work"));
|
|
groups2 = g_slist_append(groups2, g_strdup("different"));
|
|
roster_add("bob@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 4);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "different", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_remove__updates__remaining_in_group(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
GSList* groups1 = NULL;
|
|
groups1 = g_slist_append(groups1, g_strdup("friends"));
|
|
groups1 = g_slist_append(groups1, g_strdup("work"));
|
|
groups1 = g_slist_append(groups1, g_strdup("stuff"));
|
|
roster_add("person@server.org", NULL, groups1, NULL, FALSE);
|
|
|
|
GSList* groups2 = NULL;
|
|
groups2 = g_slist_append(groups2, g_strdup("friends"));
|
|
groups2 = g_slist_append(groups2, g_strdup("work"));
|
|
groups2 = g_slist_append(groups2, g_strdup("different"));
|
|
roster_add("bob@server.org", NULL, groups2, NULL, FALSE);
|
|
|
|
roster_remove("bob@server.org", "bob@server.org");
|
|
|
|
GList* groups_res = roster_get_groups();
|
|
assert_int_equal(g_list_length(groups_res), 3);
|
|
|
|
GList* found = g_list_find_custom(groups_res, "friends", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "work", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
found = g_list_find_custom(groups_res, "stuff", (GCompareFunc)g_strcmp0);
|
|
assert_true(found != NULL);
|
|
|
|
g_list_free_full(groups_res, g_free);
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_display_name__returns__nickname_when_exists(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("person@server.org", "nickname", NULL, NULL, FALSE);
|
|
|
|
assert_string_equal("nickname", roster_get_display_name("person@server.org"));
|
|
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_display_name__returns__barejid_when_nickname_empty(void** state)
|
|
{
|
|
roster_create();
|
|
roster_add("person@server.org", NULL, NULL, NULL, FALSE);
|
|
|
|
assert_string_equal("person@server.org", roster_get_display_name("person@server.org"));
|
|
|
|
roster_destroy();
|
|
}
|
|
|
|
void
|
|
roster_get_display_name__returns__barejid_when_not_exists(void** state)
|
|
{
|
|
roster_create();
|
|
|
|
assert_string_equal("person@server.org", roster_get_display_name("person@server.org"));
|
|
|
|
roster_destroy();
|
|
}
|