All checks were successful
CI Code / Check spelling (push) Successful in 18s
CI Code / Check coding style (push) Successful in 34s
CI Code / Code Coverage (push) Successful in 2m36s
CI Code / Linux (debian) (push) Successful in 4m41s
CI Code / Linux (ubuntu) (push) Successful in 4m52s
CI Code / Linux (arch) (push) Successful in 5m40s
Sync with upstream profanity-im/profanity.
Major upstream changes incorporated:
Memory management
- Replace malloc+memset with g_new0 throughout codebase
- Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
- Replace free() with g_free() for GAlloc'd memory
Editor rewrite
- Remove pthread-based async editor; use GChildWatch callback API
- New launch_editor(initial_content, callback, user_data) interface
- Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
- ui_suspend()/ui_resume() integration for TTY management
OMEMO improvements
- Dual backend support: libsignal-protocol-c and libomemo-c
- Proper pre-key removal after use (XEP-0384 compliance)
- Automatic pre-key regeneration when store drops below threshold
- New functions: omemo_is_device_active(), omemo_is_jid_trusted()
- omemo_get_jid_untrusted_fingerprints() for better error messages
- Fingerprint notifications on new device identity discovery
- Deterministic pre-key ID generation tracking max_pre_key_id
- omemo_trust_changed() UI updates on trust state changes
JID validation
- RFC 6122-compliant validation in jid_is_valid()
- Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
- Length limits: 1023 per component, 3071 total
- New jid_is_valid_user_jid() for user vs. service JID distinction
Database
- Schema migration v3: UNIQUE constraint on archive_id for deduplication
- Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
- db_history_result_t return type, _truncate_datetime_suffix()
UI / console
- win_warn_needed() / win_warn_sent() warning deduplication hash table
- PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
- Spellcheck integration in input field with Unicode word detection
- cons_spellcheck_setting() for /settings ui output
- /[command]? shortcut for command help
Account config
- Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
- Replace popen() with g_spawn_sync() for eval_password
- TLS policy: add "direct" option alongside legacy
Connection
- Port validation with g_assert (0–65535)
- SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
- "direct" TLS policy alias for legacy SSL
Common utilities
- str_xml_sanitize() for XML 1.0 illegal character removal
- string_matches_one_of() with formatted error messages
- valid_tls_policy_option() helper
- prof_date_time_format_iso8601() utility
- Improved strip_arg_quotes() with backslash unescaping
- prof_occurrences() uses g_slist_prepend + reverse for performance
PGP / OX
- Proper GPGME resource cleanup with goto-cleanup pattern
- g_string_free(xmppuri) leak fix in _ox_key_lookup
CSV export
- Use GString + g_file_set_contents instead of raw write() syscalls
Tests
- Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
- New test_cmd_ac.c for autocompleter unit tests
- Updated stubs for new UI suspend/resume functions
License headers
- Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)
────────────────────────────────────────────────────
cproof-specific preservations:
- XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
- Force encryption: cmd_force_encryption, test_forced_encryption
- CWE-134: format string protection (cons_show("%s", ...))
- y_start_pos-based paging in window.c
- db_history_result_t return type, _truncate_datetime_suffix()
Merge-time fixes:
- common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
- database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
- console.c: implicit size_t → int cast — (int)(maxlen + 1)
- tlscerts.c: %d for size_t — %zu
Build system:
- Kept autotools (Makefile.am, configure.ac); upstream uses Meson
- Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
- Updated Makefile.am test paths for subdirectory structure
- Added test_cmd_ac, test_forced_encryption to test sources
Functional tests:
- Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
- Not yet available in devs/stabber fork
Closes #64
Merge author: jabber.developer2
Commits authors:
Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
197 lines
5.4 KiB
C
197 lines
5.4 KiB
C
/*
|
|
* common.h
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
|
|
*/
|
|
|
|
#ifndef COMMON_H
|
|
#define COMMON_H
|
|
|
|
#include <stdio.h>
|
|
#include <wchar.h>
|
|
|
|
#include <glib.h>
|
|
|
|
#ifndef NOTIFY_CHECK_VERSION
|
|
#define notify_notification_new(summary, body, icon) notify_notification_new(summary, body, icon, NULL)
|
|
#endif
|
|
|
|
#define ARRAY_SIZE(x) (sizeof(x) / sizeof(x[0]))
|
|
|
|
#define PROF_STRINGIFY_(n) #n
|
|
#define PROF_STRINGIFY(n) PROF_STRINGIFY_(n)
|
|
|
|
void auto_free_gchar(gchar** str);
|
|
|
|
/**
|
|
* Macro for automatically freeing a gchar* string when it goes out of scope.
|
|
*
|
|
* Example usage:
|
|
* ```
|
|
* auto_gchar gchar* myString = g_strdup("Hello, world!");
|
|
* ```
|
|
*/
|
|
#define auto_gchar __attribute__((__cleanup__(auto_free_gchar)))
|
|
|
|
void auto_free_gcharv(gchar*** args);
|
|
|
|
/**
|
|
* Macro for automatically freeing a gchar** string array when it goes out of scope.
|
|
*
|
|
* Example usage:
|
|
* ```
|
|
* auto_gcharv gchar** stringArray = g_strsplit("Hello, world!", " ", -1);
|
|
* ```
|
|
*/
|
|
#define auto_gcharv __attribute__((__cleanup__(auto_free_gcharv)))
|
|
|
|
void auto_free_char(char** str);
|
|
|
|
/**
|
|
* Macro for automatically freeing a char* string when it goes out of scope.
|
|
*
|
|
* Example usage:
|
|
* ```
|
|
* auto_char char* myString = strdup("Hello, world!");
|
|
* ```
|
|
*/
|
|
#define auto_char __attribute__((__cleanup__(auto_free_char)))
|
|
|
|
void auto_free_guchar(guchar** str);
|
|
|
|
/**
|
|
* @brief Macro for automatically freeing a guchar* string when it goes out of scope.
|
|
*
|
|
* This macro is used to automatically free a guchar* string when it goes out of scope.
|
|
* It utilizes the `auto_free_guchar` function and should be placed before the variable declaration.
|
|
*
|
|
* Example usage:
|
|
* ```
|
|
* auto_guchar guchar* myString = g_base64_decode("SGVsbG8sIHdvcmxkIQ==", NULL);
|
|
* ```
|
|
*/
|
|
#define auto_guchar __attribute__((__cleanup__(auto_free_guchar)))
|
|
|
|
#define auto_gfd __attribute__((__cleanup__(auto_close_gfd)))
|
|
|
|
void auto_close_gfd(gint* fd);
|
|
|
|
#define auto_FILE __attribute__((__cleanup__(auto_close_FILE)))
|
|
|
|
void auto_close_FILE(FILE** fd);
|
|
|
|
void auto_free_gerror(GError** err);
|
|
#define auto_gerror __attribute__((__cleanup__(auto_free_gerror)))
|
|
|
|
#if defined(__OpenBSD__)
|
|
#define STR_MAYBE_NULL(p) (p) ?: "(null)"
|
|
#else
|
|
#define STR_MAYBE_NULL(p) (p)
|
|
#endif
|
|
|
|
#define PROF_GERROR_MESSAGE(err) (err) ? (err)->message : "error message missing"
|
|
#define PROF_GERROR_FREE(err) \
|
|
do { \
|
|
if (err) \
|
|
g_error_free(err); \
|
|
} while (0)
|
|
|
|
typedef struct prof_keyfile_t
|
|
{
|
|
gchar* filename;
|
|
GKeyFile* keyfile;
|
|
} prof_keyfile_t;
|
|
|
|
gboolean
|
|
load_data_keyfile(prof_keyfile_t* keyfile, const char* filename);
|
|
gboolean
|
|
load_config_keyfile(prof_keyfile_t* keyfile, const char* filename);
|
|
gboolean
|
|
load_custom_keyfile(prof_keyfile_t* keyfile, gchar* filename);
|
|
gboolean
|
|
save_keyfile(prof_keyfile_t* keyfile);
|
|
void
|
|
free_keyfile(prof_keyfile_t* keyfile);
|
|
|
|
/* Our own define of MB_CUR_MAX but this time at compile time */
|
|
#define PROF_MB_CUR_MAX 8
|
|
|
|
// assume malloc stores at most 8 bytes for size of allocated memory
|
|
// and page size is at least 4KB
|
|
#define READ_BUF_SIZE 4088
|
|
|
|
#define FREE_SET_NULL(resource) \
|
|
do { \
|
|
free(resource); \
|
|
resource = NULL; \
|
|
} while (0)
|
|
|
|
#define GFREE_SET_NULL(resource) \
|
|
do { \
|
|
g_free(resource); \
|
|
resource = NULL; \
|
|
} while (0)
|
|
|
|
typedef enum {
|
|
CONTACT_OFFLINE,
|
|
CONTACT_ONLINE,
|
|
CONTACT_AWAY,
|
|
CONTACT_DND,
|
|
CONTACT_CHAT,
|
|
CONTACT_XA
|
|
} contact_presence_t;
|
|
|
|
typedef enum {
|
|
RESOURCE_ONLINE,
|
|
RESOURCE_AWAY,
|
|
RESOURCE_DND,
|
|
RESOURCE_CHAT,
|
|
RESOURCE_XA
|
|
} resource_presence_t;
|
|
|
|
gboolean string_to_verbosity(const char* cmd, int* verbosity, gchar** err_msg);
|
|
|
|
gboolean create_dir(const char* name);
|
|
gboolean copy_file(const char* const src, const char* const target, const gboolean overwrite_existing);
|
|
char* str_replace(const char* string, const char* substr, const char* replacement);
|
|
gboolean strtoi_range(const char* str, int* saveptr, int min, int max, char** err_msg);
|
|
int utf8_display_len(const char* const str);
|
|
gchar* str_xml_sanitize(const char* const str);
|
|
|
|
gboolean string_matches_one_of(const char* what, const char* is, gboolean is_can_be_null, const char* first, ...) __attribute__((sentinel));
|
|
gboolean valid_tls_policy_option(const char* is);
|
|
|
|
char* release_get_latest(void);
|
|
gboolean release_is_new(const char* const curr_version, const char* const found_version);
|
|
|
|
char* strip_arg_quotes(const char* const input);
|
|
gboolean is_notify_enabled(void);
|
|
|
|
GSList* prof_occurrences(const char* const needle, const char* const haystack, int offset, gboolean whole_word,
|
|
GSList** result);
|
|
GSList* get_mentions(gboolean whole_word, gboolean case_sensitive, const char* const message, const char* const nick);
|
|
|
|
int is_regular_file(const char* path);
|
|
int is_dir(const char* path);
|
|
void get_file_paths_recursive(const char* directory, GSList** contents);
|
|
|
|
gchar* get_random_string(int length);
|
|
|
|
gboolean call_external(gchar** argv);
|
|
gchar** format_call_external_argv(const char* template, const char* url, const char* filename);
|
|
|
|
gchar* unique_filename_from_url(const char* url, const char* path);
|
|
gchar* get_expanded_path(const char* path);
|
|
|
|
char* basename_from_url(const char* url);
|
|
|
|
gchar* prof_date_time_format_iso8601(GDateTime* dt);
|
|
|
|
gchar* prof_get_version(void);
|
|
void prof_add_shutdown_routine(void (*routine)(void));
|
|
|
|
#endif
|