Added null check for jidp in cmd_sub to handle jid_create returning NULL. Crash occurred when processing malformed JID inputs like @example.com. Ensures robust handling of invalid JIDs. Fixes #22
56 lines
1.2 KiB
C
56 lines
1.2 KiB
C
#include <stdarg.h>
|
|
#include <stddef.h>
|
|
#include <setjmp.h>
|
|
#include <cmocka.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <glib.h>
|
|
|
|
#include "xmpp/xmpp.h"
|
|
|
|
#include "ui/ui.h"
|
|
#include "ui/stub_ui.h"
|
|
|
|
#include "command/cmd_funcs.h"
|
|
|
|
#define CMD_SUB "/sub"
|
|
|
|
void
|
|
cmd_sub_shows_message_when_not_connected(void** state)
|
|
{
|
|
gchar* args[] = { NULL };
|
|
|
|
will_return(connection_get_status, JABBER_DISCONNECTED);
|
|
|
|
expect_cons_show("You are currently not connected.");
|
|
|
|
gboolean result = cmd_sub(NULL, CMD_SUB, args);
|
|
assert_true(result);
|
|
}
|
|
|
|
void
|
|
cmd_sub_shows_usage_when_no_arg(void** state)
|
|
{
|
|
gchar* args[] = { NULL };
|
|
|
|
will_return(connection_get_status, JABBER_CONNECTED);
|
|
|
|
expect_string(cons_bad_cmd_usage, cmd, CMD_SUB);
|
|
|
|
gboolean result = cmd_sub(NULL, CMD_SUB, args);
|
|
assert_true(result);
|
|
}
|
|
|
|
void
|
|
test_cmd_sub_malformed_jid(void** state)
|
|
{
|
|
ProfWin win;
|
|
win.type = WIN_CONSOLE;
|
|
gchar* args[] = { "request", "@example.com" };
|
|
|
|
will_return(connection_get_status, JABBER_CONNECTED);
|
|
|
|
expect_cons_show("Malformed JID: @example.com");
|
|
gboolean result = cmd_sub((ProfWin*)&win, CMD_SUB, args);
|
|
assert_true(result);
|
|
} |