jabber.developer2
3fccc046b0
Some checks failed
CI Code / Check spelling (pull_request) Successful in 21s
CI Code / Check coding style (pull_request) Successful in 35s
CI Code / Linux (debian) (pull_request) Failing after 3m49s
CI Code / Linux (ubuntu) (pull_request) Failing after 4m5s
CI Code / Linux (arch) (pull_request) Failing after 4m46s
CI Code / Code Coverage (pull_request) Failing after 5m54s
Adds 10 tests for ai_models_find and additional edge cases on
ai_providers_find. 5 pass as sanity; 5 fail intentionally, documenting
two distinct bugs in the autocomplete integration:
BUG A — ai_models_find cycling is broken
src/ai/ai_client.c ai_models_find() allocates a fresh Autocomplete on
every call and frees it before returning. The Autocomplete's last_found
cursor is therefore never persisted, so repeated calls with the same
prefix always return the first match. Tab+Tab+Tab cannot reach models
2, 3, ...
Caught by:
- test_ai_models_find_cycles_through_matches
- test_ai_models_find_null_search_cycles_all
BUG B — providers_ac is never reset between user input cycles
src/ai/ai_client.c keeps the static providers_ac AC, but
src/command/cmd_ac.c's all_acs[] (which cmd_ac_reset() iterates) does
not include &providers_ac. So when the input loop fires the global
reset, providers_ac retains its last_found cursor from the previous
prefix.
Result: tab-completing a new prefix continues from the old cursor
position instead of restarting at the head of the new prefix's matches.
A provider added mid-session may also be missed depending on cursor
position.
Caught by:
- test_ai_providers_find_state_resets_on_prefix_change
- test_ai_providers_find_empty_then_prefix
- test_ai_providers_find_after_add_includes_new
Sanity (5 passing):
- test_ai_models_find_no_models_returns_null
- test_ai_models_find_returns_match_for_prefix
- test_ai_models_find_no_match_returns_null
- test_ai_models_find_previous_direction
- test_ai_providers_find_after_remove_skips_removed
The failing tests are checked in as-is — they go green when the bugs
are fixed. See PR description for suggested fixes.
147 lines
7.0 KiB
C
147 lines
7.0 KiB
C
/*
|
|
* test_ai_client.h - AI client unit test declarations
|
|
*/
|
|
|
|
int ai_client_setup(void** state);
|
|
int ai_client_teardown(void** state);
|
|
|
|
void test_ai_client_init(void** state);
|
|
void test_ai_add_provider(void** state);
|
|
void test_ai_remove_provider(void** state);
|
|
void test_ai_list_providers(void** state);
|
|
void test_ai_set_provider_key(void** state);
|
|
void test_ai_get_provider_key(void** state);
|
|
void test_ai_session_create(void** state);
|
|
void test_ai_session_ref_unref(void** state);
|
|
void test_ai_session_add_message(void** state);
|
|
void test_ai_session_clear_history(void** state);
|
|
void test_ai_session_set_model(void** state);
|
|
void test_ai_json_escape(void** state);
|
|
void test_ai_json_escape_null(void** state);
|
|
void test_ai_json_escape_empty(void** state);
|
|
void test_ai_json_escape_special_chars(void** state);
|
|
void test_ai_json_escape_percent_signs(void** state);
|
|
void test_ai_json_escape_backslash_quote(void** state);
|
|
void test_ai_session_api_key_is_copied(void** state);
|
|
void test_ai_add_provider_update_existing(void** state);
|
|
void test_ai_add_provider_null_name_returns_null(void** state);
|
|
void test_ai_add_provider_null_url_returns_null(void** state);
|
|
void test_ai_session_create_null_provider_returns_null(void** state);
|
|
void test_ai_session_create_null_model_returns_null(void** state);
|
|
void test_ai_session_api_key_null_when_no_key_set(void** state);
|
|
/* Provider autocomplete tests */
|
|
void test_ai_providers_find_forward(void** state);
|
|
void test_ai_providers_find_forward_perplexity(void** state);
|
|
void test_ai_providers_find_forward_custom(void** state);
|
|
void test_ai_providers_find_forward_no_match(void** state);
|
|
void test_ai_providers_find_forward_partial_match(void** state);
|
|
void test_ai_providers_find_next(void** state);
|
|
void test_ai_providers_find_previous(void** state);
|
|
void test_ai_providers_find_null_search_str(void** state);
|
|
void test_ai_providers_find_empty_search_str(void** state);
|
|
void test_ai_providers_find_case_insensitive(void** state);
|
|
/* Provider default model and settings tests */
|
|
void test_ai_set_provider_default_model(void** state);
|
|
void test_ai_get_provider_default_model(void** state);
|
|
void test_ai_set_provider_setting(void** state);
|
|
void test_ai_get_provider_setting(void** state);
|
|
/* Model caching tests */
|
|
void test_ai_models_are_fresh_initial(void** state);
|
|
/* Model parsing tests */
|
|
void test_ai_parse_models_openai_format(void** state);
|
|
void test_ai_parse_models_perplexity_format(void** state);
|
|
void test_ai_parse_models_array_format(void** state);
|
|
void test_ai_parse_models_empty_json(void** state);
|
|
void test_ai_parse_models_null_handling(void** state);
|
|
void test_ai_parse_models_escaped_quotes(void** state);
|
|
void test_ai_parse_models_with_whitespace(void** state);
|
|
/* AI autocomplete integration tests */
|
|
void test_ai_start_provider_autocomplete_only_on_exact(void** state);
|
|
void test_ai_models_find_null_session(void** state);
|
|
void test_ai_models_find_null_provider(void** state);
|
|
void test_ai_providers_find_cycling(void** state);
|
|
|
|
/* Setup that also initializes prefs for round-trip persistence tests. */
|
|
int ai_client_setup_with_prefs(void** state);
|
|
int ai_client_teardown_with_prefs(void** state);
|
|
|
|
/* Chat response parser tests (ai_parse_response) */
|
|
void test_ai_parse_response_openai_content(void** state);
|
|
void test_ai_parse_response_perplexity_text(void** state);
|
|
void test_ai_parse_response_text_preferred_over_content(void** state);
|
|
void test_ai_parse_response_escaped_quote(void** state);
|
|
void test_ai_parse_response_newline_escape(void** state);
|
|
void test_ai_parse_response_empty_content(void** state);
|
|
void test_ai_parse_response_missing_field(void** state);
|
|
void test_ai_parse_response_null_input(void** state);
|
|
void test_ai_parse_response_empty_input(void** state);
|
|
void test_ai_parse_response_percent_signs_safe(void** state);
|
|
void test_ai_parse_response_braces_in_content(void** state);
|
|
void test_ai_parse_response_multiline_content(void** state);
|
|
|
|
/* Error response parser tests (ai_parse_error_message) */
|
|
void test_ai_parse_error_standard_envelope(void** state);
|
|
void test_ai_parse_error_with_escapes(void** state);
|
|
void test_ai_parse_error_no_error_field(void** state);
|
|
void test_ai_parse_error_no_message_field(void** state);
|
|
void test_ai_parse_error_null_input(void** state);
|
|
void test_ai_parse_error_empty_input(void** state);
|
|
void test_ai_parse_error_tab_escape(void** state);
|
|
void test_ai_parse_error_backslash_escape(void** state);
|
|
|
|
/* Extended JSON escape tests */
|
|
void test_ai_json_escape_backspace(void** state);
|
|
void test_ai_json_escape_formfeed(void** state);
|
|
void test_ai_json_escape_carriage_return(void** state);
|
|
void test_ai_json_escape_all_specials_combined(void** state);
|
|
void test_ai_json_escape_passes_utf8_through(void** state);
|
|
|
|
/* Autocomplete cycling with many providers */
|
|
void test_ai_providers_find_cycles_through_many(void** state);
|
|
void test_ai_providers_find_previous_walks_backwards(void** state);
|
|
void test_ai_providers_find_wraps_around(void** state);
|
|
|
|
/* Session edge cases */
|
|
void test_ai_session_add_message_null_session_no_crash(void** state);
|
|
void test_ai_session_add_message_null_role_no_crash(void** state);
|
|
void test_ai_session_add_message_null_content_no_crash(void** state);
|
|
void test_ai_session_history_preserves_large_order(void** state);
|
|
void test_ai_session_clear_empty_history(void** state);
|
|
void test_ai_session_set_model_null_keeps_old(void** state);
|
|
void test_ai_session_unref_null_no_crash(void** state);
|
|
void test_ai_session_ref_null_returns_null(void** state);
|
|
|
|
/* Provider edge cases */
|
|
void test_ai_get_provider_null_returns_null(void** state);
|
|
void test_ai_remove_provider_null_returns_false(void** state);
|
|
void test_ai_remove_provider_twice_second_fails(void** state);
|
|
void test_ai_provider_survives_via_session_after_removal(void** state);
|
|
|
|
/* Settings edge cases */
|
|
void test_ai_settings_multiple_keys_independent(void** state);
|
|
void test_ai_settings_get_missing_returns_null(void** state);
|
|
void test_ai_settings_isolated_between_providers(void** state);
|
|
|
|
/* Model parsing edge cases */
|
|
void test_ai_parse_models_data_not_array(void** state);
|
|
void test_ai_parse_models_empty_data_array(void** state);
|
|
void test_ai_parse_models_id_outside_data_ignored(void** state);
|
|
void test_ai_parse_models_multiple_models(void** state);
|
|
|
|
/* Prefs round-trip tests */
|
|
void test_ai_prefs_round_trip_api_key(void** state);
|
|
void test_ai_prefs_round_trip_remove_key(void** state);
|
|
void test_ai_prefs_multiple_providers_persist(void** state);
|
|
|
|
/* Autocomplete deeper coverage */
|
|
void test_ai_models_find_no_models_returns_null(void** state);
|
|
void test_ai_models_find_returns_match_for_prefix(void** state);
|
|
void test_ai_models_find_no_match_returns_null(void** state);
|
|
void test_ai_models_find_cycles_through_matches(void** state);
|
|
void test_ai_models_find_previous_direction(void** state);
|
|
void test_ai_models_find_null_search_cycles_all(void** state);
|
|
void test_ai_providers_find_state_resets_on_prefix_change(void** state);
|
|
void test_ai_providers_find_empty_then_prefix(void** state);
|
|
void test_ai_providers_find_after_remove_skips_removed(void** state);
|
|
void test_ai_providers_find_after_add_includes_new(void** state);
|