All checks were successful
CI Code / Check spelling (push) Successful in 18s
CI Code / Check coding style (push) Successful in 34s
CI Code / Code Coverage (push) Successful in 2m36s
CI Code / Linux (debian) (push) Successful in 4m41s
CI Code / Linux (ubuntu) (push) Successful in 4m52s
CI Code / Linux (arch) (push) Successful in 5m40s
Sync with upstream profanity-im/profanity.
Major upstream changes incorporated:
Memory management
- Replace malloc+memset with g_new0 throughout codebase
- Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
- Replace free() with g_free() for GAlloc'd memory
Editor rewrite
- Remove pthread-based async editor; use GChildWatch callback API
- New launch_editor(initial_content, callback, user_data) interface
- Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
- ui_suspend()/ui_resume() integration for TTY management
OMEMO improvements
- Dual backend support: libsignal-protocol-c and libomemo-c
- Proper pre-key removal after use (XEP-0384 compliance)
- Automatic pre-key regeneration when store drops below threshold
- New functions: omemo_is_device_active(), omemo_is_jid_trusted()
- omemo_get_jid_untrusted_fingerprints() for better error messages
- Fingerprint notifications on new device identity discovery
- Deterministic pre-key ID generation tracking max_pre_key_id
- omemo_trust_changed() UI updates on trust state changes
JID validation
- RFC 6122-compliant validation in jid_is_valid()
- Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
- Length limits: 1023 per component, 3071 total
- New jid_is_valid_user_jid() for user vs. service JID distinction
Database
- Schema migration v3: UNIQUE constraint on archive_id for deduplication
- Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
- db_history_result_t return type, _truncate_datetime_suffix()
UI / console
- win_warn_needed() / win_warn_sent() warning deduplication hash table
- PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
- Spellcheck integration in input field with Unicode word detection
- cons_spellcheck_setting() for /settings ui output
- /[command]? shortcut for command help
Account config
- Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
- Replace popen() with g_spawn_sync() for eval_password
- TLS policy: add "direct" option alongside legacy
Connection
- Port validation with g_assert (0–65535)
- SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
- "direct" TLS policy alias for legacy SSL
Common utilities
- str_xml_sanitize() for XML 1.0 illegal character removal
- string_matches_one_of() with formatted error messages
- valid_tls_policy_option() helper
- prof_date_time_format_iso8601() utility
- Improved strip_arg_quotes() with backslash unescaping
- prof_occurrences() uses g_slist_prepend + reverse for performance
PGP / OX
- Proper GPGME resource cleanup with goto-cleanup pattern
- g_string_free(xmppuri) leak fix in _ox_key_lookup
CSV export
- Use GString + g_file_set_contents instead of raw write() syscalls
Tests
- Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
- New test_cmd_ac.c for autocompleter unit tests
- Updated stubs for new UI suspend/resume functions
License headers
- Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)
────────────────────────────────────────────────────
cproof-specific preservations:
- XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
- Force encryption: cmd_force_encryption, test_forced_encryption
- CWE-134: format string protection (cons_show("%s", ...))
- y_start_pos-based paging in window.c
- db_history_result_t return type, _truncate_datetime_suffix()
Merge-time fixes:
- common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
- database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
- console.c: implicit size_t → int cast — (int)(maxlen + 1)
- tlscerts.c: %d for size_t — %zu
Build system:
- Kept autotools (Makefile.am, configure.ac); upstream uses Meson
- Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
- Updated Makefile.am test paths for subdirectory structure
- Added test_cmd_ac, test_forced_encryption to test sources
Functional tests:
- Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
- Not yet available in devs/stabber fork
Closes #64
Merge author: jabber.developer2
Commits authors:
Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
165 lines
5.9 KiB
C
165 lines
5.9 KiB
C
/*
|
|
* aesgcm_download.c
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
|
|
* Copyright (C) 2020 William Wennerström <william@wstrm.dev>
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <curl/curl.h>
|
|
#include <gio/gio.h>
|
|
#include <pthread.h>
|
|
#include <assert.h>
|
|
#include <errno.h>
|
|
|
|
#include "profanity.h"
|
|
#include "event/client_events.h"
|
|
#include "tools/http_common.h"
|
|
#include "tools/aesgcm_download.h"
|
|
#include "omemo/omemo.h"
|
|
#include "config/preferences.h"
|
|
#include "ui/ui.h"
|
|
#include "ui/window.h"
|
|
#include "common.h"
|
|
|
|
void*
|
|
aesgcm_file_get(void* userdata)
|
|
{
|
|
AESGCMDownload* aesgcm_dl = (AESGCMDownload*)userdata;
|
|
|
|
auto_char char* https_url = NULL;
|
|
auto_char char* fragment = NULL;
|
|
|
|
// Convert the aesgcm:// URL to a https:// URL and extract the encoded key
|
|
// and tag stored in the URL fragment.
|
|
if (omemo_parse_aesgcm_url(aesgcm_dl->url, &https_url, &fragment) != 0) {
|
|
cons_show_error("Download failed: Cannot parse URL '%s'.", aesgcm_dl->url);
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ERROR, ENTRY_ERROR,
|
|
"Download failed: Cannot parse URL '%s'.",
|
|
aesgcm_dl->url);
|
|
return NULL;
|
|
}
|
|
|
|
// Create a temporary file used for storing the ciphertext that is to be
|
|
// retrieved from the https:// URL.
|
|
auto_gchar gchar* tmpname = NULL;
|
|
auto_gfd gint tmpfd = 0;
|
|
if ((tmpfd = g_file_open_tmp("profanity.XXXXXX", &tmpname, NULL)) == -1) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ERROR, ENTRY_ERROR,
|
|
"Downloading '%s' failed: Unable to create "
|
|
"temporary ciphertext file for writing "
|
|
"(%s).",
|
|
https_url, g_strerror(errno));
|
|
return NULL;
|
|
}
|
|
|
|
// Open the target file for storing the cleartext.
|
|
auto_FILE FILE* outfh = fopen(aesgcm_dl->filename, "wb");
|
|
if (outfh == NULL) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ERROR, ENTRY_ERROR,
|
|
"Downloading '%s' failed: Unable to open "
|
|
"output file at '%s' for writing (%s).",
|
|
https_url, aesgcm_dl->filename,
|
|
g_strerror(errno));
|
|
return NULL;
|
|
}
|
|
|
|
// We wrap the HTTPDownload tool and use it for retrieving the ciphertext
|
|
// and storing it in the temporary file previously opened.
|
|
HTTPDownload* http_dl = g_new0(HTTPDownload, 1);
|
|
http_dl->window = aesgcm_dl->window;
|
|
http_dl->worker = aesgcm_dl->worker;
|
|
http_dl->id = strdup(aesgcm_dl->id);
|
|
http_dl->url = strdup(https_url);
|
|
http_dl->display_url = strdup(aesgcm_dl->url);
|
|
http_dl->filename = strdup(tmpname);
|
|
http_dl->cmd_template = NULL;
|
|
http_dl->silent = FALSE;
|
|
http_dl->silent_done = TRUE;
|
|
http_dl->return_bytes_received = TRUE;
|
|
aesgcm_dl->http_dl = http_dl;
|
|
|
|
ssize_t* p_bytes_received = http_file_get(http_dl);
|
|
if (!p_bytes_received) {
|
|
return NULL;
|
|
}
|
|
ssize_t bytes_received = *p_bytes_received;
|
|
free(p_bytes_received);
|
|
|
|
FILE* tmpfh = fopen(tmpname, "rb");
|
|
if (tmpfh == NULL) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ERROR, ENTRY_ERROR,
|
|
"Downloading '%s' failed: Unable to open "
|
|
"temporary file at '%s' for reading (%s).",
|
|
aesgcm_dl->url, tmpname,
|
|
g_strerror(errno));
|
|
return NULL;
|
|
}
|
|
|
|
gcry_error_t crypt_res;
|
|
crypt_res = omemo_decrypt_file(tmpfh, outfh,
|
|
bytes_received, fragment);
|
|
fclose(tmpfh);
|
|
remove(tmpname);
|
|
|
|
if (crypt_res != GPG_ERR_NO_ERROR) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ERROR, ENTRY_ERROR,
|
|
"Downloading '%s' failed: Failed to decrypt "
|
|
"file (%s).",
|
|
https_url, gcry_strerror(crypt_res));
|
|
} else {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ONLINE, ENTRY_COMPLETED,
|
|
"Downloading '%s': done\nSaved to '%s'",
|
|
aesgcm_dl->url, aesgcm_dl->filename);
|
|
win_mark_received(aesgcm_dl->window, aesgcm_dl->id);
|
|
}
|
|
|
|
if (aesgcm_dl->cmd_template != NULL) {
|
|
gchar** argv = format_call_external_argv(aesgcm_dl->cmd_template,
|
|
aesgcm_dl->filename,
|
|
aesgcm_dl->filename);
|
|
|
|
// TODO: Log the error.
|
|
if (!call_external(argv)) {
|
|
http_print_transfer_update(aesgcm_dl->window, aesgcm_dl->id, THEME_ERROR, ENTRY_ERROR,
|
|
"Downloading '%s' failed: Unable to call "
|
|
"command '%s' with file at '%s' (%s).",
|
|
aesgcm_dl->url,
|
|
aesgcm_dl->cmd_template,
|
|
aesgcm_dl->filename,
|
|
"TODO: Log the error");
|
|
}
|
|
|
|
g_strfreev(argv);
|
|
free(aesgcm_dl->cmd_template);
|
|
}
|
|
|
|
free(aesgcm_dl->id);
|
|
free(aesgcm_dl->filename);
|
|
free(aesgcm_dl->url);
|
|
free(aesgcm_dl);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
void
|
|
aesgcm_download_cancel_processes(ProfWin* window)
|
|
{
|
|
http_download_cancel_processes(window);
|
|
}
|
|
|
|
void
|
|
aesgcm_download_add_download(AESGCMDownload* aesgcm_dl)
|
|
{
|
|
http_download_add_download(aesgcm_dl->http_dl);
|
|
}
|