devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity
Files
b34faa209984621822670ed64d6a8da90327864a
cproof/src/plugins/c_plugins.c
Jabber Developer 72f4f186da
All checks were successful
CI Code / Check spelling (push) Successful in 18s
Details
CI Code / Check coding style (push) Successful in 34s
Details
CI Code / Code Coverage (push) Successful in 2m36s
Details
CI Code / Linux (debian) (push) Successful in 4m41s
Details
CI Code / Linux (ubuntu) (push) Successful in 4m52s
Details
CI Code / Linux (arch) (push) Successful in 5m40s
Details
merge: sync upstream profanity-im/profanity 
Sync with upstream profanity-im/profanity.

Major upstream changes incorporated:

Memory management
  - Replace malloc+memset with g_new0 throughout codebase
  - Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
  - Replace free() with g_free() for GAlloc'd memory

Editor rewrite
  - Remove pthread-based async editor; use GChildWatch callback API
  - New launch_editor(initial_content, callback, user_data) interface
  - Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
  - ui_suspend()/ui_resume() integration for TTY management

OMEMO improvements
  - Dual backend support: libsignal-protocol-c and libomemo-c
  - Proper pre-key removal after use (XEP-0384 compliance)
  - Automatic pre-key regeneration when store drops below threshold
  - New functions: omemo_is_device_active(), omemo_is_jid_trusted()
  - omemo_get_jid_untrusted_fingerprints() for better error messages
  - Fingerprint notifications on new device identity discovery
  - Deterministic pre-key ID generation tracking max_pre_key_id
  - omemo_trust_changed() UI updates on trust state changes

JID validation
  - RFC 6122-compliant validation in jid_is_valid()
  - Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
  - Length limits: 1023 per component, 3071 total
  - New jid_is_valid_user_jid() for user vs. service JID distinction

Database
  - Schema migration v3: UNIQUE constraint on archive_id for deduplication
  - Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
  - db_history_result_t return type, _truncate_datetime_suffix()

UI / console
  - win_warn_needed() / win_warn_sent() warning deduplication hash table
  - PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
  - Spellcheck integration in input field with Unicode word detection
  - cons_spellcheck_setting() for /settings ui output
  - /[command]? shortcut for command help

Account config
  - Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
  - Replace popen() with g_spawn_sync() for eval_password
  - TLS policy: add "direct" option alongside legacy

Connection
  - Port validation with g_assert (0–65535)
  - SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
  - "direct" TLS policy alias for legacy SSL

Common utilities
  - str_xml_sanitize() for XML 1.0 illegal character removal
  - string_matches_one_of() with formatted error messages
  - valid_tls_policy_option() helper
  - prof_date_time_format_iso8601() utility
  - Improved strip_arg_quotes() with backslash unescaping
  - prof_occurrences() uses g_slist_prepend + reverse for performance

PGP / OX
  - Proper GPGME resource cleanup with goto-cleanup pattern
  - g_string_free(xmppuri) leak fix in _ox_key_lookup

CSV export
  - Use GString + g_file_set_contents instead of raw write() syscalls

Tests
  - Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
  - New test_cmd_ac.c for autocompleter unit tests
  - Updated stubs for new UI suspend/resume functions

License headers
  - Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)

────────────────────────────────────────────────────
cproof-specific preservations:

  - XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
  - Force encryption: cmd_force_encryption, test_forced_encryption
  - CWE-134: format string protection (cons_show("%s", ...))
  - y_start_pos-based paging in window.c
  - db_history_result_t return type, _truncate_datetime_suffix()

Merge-time fixes:

  - common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
  - database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
  - console.c: implicit size_t → int cast — (int)(maxlen + 1)
  - tlscerts.c: %d for size_t — %zu

Build system:
  - Kept autotools (Makefile.am, configure.ac); upstream uses Meson
  - Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
  - Updated Makefile.am test paths for subdirectory structure
  - Added test_cmd_ac, test_forced_encryption to test sources

Functional tests:
  - Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
  - Not yet available in devs/stabber fork

Closes #64

Merge author: jabber.developer2
Commits authors:
 Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
2026-05-26 17:48:14 +00:00

546 lines
16 KiB
C
Raw Blame History

/*
* c_plugins.c
* vim: expandtab:ts=4:sts=4:sw=4
*
* Copyright (C) 2012 - 2019 James Booth <boothj5@gmail.com>
*
* SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
*/
#include "config.h"
#include <dlfcn.h>
#include <stdlib.h>
#include <assert.h>
#include <string.h>
#include <glib.h>
#include "log.h"
#include "config/preferences.h"
#include "config/files.h"
#include "plugins/api.h"
#include "plugins/callbacks.h"
#include "plugins/disco.h"
#include "plugins/plugins.h"
#include "plugins/c_plugins.h"
#include "plugins/c_api.h"
#include "ui/ui.h"
void
c_env_init(void)
{
c_api_init();
}
ProfPlugin*
c_plugin_create(const char* const filename)
{
ProfPlugin* plugin;
void* handle = NULL;
auto_gchar gchar* plugins_dir = files_get_data_path(DIR_PLUGINS);
GString* path = g_string_new(plugins_dir);
g_string_append(path, "/");
g_string_append(path, filename);
handle = dlopen(path->str, RTLD_NOW | RTLD_GLOBAL);
if (!handle) {
log_warning("dlopen failed to open `%s', %s", filename, dlerror());
g_string_free(path, TRUE);
return NULL;
}
plugin = g_new0(ProfPlugin, 1);
plugin->name = g_strdup(filename);
plugin->lang = LANG_C;
plugin->module = handle;
plugin->init_func = c_init_hook;
plugin->contains_hook = c_contains_hook;
plugin->on_start_func = c_on_start_hook;
plugin->on_shutdown_func = c_on_shutdown_hook;
plugin->on_unload_func = c_on_unload_hook;
plugin->on_connect_func = c_on_connect_hook;
plugin->on_disconnect_func = c_on_disconnect_hook;
plugin->pre_chat_message_display = c_pre_chat_message_display_hook;
plugin->post_chat_message_display = c_post_chat_message_display_hook;
plugin->pre_chat_message_send = c_pre_chat_message_send_hook;
plugin->post_chat_message_send = c_post_chat_message_send_hook;
plugin->pre_room_message_display = c_pre_room_message_display_hook;
plugin->post_room_message_display = c_post_room_message_display_hook;
plugin->pre_room_message_send = c_pre_room_message_send_hook;
plugin->post_room_message_send = c_post_room_message_send_hook;
plugin->on_room_history_message = c_on_room_history_message_hook;
plugin->pre_priv_message_display = c_pre_priv_message_display_hook;
plugin->post_priv_message_display = c_post_priv_message_display_hook;
plugin->pre_priv_message_send = c_pre_priv_message_send_hook;
plugin->post_priv_message_send = c_post_priv_message_send_hook;
plugin->on_message_stanza_send = c_on_message_stanza_send_hook;
plugin->on_message_stanza_receive = c_on_message_stanza_receive_hook;
plugin->on_presence_stanza_send = c_on_presence_stanza_send_hook;
plugin->on_presence_stanza_receive = c_on_presence_stanza_receive_hook;
plugin->on_iq_stanza_send = c_on_iq_stanza_send_hook;
plugin->on_iq_stanza_receive = c_on_iq_stanza_receive_hook;
plugin->on_contact_offline = c_on_contact_offline_hook;
plugin->on_contact_presence = c_on_contact_presence_hook;
plugin->on_chat_win_focus = c_on_chat_win_focus_hook;
plugin->on_room_win_focus = c_on_room_win_focus_hook;
g_string_free(path, TRUE);
return plugin;
}
void
c_init_hook(ProfPlugin* plugin, const char* const version, const char* const status, const char* const account_name,
const char* const fulljid)
{
void* f = NULL;
void (*func)(const char* const __version, const char* const __status, const char* const __account_name,
const char* const __fulljid);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_init"))) {
log_warning("warning: %s does not have init function", plugin->name);
return;
}
func = (void (*)(const char* const, const char* const, const char* const, const char* const))f;
// FIXME maybe we want to make it boolean to see if it succeeded or not?
func(version, status, account_name, fulljid);
}
gboolean
c_contains_hook(ProfPlugin* plugin, const char* const hook)
{
if (dlsym(plugin->module, hook)) {
return TRUE;
} else {
return FALSE;
}
}
void
c_on_start_hook(ProfPlugin* plugin)
{
void* f = NULL;
void (*func)(void);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_start")))
return;
func = (void (*)(void))f;
func();
}
void
c_on_shutdown_hook(ProfPlugin* plugin)
{
void* f = NULL;
void (*func)(void);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_shutdown")))
return;
func = (void (*)(void))f;
func();
}
void
c_on_unload_hook(ProfPlugin* plugin)
{
void* f = NULL;
void (*func)(void);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_unload")))
return;
func = (void (*)(void))f;
func();
}
void
c_on_connect_hook(ProfPlugin* plugin, const char* const account_name, const char* const fulljid)
{
void* f = NULL;
void (*func)(const char* const __account_name, const char* const __fulljid);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_connect")))
return;
func = (void (*)(const char* const, const char* const))f;
func(account_name, fulljid);
}
void
c_on_disconnect_hook(ProfPlugin* plugin, const char* const account_name, const char* const fulljid)
{
void* f = NULL;
void (*func)(const char* const __account_name, const char* const __fulljid);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_disconnect")))
return;
func = (void (*)(const char* const, const char* const))f;
func(account_name, fulljid);
}
char*
c_pre_chat_message_display_hook(ProfPlugin* plugin, const char* const barejid, const char* const resource, const char* message)
{
void* f = NULL;
char* (*func)(const char* const __barejid, const char* const __resource, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_pre_chat_message_display")))
return NULL;
func = (char* (*)(const char* const, const char* const, const char*))f;
return func(barejid, resource, message);
}
void
c_post_chat_message_display_hook(ProfPlugin* plugin, const char* const barejid, const char* const resource, const char* message)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __resource, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_post_chat_message_display")))
return;
func = (void (*)(const char* const, const char* const, const char*))f;
func(barejid, resource, message);
}
char*
c_pre_chat_message_send_hook(ProfPlugin* plugin, const char* const barejid, const char* message)
{
void* f = NULL;
char* (*func)(const char* const __barejid, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_pre_chat_message_send")))
return NULL;
func = (char* (*)(const char* const, const char*))f;
return func(barejid, message);
}
void
c_post_chat_message_send_hook(ProfPlugin* plugin, const char* const barejid, const char* message)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_post_chat_message_send")))
return;
func = (void (*)(const char* const, const char*))f;
func(barejid, message);
}
char*
c_pre_room_message_display_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick, const char* message)
{
void* f = NULL;
char* (*func)(const char* const __barejid, const char* const __nick, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_pre_room_message_display")))
return NULL;
func = (char* (*)(const char* const, const char* const, const char*))f;
return func(barejid, nick, message);
}
void
c_post_room_message_display_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick,
const char* message)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __nick, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_post_room_message_display")))
return;
func = (void (*)(const char* const, const char* const, const char*))f;
func(barejid, nick, message);
}
char*
c_pre_room_message_send_hook(ProfPlugin* plugin, const char* const barejid, const char* message)
{
void* f = NULL;
char* (*func)(const char* const __barejid, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_pre_room_message_send")))
return NULL;
func = (char* (*)(const char* const, const char*))f;
return func(barejid, message);
}
void
c_post_room_message_send_hook(ProfPlugin* plugin, const char* const barejid, const char* message)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_post_room_message_send")))
return;
func = (void (*)(const char* const, const char*))f;
func(barejid, message);
}
void
c_on_room_history_message_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick,
const char* const message, const char* const timestamp)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __nick, const char* const __message,
const char* const __timestamp);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_room_history_message")))
return;
func = (void (*)(const char* const, const char* const, const char* const, const char* const))f;
func(barejid, nick, message, timestamp);
}
char*
c_pre_priv_message_display_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick, const char* message)
{
void* f = NULL;
char* (*func)(const char* const __barejid, const char* const __nick, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_pre_priv_message_display")))
return NULL;
func = (char* (*)(const char* const, const char* const, const char*))f;
return func(barejid, nick, message);
}
void
c_post_priv_message_display_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick,
const char* message)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __nick, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_post_priv_message_display")))
return;
func = (void (*)(const char* const, const char* const, const char*))f;
func(barejid, nick, message);
}
char*
c_pre_priv_message_send_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick, const char* message)
{
void* f = NULL;
char* (*func)(const char* const __barejid, const char* const __nick, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_pre_priv_message_send")))
return NULL;
func = (char* (*)(const char* const, const char* const, const char*))f;
return func(barejid, nick, message);
}
void
c_post_priv_message_send_hook(ProfPlugin* plugin, const char* const barejid, const char* const nick, const char* message)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __nick, const char* __message);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_post_priv_message_send")))
return;
func = (void (*)(const char* const, const char* const, const char*))f;
func(barejid, nick, message);
}
char*
c_on_message_stanza_send_hook(ProfPlugin* plugin, const char* const text)
{
void* f = NULL;
char* (*func)(const char* const __text);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_message_stanza_send")))
return NULL;
func = (char* (*)(const char* const))f;
return func(text);
}
gboolean
c_on_message_stanza_receive_hook(ProfPlugin* plugin, const char* const text)
{
void* f = NULL;
int (*func)(const char* const __text);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_message_stanza_receive")))
return TRUE;
func = (int (*)(const char* const))f;
return func(text);
}
char*
c_on_presence_stanza_send_hook(ProfPlugin* plugin, const char* const text)
{
void* f = NULL;
char* (*func)(const char* const __text);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_presence_stanza_send")))
return NULL;
func = (char* (*)(const char* const))f;
return func(text);
}
gboolean
c_on_presence_stanza_receive_hook(ProfPlugin* plugin, const char* const text)
{
void* f = NULL;
int (*func)(const char* const __text);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_presence_stanza_receive")))
return TRUE;
func = (int (*)(const char* const))f;
return func(text);
}
char*
c_on_iq_stanza_send_hook(ProfPlugin* plugin, const char* const text)
{
void* f = NULL;
char* (*func)(const char* const __text);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_iq_stanza_send")))
return NULL;
func = (char* (*)(const char* const))f;
return func(text);
}
gboolean
c_on_iq_stanza_receive_hook(ProfPlugin* plugin, const char* const text)
{
void* f = NULL;
int (*func)(const char* const __text);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_iq_stanza_receive")))
return TRUE;
func = (int (*)(const char* const))f;
return func(text);
}
void
c_on_contact_offline_hook(ProfPlugin* plugin, const char* const barejid, const char* const resource,
const char* const status)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __resource, const char* const __status);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_contact_offline")))
return;
func = (void (*)(const char* const, const char* const, const char* const))f;
func(barejid, resource, status);
}
void
c_on_contact_presence_hook(ProfPlugin* plugin, const char* const barejid, const char* const resource,
const char* const presence, const char* const status, const int priority)
{
void* f = NULL;
void (*func)(const char* const __barejid, const char* const __resource, const char* const __presence,
const char* const __status, const int __priority);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_contact_presence")))
return;
func = (void (*)(const char* const, const char* const, const char* const, const char* const, const int))f;
func(barejid, resource, presence, status, priority);
}
void
c_on_chat_win_focus_hook(ProfPlugin* plugin, const char* const barejid)
{
void* f = NULL;
void (*func)(const char* const __barejid);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_chat_win_focus")))
return;
func = (void (*)(const char* const))f;
func(barejid);
}
void
c_on_room_win_focus_hook(ProfPlugin* plugin, const char* const barejid)
{
void* f = NULL;
void (*func)(const char* const __barejid);
assert(plugin && plugin->module);
if (NULL == (f = dlsym(plugin->module, "prof_on_room_win_focus")))
return;
func = (void (*)(const char* const))f;
func(barejid);
}
void
c_plugin_destroy(ProfPlugin* plugin)
{
assert(plugin && plugin->module);
callbacks_remove(plugin->name);
disco_remove_features(plugin->name);
if (dlclose(plugin->module)) {
log_warning("dlclose failed to close `%s' with `%s'", plugin->name, dlerror());
}
free(plugin->name);
free(plugin);
}
void
c_shutdown(void)
{
}
Reference in New Issue View Git Blame Copy Permalink