All checks were successful
CI Code / Check spelling (push) Successful in 18s
CI Code / Check coding style (push) Successful in 34s
CI Code / Code Coverage (push) Successful in 2m36s
CI Code / Linux (debian) (push) Successful in 4m41s
CI Code / Linux (ubuntu) (push) Successful in 4m52s
CI Code / Linux (arch) (push) Successful in 5m40s
Sync with upstream profanity-im/profanity.
Major upstream changes incorporated:
Memory management
- Replace malloc+memset with g_new0 throughout codebase
- Adopt auto_gchar / auto_gcharv / auto_gerror / auto_jid cleanup macros
- Replace free() with g_free() for GAlloc'd memory
Editor rewrite
- Remove pthread-based async editor; use GChildWatch callback API
- New launch_editor(initial_content, callback, user_data) interface
- Proper signal handling (SIGINT, SIGTSTP, SIGPIPE reset in child)
- ui_suspend()/ui_resume() integration for TTY management
OMEMO improvements
- Dual backend support: libsignal-protocol-c and libomemo-c
- Proper pre-key removal after use (XEP-0384 compliance)
- Automatic pre-key regeneration when store drops below threshold
- New functions: omemo_is_device_active(), omemo_is_jid_trusted()
- omemo_get_jid_untrusted_fingerprints() for better error messages
- Fingerprint notifications on new device identity discovery
- Deterministic pre-key ID generation tracking max_pre_key_id
- omemo_trust_changed() UI updates on trust state changes
JID validation
- RFC 6122-compliant validation in jid_is_valid()
- Character-level checks (RFC 6122 forbidden chars: & ' / : < > @)
- Length limits: 1023 per component, 3071 total
- New jid_is_valid_user_jid() for user vs. service JID distinction
Database
- Schema migration v3: UNIQUE constraint on archive_id for deduplication
- Triggers for corrected message tracking (replaces_db_id / replaced_by_db_id)
- db_history_result_t return type, _truncate_datetime_suffix()
UI / console
- win_warn_needed() / win_warn_sent() warning deduplication hash table
- PAD_MIN_HEIGHT dynamic pad sizing with PAD_THRESHOLD auto-cleanup
- Spellcheck integration in input field with Unicode word detection
- cons_spellcheck_setting() for /settings ui output
- /[command]? shortcut for command help
Account config
- Account name sanitization for GKeyFile special chars ([ ] = # \n \r)
- Replace popen() with g_spawn_sync() for eval_password
- TLS policy: add "direct" option alongside legacy
Connection
- Port validation with g_assert (0–65535)
- SHA-256 certificate fingerprint support (XMPP_CERT_PUBKEY_FINGERPRINT_SHA256)
- "direct" TLS policy alias for legacy SSL
Common utilities
- str_xml_sanitize() for XML 1.0 illegal character removal
- string_matches_one_of() with formatted error messages
- valid_tls_policy_option() helper
- prof_date_time_format_iso8601() utility
- Improved strip_arg_quotes() with backslash unescaping
- prof_occurrences() uses g_slist_prepend + reverse for performance
PGP / OX
- Proper GPGME resource cleanup with goto-cleanup pattern
- g_string_free(xmppuri) leak fix in _ox_key_lookup
CSV export
- Use GString + g_file_set_contents instead of raw write() syscalls
Tests
- Restructured into subdirectories: command/, config/, xmpp/, ui/, omemo/, otr/, pgp/
- New test_cmd_ac.c for autocompleter unit tests
- Updated stubs for new UI suspend/resume functions
License headers
- Migrate to SPDX-3.0 identifiers (GPL-3.0-or-later WITH OpenSSL-exception)
────────────────────────────────────────────────────
cproof-specific preservations:
- XEP-0308 LMC: replace_id ?: id logic in message/stanza/omemo
- Force encryption: cmd_force_encryption, test_forced_encryption
- CWE-134: format string protection (cons_show("%s", ...))
- y_start_pos-based paging in window.c
- db_history_result_t return type, _truncate_datetime_suffix()
Merge-time fixes:
- common.c: format-security (-Werror) — cons_show(errmsg) → cons_show("%s", errmsg)
- database.c: null-deref guard — !msg->timestamp → msg && !msg->timestamp
- console.c: implicit size_t → int cast — (int)(maxlen + 1)
- tlscerts.c: %d for size_t — %zu
Build system:
- Kept autotools (Makefile.am, configure.ac); upstream uses Meson
- Restored deleted files: bootstrap.sh, autogen.sh, ax_valgrind_check.m4, configure-debug
- Updated Makefile.am test paths for subdirectory structure
- Added test_cmd_ac, test_forced_encryption to test sources
Functional tests:
- Use cproof version; upstream requires stbbr_for_xmlns from updated stabber
- Not yet available in devs/stabber fork
Closes #64
Merge author: jabber.developer2
Commits authors:
Michael Vetter <jubalh@iodoru.org>
& Steffen Jaeckel <s@jaeckel.eu>
258 lines
9.9 KiB
C
258 lines
9.9 KiB
C
/*
|
|
* store.h
|
|
* vim: expandtab:ts=4:sts=4:sw=4
|
|
*
|
|
* Copyright (C) 2019 Paul Fariello <paul@fariello.eu>
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later WITH OpenSSL-exception
|
|
*/
|
|
#include "config.h"
|
|
|
|
#ifdef HAVE_LIBOMEMO_C
|
|
#include <omemo/signal_protocol.h>
|
|
#else
|
|
#include <signal/signal_protocol.h>
|
|
#endif
|
|
|
|
#define OMEMO_STORE_GROUP_IDENTITY "identity"
|
|
#define OMEMO_STORE_GROUP_PREKEYS "prekeys"
|
|
#define OMEMO_STORE_GROUP_SIGNED_PREKEYS "signed_prekeys"
|
|
#define OMEMO_STORE_KEY_DEVICE_ID "device_id"
|
|
#define OMEMO_STORE_KEY_REGISTRATION_ID "registration_id"
|
|
#define OMEMO_STORE_KEY_IDENTITY_KEY_PUBLIC "identity_key_public"
|
|
#define OMEMO_STORE_KEY_IDENTITY_KEY_PRIVATE "identity_key_private"
|
|
|
|
typedef struct
|
|
{
|
|
signal_buffer* public;
|
|
signal_buffer* private;
|
|
uint32_t registration_id;
|
|
GHashTable* trusted;
|
|
gboolean recv;
|
|
} identity_key_store_t;
|
|
|
|
GHashTable* session_store_new(void);
|
|
GHashTable* pre_key_store_new(void);
|
|
GHashTable* signed_pre_key_store_new(void);
|
|
void identity_key_store_new(identity_key_store_t* identity_key_store);
|
|
void identity_key_store_destroy(identity_key_store_t* identity_key_store);
|
|
|
|
/**
|
|
* Returns a copy of the serialized session record corresponding to the
|
|
* provided recipient ID + device ID tuple.
|
|
*
|
|
* @param record pointer to a freshly allocated buffer containing the
|
|
* serialized session record. Unset if no record was found.
|
|
* The Signal Protocol library is responsible for freeing this buffer.
|
|
* @param address the address of the remote client
|
|
* @return 1 if the session was loaded, 0 if the session was not found, negative on failure
|
|
*/
|
|
int load_session(signal_buffer** record, signal_buffer** user_record, const signal_protocol_address* address, void* user_data);
|
|
|
|
/**
|
|
* Returns all known devices with active sessions for a recipient
|
|
*
|
|
* @param pointer to an array that will be allocated and populated with the result
|
|
* @param name the name of the remote client
|
|
* @param name_len the length of the name
|
|
* @return size of the sessions array, or negative on failure
|
|
*/
|
|
int get_sub_device_sessions(signal_int_list** sessions, const char* name, size_t name_len, void* user_data);
|
|
|
|
/**
|
|
* Commit to storage the session record for a given
|
|
* recipient ID + device ID tuple.
|
|
*
|
|
* @param address the address of the remote client
|
|
* @param record pointer to a buffer containing the serialized session
|
|
* record for the remote client
|
|
* @param record_len length of the serialized session record
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int store_session(const signal_protocol_address* address, uint8_t* record, size_t record_len, uint8_t* user_record, size_t user_record_len, void* user_data);
|
|
|
|
/**
|
|
* Determine whether there is a committed session record for a
|
|
* recipient ID + device ID tuple.
|
|
*
|
|
* @param address the address of the remote client
|
|
* @return 1 if a session record exists, 0 otherwise.
|
|
*/
|
|
int contains_session(const signal_protocol_address* address, void* user_data);
|
|
|
|
/**
|
|
* Remove a session record for a recipient ID + device ID tuple.
|
|
*
|
|
* @param address the address of the remote client
|
|
* @return 1 if a session was deleted, 0 if a session was not deleted, negative on error
|
|
*/
|
|
int delete_session(const signal_protocol_address* address, void* user_data);
|
|
|
|
/**
|
|
* Remove the session records corresponding to all devices of a recipient ID.
|
|
*
|
|
* @param name the name of the remote client
|
|
* @param name_len the length of the name
|
|
* @return the number of deleted sessions on success, negative on failure
|
|
*/
|
|
int delete_all_sessions(const char* name, size_t name_len, void* user_data);
|
|
|
|
/**
|
|
* Load a local serialized PreKey record.
|
|
*
|
|
* @param record pointer to a newly allocated buffer containing the record,
|
|
* if found. Unset if no record was found.
|
|
* The Signal Protocol library is responsible for freeing this buffer.
|
|
* @param pre_key_id the ID of the local serialized PreKey record
|
|
* @retval SG_SUCCESS if the key was found
|
|
* @retval SG_ERR_INVALID_KEY_ID if the key could not be found
|
|
*/
|
|
int load_pre_key(signal_buffer** record, uint32_t pre_key_id, void* user_data);
|
|
|
|
/**
|
|
* Store a local serialized PreKey record.
|
|
*
|
|
* @param pre_key_id the ID of the PreKey record to store.
|
|
* @param record pointer to a buffer containing the serialized record
|
|
* @param record_len length of the serialized record
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int store_pre_key(uint32_t pre_key_id, uint8_t* record, size_t record_len, void* user_data);
|
|
|
|
/**
|
|
* Determine whether there is a committed PreKey record matching the
|
|
* provided ID.
|
|
*
|
|
* @param pre_key_id A PreKey record ID.
|
|
* @return 1 if the store has a record for the PreKey ID, 0 otherwise
|
|
*/
|
|
int contains_pre_key(uint32_t pre_key_id, void* user_data);
|
|
|
|
/**
|
|
* Delete a PreKey record from local storage.
|
|
*
|
|
* @param pre_key_id The ID of the PreKey record to remove.
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int remove_pre_key(uint32_t pre_key_id, void* user_data);
|
|
|
|
/**
|
|
* Load a local serialized signed PreKey record.
|
|
*
|
|
* @param record pointer to a newly allocated buffer containing the record,
|
|
* if found. Unset if no record was found.
|
|
* The Signal Protocol library is responsible for freeing this buffer.
|
|
* @param signed_pre_key_id the ID of the local signed PreKey record
|
|
* @retval SG_SUCCESS if the key was found
|
|
* @retval SG_ERR_INVALID_KEY_ID if the key could not be found
|
|
*/
|
|
int load_signed_pre_key(signal_buffer** record, uint32_t signed_pre_key_id, void* user_data);
|
|
|
|
/**
|
|
* Store a local serialized signed PreKey record.
|
|
*
|
|
* @param signed_pre_key_id the ID of the signed PreKey record to store
|
|
* @param record pointer to a buffer containing the serialized record
|
|
* @param record_len length of the serialized record
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int store_signed_pre_key(uint32_t signed_pre_key_id, uint8_t* record, size_t record_len, void* user_data);
|
|
|
|
/**
|
|
* Determine whether there is a committed signed PreKey record matching
|
|
* the provided ID.
|
|
*
|
|
* @param signed_pre_key_id A signed PreKey record ID.
|
|
* @return 1 if the store has a record for the signed PreKey ID, 0 otherwise
|
|
*/
|
|
int contains_signed_pre_key(uint32_t signed_pre_key_id, void* user_data);
|
|
|
|
/**
|
|
* Delete a SignedPreKeyRecord from local storage.
|
|
*
|
|
* @param signed_pre_key_id The ID of the signed PreKey record to remove.
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int remove_signed_pre_key(uint32_t signed_pre_key_id, void* user_data);
|
|
|
|
/**
|
|
* Get the local client's identity key pair.
|
|
*
|
|
* @param public_data pointer to a newly allocated buffer containing the
|
|
* public key, if found. Unset if no record was found.
|
|
* The Signal Protocol library is responsible for freeing this buffer.
|
|
* @param private_data pointer to a newly allocated buffer containing the
|
|
* private key, if found. Unset if no record was found.
|
|
* The Signal Protocol library is responsible for freeing this buffer.
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int get_identity_key_pair(signal_buffer** public_data, signal_buffer** private_data, void* user_data);
|
|
|
|
/**
|
|
* Return the local client's registration ID.
|
|
*
|
|
* Clients should maintain a registration ID, a random number
|
|
* between 1 and 16380 that's generated once at install time.
|
|
*
|
|
* @param registration_id pointer to be set to the local client's
|
|
* registration ID, if it was successfully retrieved.
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int get_local_registration_id(void* user_data, uint32_t* registration_id);
|
|
|
|
/**
|
|
* Save a remote client's identity key
|
|
* <p>
|
|
* Store a remote client's identity key as trusted.
|
|
* The value of key_data may be null. In this case remove the key data
|
|
* from the identity store, but retain any metadata that may be kept
|
|
* alongside it.
|
|
*
|
|
* @param address the address of the remote client
|
|
* @param key_data Pointer to the remote client's identity key, may be null
|
|
* @param key_len Length of the remote client's identity key
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int save_identity(const signal_protocol_address* address, uint8_t* key_data, size_t key_len, void* user_data);
|
|
|
|
/**
|
|
* Verify a remote client's identity key.
|
|
*
|
|
* Determine whether a remote client's identity is trusted. Convention is
|
|
* that the TextSecure protocol is 'trust on first use.' This means that
|
|
* an identity key is considered 'trusted' if there is no entry for the recipient
|
|
* in the local store, or if it matches the saved key for a recipient in the local
|
|
* store. Only if it mismatches an entry in the local store is it considered
|
|
* 'untrusted.'
|
|
*
|
|
* @param address the address of the remote client
|
|
* @param identityKey The identity key to verify.
|
|
* @param key_data Pointer to the identity key to verify
|
|
* @param key_len Length of the identity key to verify
|
|
* @return 1 if trusted, 0 if untrusted, negative on failure
|
|
*/
|
|
int is_trusted_identity(const signal_protocol_address* address, uint8_t* key_data, size_t key_len, void* user_data);
|
|
|
|
/**
|
|
* Store a serialized sender key record for a given
|
|
* (groupId + senderId + deviceId) tuple.
|
|
*
|
|
* @param sender_key_name the (groupId + senderId + deviceId) tuple
|
|
* @param record pointer to a buffer containing the serialized record
|
|
* @param record_len length of the serialized record
|
|
* @return 0 on success, negative on failure
|
|
*/
|
|
int store_sender_key(const signal_protocol_sender_key_name* sender_key_name, uint8_t* record, size_t record_len, uint8_t* user_record, size_t user_record_len, void* user_data);
|
|
|
|
/**
|
|
* Returns a copy of the sender key record corresponding to the
|
|
* (groupId + senderId + deviceId) tuple.
|
|
*
|
|
* @param record pointer to a newly allocated buffer containing the record,
|
|
* if found. Unset if no record was found.
|
|
* The Signal Protocol library is responsible for freeing this buffer.
|
|
* @param sender_key_name the (groupId + senderId + deviceId) tuple
|
|
* @return 1 if the record was loaded, 0 if the record was not found, negative on failure
|
|
*/
|
|
int load_sender_key(signal_buffer** record, signal_buffer** user_record, const signal_protocol_sender_key_name* sender_key_name, void* user_data);
|